diff options
author | Fabian Frederick <fabf@skynet.be> | 2014-06-06 17:37:31 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-06 19:08:13 -0400 |
commit | ef74885353e0ee4d884604148628df3369c76719 (patch) | |
tree | 504568bb692e56cbac76d4d57e268c56cbff0991 /fs/pstore/platform.c | |
parent | f3da64d1ea12ed6cfe18e6dedbc9739743e0b884 (diff) |
fs/pstore: logging clean-up
- Define pr_fmt in plateform.c and ram_core.c for global prefix.
- Coalesce format fragments.
- Separate format/arguments on lines > 80 characters.
Note: Some pr_foo() were initially declared without prefix and therefore
this could break existing log analyzer.
[akpm@linux-foundation.org: missed a couple of prefix removals]
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Cc: Joe Perches <joe@perches.com>
Cc: Anton Vorontsov <anton@enomsg.org>
Cc: Colin Cross <ccross@android.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/pstore/platform.c')
-rw-r--r-- | fs/pstore/platform.c | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 46d269e38706..0a9b72cdfeca 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c | |||
@@ -18,6 +18,8 @@ | |||
18 | * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | 18 | * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA |
19 | */ | 19 | */ |
20 | 20 | ||
21 | #define pr_fmt(fmt) "pstore: " fmt | ||
22 | |||
21 | #include <linux/atomic.h> | 23 | #include <linux/atomic.h> |
22 | #include <linux/types.h> | 24 | #include <linux/types.h> |
23 | #include <linux/errno.h> | 25 | #include <linux/errno.h> |
@@ -224,14 +226,12 @@ static void allocate_buf_for_compression(void) | |||
224 | zlib_inflate_workspacesize()); | 226 | zlib_inflate_workspacesize()); |
225 | stream.workspace = kmalloc(size, GFP_KERNEL); | 227 | stream.workspace = kmalloc(size, GFP_KERNEL); |
226 | if (!stream.workspace) { | 228 | if (!stream.workspace) { |
227 | pr_err("pstore: No memory for compression workspace; " | 229 | pr_err("No memory for compression workspace; skipping compression\n"); |
228 | "skipping compression\n"); | ||
229 | kfree(big_oops_buf); | 230 | kfree(big_oops_buf); |
230 | big_oops_buf = NULL; | 231 | big_oops_buf = NULL; |
231 | } | 232 | } |
232 | } else { | 233 | } else { |
233 | pr_err("No memory for uncompressed data; " | 234 | pr_err("No memory for uncompressed data; skipping compression\n"); |
234 | "skipping compression\n"); | ||
235 | stream.workspace = NULL; | 235 | stream.workspace = NULL; |
236 | } | 236 | } |
237 | 237 | ||
@@ -455,8 +455,7 @@ int pstore_register(struct pstore_info *psi) | |||
455 | add_timer(&pstore_timer); | 455 | add_timer(&pstore_timer); |
456 | } | 456 | } |
457 | 457 | ||
458 | pr_info("pstore: Registered %s as persistent store backend\n", | 458 | pr_info("Registered %s as persistent store backend\n", psi->name); |
459 | psi->name); | ||
460 | 459 | ||
461 | return 0; | 460 | return 0; |
462 | } | 461 | } |
@@ -502,8 +501,8 @@ void pstore_get_records(int quiet) | |||
502 | size = unzipped_len; | 501 | size = unzipped_len; |
503 | compressed = false; | 502 | compressed = false; |
504 | } else { | 503 | } else { |
505 | pr_err("pstore: decompression failed;" | 504 | pr_err("decompression failed;returned %d\n", |
506 | "returned %d\n", unzipped_len); | 505 | unzipped_len); |
507 | compressed = true; | 506 | compressed = true; |
508 | } | 507 | } |
509 | } | 508 | } |
@@ -524,8 +523,8 @@ out: | |||
524 | mutex_unlock(&psi->read_mutex); | 523 | mutex_unlock(&psi->read_mutex); |
525 | 524 | ||
526 | if (failed) | 525 | if (failed) |
527 | printk(KERN_WARNING "pstore: failed to load %d record(s) from '%s'\n", | 526 | pr_warn("failed to load %d record(s) from '%s'\n", |
528 | failed, psi->name); | 527 | failed, psi->name); |
529 | } | 528 | } |
530 | 529 | ||
531 | static void pstore_dowork(struct work_struct *work) | 530 | static void pstore_dowork(struct work_struct *work) |