diff options
author | Milind Arun Choudhary <milindchoudhary@gmail.com> | 2009-02-20 08:56:45 -0500 |
---|---|---|
committer | Alexey Dobriyan <adobriyan@gmail.com> | 2009-03-30 17:14:22 -0400 |
commit | 09729a9919fdaf137995b0f19cbd401e22229cac (patch) | |
tree | 54b187f7fade4f4669f37935f019b6f8c23b5df4 /fs/proc | |
parent | 1681bc30f272dd2fe347b90468791b05c7044f03 (diff) |
proc: fix sparse warnings in pagemap_read()
fs/proc/task_mmu.c:696:12: warning: cast removes address space of expression
fs/proc/task_mmu.c:696:9: warning: incorrect type in assignment (different address spaces)
fs/proc/task_mmu.c:696:9: expected unsigned long long [noderef] [usertype] <asn:1>*out
fs/proc/task_mmu.c:696:9: got unsigned long long [usertype] *<noident>
fs/proc/task_mmu.c:697:12: warning: cast removes address space of expression
fs/proc/task_mmu.c:697:9: warning: incorrect type in assignment (different address spaces)
fs/proc/task_mmu.c:697:9: expected unsigned long long [noderef] [usertype] <asn:1>*end
fs/proc/task_mmu.c:697:9: got unsigned long long [usertype] *<noident>
fs/proc/task_mmu.c:723:12: warning: cast removes address space of expression
fs/proc/task_mmu.c:723:26: error: subtraction of different types can't work (different address spaces)
fs/proc/task_mmu.c:725:24: error: subtraction of different types can't work (different address spaces)
Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Diffstat (limited to 'fs/proc')
-rw-r--r-- | fs/proc/task_mmu.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 94063840832a..b0ae0be4801f 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c | |||
@@ -693,8 +693,8 @@ static ssize_t pagemap_read(struct file *file, char __user *buf, | |||
693 | goto out_pages; | 693 | goto out_pages; |
694 | } | 694 | } |
695 | 695 | ||
696 | pm.out = (u64 *)buf; | 696 | pm.out = (u64 __user *)buf; |
697 | pm.end = (u64 *)(buf + count); | 697 | pm.end = (u64 __user *)(buf + count); |
698 | 698 | ||
699 | pagemap_walk.pmd_entry = pagemap_pte_range; | 699 | pagemap_walk.pmd_entry = pagemap_pte_range; |
700 | pagemap_walk.pte_hole = pagemap_pte_hole; | 700 | pagemap_walk.pte_hole = pagemap_pte_hole; |
@@ -720,9 +720,9 @@ static ssize_t pagemap_read(struct file *file, char __user *buf, | |||
720 | if (ret == PM_END_OF_BUFFER) | 720 | if (ret == PM_END_OF_BUFFER) |
721 | ret = 0; | 721 | ret = 0; |
722 | /* don't need mmap_sem for these, but this looks cleaner */ | 722 | /* don't need mmap_sem for these, but this looks cleaner */ |
723 | *ppos += (char *)pm.out - buf; | 723 | *ppos += (char __user *)pm.out - buf; |
724 | if (!ret) | 724 | if (!ret) |
725 | ret = (char *)pm.out - buf; | 725 | ret = (char __user *)pm.out - buf; |
726 | 726 | ||
727 | out_pages: | 727 | out_pages: |
728 | for (; pagecount; pagecount--) { | 728 | for (; pagecount; pagecount--) { |