diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2011-06-12 09:42:17 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-06-12 17:45:28 -0400 |
| commit | ff78fca2a03c08436535d3f7152a30752d8131d1 (patch) | |
| tree | 314de976604243449825241d814fb80b9a1e89b4 /fs/proc | |
| parent | b99ca60c83a631adaba9c2fff8f2dd14d3517a61 (diff) | |
fix leak in proc_set_super()
set_anon_super() can fail...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/proc')
| -rw-r--r-- | fs/proc/root.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/fs/proc/root.c b/fs/proc/root.c index a9000e9cfee5..d6c3b416529b 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c | |||
| @@ -28,11 +28,12 @@ static int proc_test_super(struct super_block *sb, void *data) | |||
| 28 | 28 | ||
| 29 | static int proc_set_super(struct super_block *sb, void *data) | 29 | static int proc_set_super(struct super_block *sb, void *data) |
| 30 | { | 30 | { |
| 31 | struct pid_namespace *ns; | 31 | int err = set_anon_super(sb, NULL); |
| 32 | 32 | if (!err) { | |
| 33 | ns = (struct pid_namespace *)data; | 33 | struct pid_namespace *ns = (struct pid_namespace *)data; |
| 34 | sb->s_fs_info = get_pid_ns(ns); | 34 | sb->s_fs_info = get_pid_ns(ns); |
| 35 | return set_anon_super(sb, NULL); | 35 | } |
| 36 | return err; | ||
| 36 | } | 37 | } |
| 37 | 38 | ||
| 38 | static struct dentry *proc_mount(struct file_system_type *fs_type, | 39 | static struct dentry *proc_mount(struct file_system_type *fs_type, |