aboutsummaryrefslogtreecommitdiffstats
path: root/fs/proc
diff options
context:
space:
mode:
authorFrederic Weisbecker <fweisbec@gmail.com>2010-03-30 01:32:50 -0400
committerFrederic Weisbecker <fweisbec@gmail.com>2010-05-16 21:06:24 -0400
commitc2f980500a81006173daf3048284b28832858616 (patch)
treedb8aa6354bd8393f0e2033ec04c532b72b9b0d37 /fs/proc
parentd79b6f4de5db0103ceb4734e42ad101d836d61d9 (diff)
procfs: Kill the bkl in ioctl
There are no more users of procfs that implement the ioctl callback. Drop the bkl from this path and warn on any use of this callback. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Ingo Molnar <mingo@elte.hu> Cc: John Kacur <jkacur@redhat.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Al Viro <viro@ZenIV.linux.org.uk>
Diffstat (limited to 'fs/proc')
-rw-r--r--fs/proc/inode.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index 445a02bcaab3..afcda8588e1c 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -231,9 +231,9 @@ static long proc_reg_unlocked_ioctl(struct file *file, unsigned int cmd, unsigne
231 if (rv == -ENOIOCTLCMD) 231 if (rv == -ENOIOCTLCMD)
232 rv = -EINVAL; 232 rv = -EINVAL;
233 } else if (ioctl) { 233 } else if (ioctl) {
234 lock_kernel(); 234 WARN_ONCE(1, "Procfs ioctl handlers must use unlocked_ioctl, "
235 "%pf will be called without the Bkl held\n", ioctl);
235 rv = ioctl(file->f_path.dentry->d_inode, file, cmd, arg); 236 rv = ioctl(file->f_path.dentry->d_inode, file, cmd, arg);
236 unlock_kernel();
237 } 237 }
238 238
239 pde_users_dec(pde); 239 pde_users_dec(pde);