diff options
author | Ravikiran G Thirumalai <kiran@scalex86.org> | 2007-10-17 02:26:28 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:42:49 -0400 |
commit | f13ef7754f724842dbf5ae6d85d0604fff0d1a84 (patch) | |
tree | cb2b9d5b9bbe9650df9c8a14871302dd6a5e3193 /fs/proc/proc_misc.c | |
parent | af49d9248fca6f26cbdb01918334f71d9040df80 (diff) |
report the per-irq statistics on all arches
Commit 4004c69ad68dd03733179277280ea2946990ba36 avoids too many remote cpu
references while reporting per-irq stats. Since we will not have the same
performance penalty of bringing in remote cpu cachelines while reporting
per-irq stats anymore, we can now afford to be consistent and report this
statistic on all arches, all configs.
akpm: affects ia64, alpha and ppc64, mainly.
Kiran earlier said:
Read to /proc/stat takes:
Plain: 2.622832
With speedup patch: 0.013194
With the per-irq stats commented out: 0.008124
So the performance problems which originally caused those architectures to
disable this statistic should now be fixed up.
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/proc/proc_misc.c')
-rw-r--r-- | fs/proc/proc_misc.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c index 5de7f874d95c..d6dc72c78bc1 100644 --- a/fs/proc/proc_misc.c +++ b/fs/proc/proc_misc.c | |||
@@ -526,11 +526,8 @@ static int show_stat(struct seq_file *p, void *v) | |||
526 | } | 526 | } |
527 | seq_printf(p, "intr %llu", (unsigned long long)sum); | 527 | seq_printf(p, "intr %llu", (unsigned long long)sum); |
528 | 528 | ||
529 | #ifndef CONFIG_SMP | ||
530 | /* Touches too many cache lines on SMP setups */ | ||
531 | for (i = 0; i < NR_IRQS; i++) | 529 | for (i = 0; i < NR_IRQS; i++) |
532 | seq_printf(p, " %u", per_irq_sum[i]); | 530 | seq_printf(p, " %u", per_irq_sum[i]); |
533 | #endif | ||
534 | 531 | ||
535 | seq_printf(p, | 532 | seq_printf(p, |
536 | "\nctxt %llu\n" | 533 | "\nctxt %llu\n" |