diff options
author | Will Deacon <will.deacon@arm.com> | 2012-05-25 06:39:13 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-05-30 21:04:55 -0400 |
commit | 46ce341b2f176c2611f12ac390adf862e932eb02 (patch) | |
tree | 17884033d37ddf08d20b69739aa5a3559c232fc0 /fs/pipe.c | |
parent | 3f50fff4dace23d3cfeb195d5cd4ee813cee68b7 (diff) |
pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command
As described in commit 07d106d0a ("vfs: fix up ENOIOCTLCMD error
handling"), drivers should return -ENOIOCTLCMD if they receive an ioctl
command which they don't understand. Doing so will result in -ENOTTY
being returned to userspace, which matches the behaviour of the compat
layer if it fails to translate an ioctl command.
This patch fixes the pipe ioctl to return -ENOIOCTLCMD instead of
-EINVAL when passed an unknown ioctl command.
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/pipe.c')
-rw-r--r-- | fs/pipe.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -693,7 +693,7 @@ static long pipe_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) | |||
693 | 693 | ||
694 | return put_user(count, (int __user *)arg); | 694 | return put_user(count, (int __user *)arg); |
695 | default: | 695 | default: |
696 | return -EINVAL; | 696 | return -ENOIOCTLCMD; |
697 | } | 697 | } |
698 | } | 698 | } |
699 | 699 | ||