[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem

This patch converts the inode semaphore to a mutex. I have tested it on
XFS and compiled as much as one can consider on an ia64. Anyway your
luck with it might be different.

Modified-by: Ingo Molnar <mingo@elte.hu>

(finished the conversion)

Signed-off-by: Jes Sorensen <jes@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

7 files changed, 35 insertions, 35 deletions

diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
index 465f797451ee..6b9812db3779 100644
--- a/fs/ocfs2/alloc.c
+++ b/fs/ocfs2/alloc.c
@@ -966,7 +966,7 @@ static int ocfs2_truncate_log_append(struct ocfs2_super *osb,
         mlog_entry("start_blk = %"MLFu64", num_clusters = %u\n", start_blk,
                    num_clusters);
 
-        BUG_ON(!down_trylock(&tl_inode->i_sem));
+        BUG_ON(mutex_trylock(&tl_inode->i_mutex));
 
         start_cluster = ocfs2_blocks_to_clusters(osb->sb, start_blk);
 
@@ -1108,7 +1108,7 @@ bail:
         return status;
 }
 
-/* Expects you to already be holding tl_inode->i_sem */
+/* Expects you to already be holding tl_inode->i_mutex */
 static int __ocfs2_flush_truncate_log(struct ocfs2_super *osb)
 {
         int status;
@@ -1123,7 +1123,7 @@ static int __ocfs2_flush_truncate_log(struct ocfs2_super *osb)
 
         mlog_entry_void();
 
-        BUG_ON(!down_trylock(&tl_inode->i_sem));
+        BUG_ON(mutex_trylock(&tl_inode->i_mutex));
 
         di = (struct ocfs2_dinode *) tl_bh->b_data;
         tl = &di->id2.i_dealloc;
@@ -1198,9 +1198,9 @@ int ocfs2_flush_truncate_log(struct ocfs2_super *osb)
         int status;
         struct inode *tl_inode = osb->osb_tl_inode;
 
-        down(&tl_inode->i_sem);
+        mutex_lock(&tl_inode->i_mutex);
         status = __ocfs2_flush_truncate_log(osb);
-        up(&tl_inode->i_sem);
+        mutex_unlock(&tl_inode->i_mutex);
 
         return status;
 }
@@ -1363,7 +1363,7 @@ int ocfs2_complete_truncate_log_recovery(struct ocfs2_super *osb,
         mlog(0, "cleanup %u records from %"MLFu64"\n", num_recs,
              tl_copy->i_blkno);
 
-        down(&tl_inode->i_sem);
+        mutex_lock(&tl_inode->i_mutex);
         for(i = 0; i < num_recs; i++) {
                 if (ocfs2_truncate_log_needs_flush(osb)) {
                         status = __ocfs2_flush_truncate_log(osb);
@@ -1395,7 +1395,7 @@ int ocfs2_complete_truncate_log_recovery(struct ocfs2_super *osb,
         }
 
 bail_up:
-        up(&tl_inode->i_sem);
+        mutex_unlock(&tl_inode->i_mutex);
 
         mlog_exit(status);
         return status;
@@ -1840,7 +1840,7 @@ start:
 
         mlog(0, "clusters_to_del = %u in this pass\n", clusters_to_del);
 
-        down(&tl_inode->i_sem);
+        mutex_lock(&tl_inode->i_mutex);
         tl_sem = 1;
         /* ocfs2_truncate_log_needs_flush guarantees us at least one
          * record is free for use. If there isn't any, we flush to get
@@ -1875,7 +1875,7 @@ start:
                 goto bail;
         }
 
-        up(&tl_inode->i_sem);
+        mutex_unlock(&tl_inode->i_mutex);
         tl_sem = 0;
 
         ocfs2_commit_trans(handle);
@@ -1890,7 +1890,7 @@ bail:
         ocfs2_schedule_truncate_log_flush(osb, 1);
 
         if (tl_sem)
-                up(&tl_inode->i_sem);
+                mutex_unlock(&tl_inode->i_mutex);
 
         if (handle)
                 ocfs2_commit_trans(handle);
@@ -1994,7 +1994,7 @@ int ocfs2_prepare_truncate(struct ocfs2_super *osb,
                         goto bail;
                 }
 
-                down(&ext_alloc_inode->i_sem);
+                mutex_lock(&ext_alloc_inode->i_mutex);
                 (*tc)->tc_ext_alloc_inode = ext_alloc_inode;
 
                 status = ocfs2_meta_lock(ext_alloc_inode,
@@ -2026,7 +2026,7 @@ static void ocfs2_free_truncate_context(struct ocfs2_truncate_context *tc)
                 if (tc->tc_ext_alloc_locked)
                         ocfs2_meta_unlock(tc->tc_ext_alloc_inode, 1);
 
-                up(&tc->tc_ext_alloc_inode->i_sem);
+                mutex_unlock(&tc->tc_ext_alloc_inode->i_mutex);
                 iput(tc->tc_ext_alloc_inode);
         }
 
diff --git a/fs/ocfs2/cluster/nodemanager.c b/fs/ocfs2/cluster/nodemanager.c
index 5fd60c105913..cf7828f23361 100644
--- a/fs/ocfs2/cluster/nodemanager.c
+++ b/fs/ocfs2/cluster/nodemanager.c
@@ -653,7 +653,7 @@ static struct config_group *o2nm_cluster_group_make_group(struct config_group *g
         struct config_group *o2hb_group = NULL, *ret = NULL;
         void *defs = NULL;
 
-        /* this runs under the parent dir's i_sem; there can be only
+        /* this runs under the parent dir's i_mutex; there can be only
          * one caller in here at a time */
         if (o2nm_single_cluster)
                 goto out; /* ENOSPC */
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
index 856e20ae8263..57158fa75d91 100644
--- a/fs/ocfs2/dir.c
+++ b/fs/ocfs2/dir.c
@@ -202,7 +202,7 @@ bail:
 }
 
 /*
- * NOTE: this should always be called with parent dir i_sem taken.
+ * NOTE: this should always be called with parent dir i_mutex taken.
  */
 int ocfs2_find_files_on_disk(const char *name,
                              int namelen,
@@ -245,7 +245,7 @@ leave:
  * Return 0 if the name does not exist
  * Return -EEXIST if the directory contains the name
  *
- * Callers should have i_sem + a cluster lock on dir
+ * Callers should have i_mutex + a cluster lock on dir
  */
 int ocfs2_check_dir_for_entry(struct inode *dir,
                               const char *name,
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 72ae9e3306f4..ca5f9f90d794 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -492,7 +492,7 @@ restart_all:
         }
 
         /* blocks peope in read/write from reading our allocation
-         * until we're done changing it. We depend on i_sem to block
+         * until we're done changing it. We depend on i_mutex to block
          * other extend/truncate calls while we're here. Ordering wrt
          * start_trans is important here -- always do it before! */
         down_write(&OCFS2_I(inode)->ip_alloc_sem);
@@ -958,8 +958,8 @@ static ssize_t ocfs2_file_aio_write(struct kiocb *iocb,
                 filp->f_flags &= ~O_DIRECT;
 #endif
 
-        down(&inode->i_sem);
-        /* to match setattr's i_sem -> i_alloc_sem -> rw_lock ordering */
+        mutex_lock(&inode->i_mutex);
+        /* to match setattr's i_mutex -> i_alloc_sem -> rw_lock ordering */
         if (filp->f_flags & O_DIRECT) {
                 have_alloc_sem = 1;
                 down_read(&inode->i_alloc_sem);
@@ -1123,7 +1123,7 @@ out:
                 up_read(&inode->i_alloc_sem);
         if (rw_level != -1) 
                 ocfs2_rw_unlock(inode, rw_level);
-        up(&inode->i_sem);
+        mutex_unlock(&inode->i_mutex);
 
         mlog_exit(ret);
         return ret;
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index a91ba4dec936..d4ecc0627716 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -485,10 +485,10 @@ static int ocfs2_remove_inode(struct inode *inode,
                 goto bail;
         }
 
-        down(&inode_alloc_inode->i_sem);
+        mutex_lock(&inode_alloc_inode->i_mutex);
         status = ocfs2_meta_lock(inode_alloc_inode, NULL, &inode_alloc_bh, 1);
         if (status < 0) {
-                up(&inode_alloc_inode->i_sem);
+                mutex_unlock(&inode_alloc_inode->i_mutex);
 
                 mlog_errno(status);
                 goto bail;
@@ -536,7 +536,7 @@ bail_commit:
         ocfs2_commit_trans(handle);
 bail_unlock:
         ocfs2_meta_unlock(inode_alloc_inode, 1);
-        up(&inode_alloc_inode->i_sem);
+        mutex_unlock(&inode_alloc_inode->i_mutex);
         brelse(inode_alloc_bh);
 bail:
         iput(inode_alloc_inode);
@@ -567,10 +567,10 @@ static int ocfs2_wipe_inode(struct inode *inode,
         /* Lock the orphan dir. The lock will be held for the entire
          * delete_inode operation. We do this now to avoid races with
          * recovery completion on other nodes. */
-        down(&orphan_dir_inode->i_sem);
+        mutex_lock(&orphan_dir_inode->i_mutex);
         status = ocfs2_meta_lock(orphan_dir_inode, NULL, &orphan_dir_bh, 1);
         if (status < 0) {
-                up(&orphan_dir_inode->i_sem);
+                mutex_unlock(&orphan_dir_inode->i_mutex);
 
                 mlog_errno(status);
                 goto bail;
@@ -593,7 +593,7 @@ static int ocfs2_wipe_inode(struct inode *inode,
 
 bail_unlock_dir:
         ocfs2_meta_unlock(orphan_dir_inode, 1);
-        up(&orphan_dir_inode->i_sem);
+        mutex_unlock(&orphan_dir_inode->i_mutex);
         brelse(orphan_dir_bh);
 bail:
         iput(orphan_dir_inode);
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c
index 04428042e5e5..303c8d96457f 100644
--- a/fs/ocfs2/journal.c
+++ b/fs/ocfs2/journal.c
@@ -216,7 +216,7 @@ void ocfs2_handle_add_inode(struct ocfs2_journal_handle *handle,
         atomic_inc(&inode->i_count);
 
         /* we're obviously changing it... */
-        down(&inode->i_sem);
+        mutex_lock(&inode->i_mutex);
 
         /* sanity check */
         BUG_ON(OCFS2_I(inode)->ip_handle);
@@ -241,7 +241,7 @@ static void ocfs2_handle_unlock_inodes(struct ocfs2_journal_handle *handle)
                 OCFS2_I(inode)->ip_handle = NULL;
                 list_del_init(&OCFS2_I(inode)->ip_handle_list);
 
-                up(&inode->i_sem);
+                mutex_unlock(&inode->i_mutex);
                 iput(inode);
         }
 }
@@ -1433,10 +1433,10 @@ static int ocfs2_recover_orphans(struct ocfs2_super *osb,
                 goto out;
         }
 
-        down(&orphan_dir_inode->i_sem);
+        mutex_lock(&orphan_dir_inode->i_mutex);
         status = ocfs2_meta_lock(orphan_dir_inode, NULL, NULL, 0);
         if (status < 0) {
-                up(&orphan_dir_inode->i_sem);
+                mutex_unlock(&orphan_dir_inode->i_mutex);
                 mlog_errno(status);
                 goto out;
         }
@@ -1451,7 +1451,7 @@ static int ocfs2_recover_orphans(struct ocfs2_super *osb,
                 if (!bh)
                         status = -EINVAL;
                 if (status < 0) {
-                        up(&orphan_dir_inode->i_sem);
+                        mutex_unlock(&orphan_dir_inode->i_mutex);
                         if (bh)
                                 brelse(bh);
                         mlog_errno(status);
@@ -1465,7 +1465,7 @@ static int ocfs2_recover_orphans(struct ocfs2_super *osb,
 
                         if (!ocfs2_check_dir_entry(orphan_dir_inode,
                                                   de, bh, local)) {
-                                up(&orphan_dir_inode->i_sem);
+                                mutex_unlock(&orphan_dir_inode->i_mutex);
                                 status = -EINVAL;
                                 mlog_errno(status);
                                 brelse(bh);
@@ -1509,7 +1509,7 @@ static int ocfs2_recover_orphans(struct ocfs2_super *osb,
                 }
                 brelse(bh);
         }
-        up(&orphan_dir_inode->i_sem);
+        mutex_unlock(&orphan_dir_inode->i_mutex);
 
         ocfs2_meta_unlock(orphan_dir_inode, 0);
         have_disk_lock = 0;
diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
index fe373a2101d9..149b35181666 100644
--- a/fs/ocfs2/localalloc.c
+++ b/fs/ocfs2/localalloc.c
@@ -334,7 +334,7 @@ int ocfs2_begin_local_alloc_recovery(struct ocfs2_super *osb,
                 goto bail;
         }
 
-        down(&inode->i_sem);
+        mutex_lock(&inode->i_mutex);
 
         status = ocfs2_read_block(osb, OCFS2_I(inode)->ip_blkno,
                                   &alloc_bh, 0, inode);
@@ -367,7 +367,7 @@ bail:
                 brelse(alloc_bh);
 
         if (inode) {
-                up(&inode->i_sem);
+                mutex_unlock(&inode->i_mutex);
                 iput(inode);
         }
 
@@ -446,7 +446,7 @@ bail:
 
 /*
  * make sure we've got at least bitswanted contiguous bits in the
- * local alloc. You lose them when you drop i_sem.
+ * local alloc. You lose them when you drop i_mutex.
  *
  * We will add ourselves to the transaction passed in, but may start
  * our own in order to shift windows.