diff options
author | Zach Brown <zab@redhat.com> | 2013-05-07 19:18:25 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-07 21:38:27 -0400 |
commit | 41003a7bcfed1255032e1e7c7b487e505b22e298 (patch) | |
tree | b09cb3e5efaeaabbee5a27daff490f77c78aa27b /fs/ocfs2 | |
parent | a80bf61ef36da48285850974f30700d1e8efbfc0 (diff) |
aio: remove retry-based AIO
This removes the retry-based AIO infrastructure now that nothing in tree
is using it.
We want to remove retry-based AIO because it is fundemantally unsafe.
It retries IO submission from a kernel thread that has only assumed the
mm of the submitting task. All other task_struct references in the IO
submission path will see the kernel thread, not the submitting task.
This design flaw means that nothing of any meaningful complexity can use
retry-based AIO.
This removes all the code and data associated with the retry machinery.
The most significant benefit of this is the removal of the locking
around the unused run list in the submission path.
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Kent Overstreet <koverstreet@google.com>
Signed-off-by: Zach Brown <zab@redhat.com>
Cc: Zach Brown <zab@redhat.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Asai Thambi S P <asamymuthupa@micron.com>
Cc: Selvan Mani <smani@micron.com>
Cc: Sam Bradshaw <sbradshaw@micron.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Benjamin LaHaise <bcrl@kvack.org>
Reviewed-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ocfs2')
-rw-r--r-- | fs/ocfs2/dlmglue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 12ae194ac943..3a44a648dae7 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
@@ -2322,7 +2322,7 @@ int ocfs2_inode_lock_full_nested(struct inode *inode, | |||
2322 | status = __ocfs2_cluster_lock(osb, lockres, level, dlm_flags, | 2322 | status = __ocfs2_cluster_lock(osb, lockres, level, dlm_flags, |
2323 | arg_flags, subclass, _RET_IP_); | 2323 | arg_flags, subclass, _RET_IP_); |
2324 | if (status < 0) { | 2324 | if (status < 0) { |
2325 | if (status != -EAGAIN && status != -EIOCBRETRY) | 2325 | if (status != -EAGAIN) |
2326 | mlog_errno(status); | 2326 | mlog_errno(status); |
2327 | goto bail; | 2327 | goto bail; |
2328 | } | 2328 | } |