diff options
author | Tao Ma <tao.ma@oracle.com> | 2008-12-04 17:20:56 -0500 |
---|---|---|
committer | Mark Fasheh <mfasheh@suse.com> | 2009-01-05 11:40:36 -0500 |
commit | 90cb546cada68bb8c2278afdb4b65c2ac11f2877 (patch) | |
tree | 68f70ca93bf16cd20fbb039fa17cd4d3828a7df7 /fs/ocfs2 | |
parent | 4b3f6209bf9eec46fe5ebb168718fef5c443c157 (diff) |
ocfs2/xattr: fix credits calculation during index create
When creating a xattr index block, the old calculation forget
to add credits for the meta change of the alloc file. So add
more credits and more comments to explain it.
Signed-off-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
Diffstat (limited to 'fs/ocfs2')
-rw-r--r-- | fs/ocfs2/xattr.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 3e2e92d70594..73fb9f762512 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c | |||
@@ -2359,13 +2359,21 @@ meta_guess: | |||
2359 | } else | 2359 | } else |
2360 | xb = (struct ocfs2_xattr_block *)xbs->xattr_bh->b_data; | 2360 | xb = (struct ocfs2_xattr_block *)xbs->xattr_bh->b_data; |
2361 | 2361 | ||
2362 | /* | ||
2363 | * If there is already an xattr tree, good, we can calculate | ||
2364 | * like other b-trees. Otherwise we may have the chance of | ||
2365 | * create a tree, the credit calculation is borrowed from | ||
2366 | * ocfs2_calc_extend_credits with root_el = NULL. And the | ||
2367 | * new tree will be cluster based, so no meta is needed. | ||
2368 | */ | ||
2362 | if (le16_to_cpu(xb->xb_flags) & OCFS2_XATTR_INDEXED) { | 2369 | if (le16_to_cpu(xb->xb_flags) & OCFS2_XATTR_INDEXED) { |
2363 | struct ocfs2_extent_list *el = | 2370 | struct ocfs2_extent_list *el = |
2364 | &xb->xb_attrs.xb_root.xt_list; | 2371 | &xb->xb_attrs.xb_root.xt_list; |
2365 | meta_add += ocfs2_extend_meta_needed(el); | 2372 | meta_add += ocfs2_extend_meta_needed(el); |
2366 | credits += ocfs2_calc_extend_credits(inode->i_sb, | 2373 | credits += ocfs2_calc_extend_credits(inode->i_sb, |
2367 | el, 1); | 2374 | el, 1); |
2368 | } | 2375 | } else |
2376 | credits += OCFS2_SUBALLOC_ALLOC + 1; | ||
2369 | 2377 | ||
2370 | /* | 2378 | /* |
2371 | * This cluster will be used either for new bucket or for | 2379 | * This cluster will be used either for new bucket or for |