diff options
| author | alex chen <alex.chen@huawei.com> | 2014-04-03 17:47:05 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-04-03 19:20:56 -0400 |
| commit | f7cf4f5bfe073ad792ab49c04f247626b3e38db6 (patch) | |
| tree | 512d1d834e545b0b4de12b67b239f7b699356e2a /fs/ocfs2 | |
| parent | 466e68c4306317e7d239e3100f612d403e3e2c3c (diff) | |
ocfs2: do not put bh when buffer_uptodate failed
Do not put bh when buffer_uptodate failed in ocfs2_write_block and
ocfs2_write_super_or_backup, because it will put bh in b_end_io.
Otherwise it will hit a warning "VFS: brelse: Trying to free free
buffer".
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Reviewed-by: Joseph Qi <joseph.qi@huawei.com>
Reviewed-by: Srinivas Eeda <srinivas.eeda@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ocfs2')
| -rw-r--r-- | fs/ocfs2/buffer_head_io.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ocfs2/buffer_head_io.c b/fs/ocfs2/buffer_head_io.c index 5b704c63a103..1edcb141f639 100644 --- a/fs/ocfs2/buffer_head_io.c +++ b/fs/ocfs2/buffer_head_io.c | |||
| @@ -90,7 +90,6 @@ int ocfs2_write_block(struct ocfs2_super *osb, struct buffer_head *bh, | |||
| 90 | * information for this bh as it's not marked locally | 90 | * information for this bh as it's not marked locally |
| 91 | * uptodate. */ | 91 | * uptodate. */ |
| 92 | ret = -EIO; | 92 | ret = -EIO; |
| 93 | put_bh(bh); | ||
| 94 | mlog_errno(ret); | 93 | mlog_errno(ret); |
| 95 | } | 94 | } |
| 96 | 95 | ||
| @@ -420,7 +419,6 @@ int ocfs2_write_super_or_backup(struct ocfs2_super *osb, | |||
| 420 | 419 | ||
| 421 | if (!buffer_uptodate(bh)) { | 420 | if (!buffer_uptodate(bh)) { |
| 422 | ret = -EIO; | 421 | ret = -EIO; |
| 423 | put_bh(bh); | ||
| 424 | mlog_errno(ret); | 422 | mlog_errno(ret); |
| 425 | } | 423 | } |
| 426 | 424 | ||