diff options
author | Joseph Qi <joseph.qi@huawei.com> | 2015-04-14 18:43:10 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-04-14 19:48:57 -0400 |
commit | 37a8d89aee2a5b58812e19520d96632efe987f54 (patch) | |
tree | 3a37748f61c41beb12213bd67a46c45d25553936 /fs/ocfs2 | |
parent | 7e9b19551c8249baf380cbd274633ee4af95bc99 (diff) |
ocfs2: take inode lock when get clusters
We need take inode lock when calling ocfs2_get_clusters.
And use GFP_NOFS instead of GFP_KERNEL.
Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ocfs2')
-rw-r--r-- | fs/ocfs2/aops.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 2a618dd2577d..973a636285d1 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c | |||
@@ -772,10 +772,17 @@ static ssize_t ocfs2_direct_IO_write(struct kiocb *iocb, | |||
772 | u32 p_cpos = 0; | 772 | u32 p_cpos = 0; |
773 | u32 v_cpos = ocfs2_bytes_to_clusters(osb->sb, offset); | 773 | u32 v_cpos = ocfs2_bytes_to_clusters(osb->sb, offset); |
774 | 774 | ||
775 | ret = ocfs2_inode_lock(inode, NULL, 0); | ||
776 | if (ret < 0) { | ||
777 | mlog_errno(ret); | ||
778 | goto clean_orphan; | ||
779 | } | ||
780 | |||
775 | ret = ocfs2_get_clusters(inode, v_cpos, &p_cpos, | 781 | ret = ocfs2_get_clusters(inode, v_cpos, &p_cpos, |
776 | &num_clusters, &ext_flags); | 782 | &num_clusters, &ext_flags); |
777 | if (ret < 0) { | 783 | if (ret < 0) { |
778 | mlog_errno(ret); | 784 | mlog_errno(ret); |
785 | ocfs2_inode_unlock(inode, 0); | ||
779 | goto clean_orphan; | 786 | goto clean_orphan; |
780 | } | 787 | } |
781 | 788 | ||
@@ -783,9 +790,11 @@ static ssize_t ocfs2_direct_IO_write(struct kiocb *iocb, | |||
783 | 790 | ||
784 | ret = blkdev_issue_zeroout(osb->sb->s_bdev, | 791 | ret = blkdev_issue_zeroout(osb->sb->s_bdev, |
785 | p_cpos << (osb->s_clustersize_bits - 9), | 792 | p_cpos << (osb->s_clustersize_bits - 9), |
786 | zero_len >> 9, GFP_KERNEL, false); | 793 | zero_len >> 9, GFP_NOFS, false); |
787 | if (ret < 0) | 794 | if (ret < 0) |
788 | mlog_errno(ret); | 795 | mlog_errno(ret); |
796 | |||
797 | ocfs2_inode_unlock(inode, 0); | ||
789 | } | 798 | } |
790 | 799 | ||
791 | clean_orphan: | 800 | clean_orphan: |