aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ocfs2/super.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2010-02-24 07:25:33 -0500
committerArnd Bergmann <arnd@arndb.de>2010-10-04 15:10:51 -0400
commit60056794127a25d641465b706e8828186f7a2e1f (patch)
treed325fbc91d9eb5f1373d2a6c90dfe5bd34c4cc7d /fs/ocfs2/super.c
parent3dbc4b32d0b39701cbec65582e196a20889155fb (diff)
BKL: Remove BKL from OCFS2
The BKL in ocfs2/dlmfs is used in put_super, fill_super and remount_fs that are all three protected by the superblocks s_umount rw_semaphore. The use in ocfs2_control_open is evidently unrelated and the function is protected by ocfs2_control_lock. Therefore it is safe to remove the BKL entirely. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Mark Fasheh <mfasheh@suse.com> Cc: Joel Becker <joel.becker@oracle.com>
Diffstat (limited to 'fs/ocfs2/super.c')
-rw-r--r--fs/ocfs2/super.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index b7e4f2d19d40..b7d724393b5a 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -609,8 +609,6 @@ static int ocfs2_remount(struct super_block *sb, int *flags, char *data)
609 struct mount_options parsed_options; 609 struct mount_options parsed_options;
610 struct ocfs2_super *osb = OCFS2_SB(sb); 610 struct ocfs2_super *osb = OCFS2_SB(sb);
611 611
612 lock_kernel();
613
614 if (!ocfs2_parse_options(sb, data, &parsed_options, 1) || 612 if (!ocfs2_parse_options(sb, data, &parsed_options, 1) ||
615 !ocfs2_check_set_options(sb, &parsed_options)) { 613 !ocfs2_check_set_options(sb, &parsed_options)) {
616 ret = -EINVAL; 614 ret = -EINVAL;
@@ -717,7 +715,6 @@ unlock_osb:
717 MS_POSIXACL : 0); 715 MS_POSIXACL : 0);
718 } 716 }
719out: 717out:
720 unlock_kernel();
721 return ret; 718 return ret;
722} 719}
723 720
@@ -1002,8 +999,6 @@ static int ocfs2_fill_super(struct super_block *sb, void *data, int silent)
1002 char nodestr[8]; 999 char nodestr[8];
1003 struct ocfs2_blockcheck_stats stats; 1000 struct ocfs2_blockcheck_stats stats;
1004 1001
1005 lock_kernel();
1006
1007 mlog_entry("%p, %p, %i", sb, data, silent); 1002 mlog_entry("%p, %p, %i", sb, data, silent);
1008 1003
1009 if (!ocfs2_parse_options(sb, data, &parsed_options, 0)) { 1004 if (!ocfs2_parse_options(sb, data, &parsed_options, 0)) {
@@ -1181,7 +1176,6 @@ static int ocfs2_fill_super(struct super_block *sb, void *data, int silent)
1181 atomic_set(&osb->vol_state, VOLUME_DISABLED); 1176 atomic_set(&osb->vol_state, VOLUME_DISABLED);
1182 wake_up(&osb->osb_mount_event); 1177 wake_up(&osb->osb_mount_event);
1183 mlog_exit(status); 1178 mlog_exit(status);
1184 unlock_kernel();
1185 return status; 1179 return status;
1186 } 1180 }
1187 } 1181 }
@@ -1196,7 +1190,6 @@ static int ocfs2_fill_super(struct super_block *sb, void *data, int silent)
1196 ocfs2_orphan_scan_start(osb); 1190 ocfs2_orphan_scan_start(osb);
1197 1191
1198 mlog_exit(status); 1192 mlog_exit(status);
1199 unlock_kernel();
1200 return status; 1193 return status;
1201 1194
1202read_super_error: 1195read_super_error:
@@ -1212,7 +1205,6 @@ read_super_error:
1212 } 1205 }
1213 1206
1214 mlog_exit(status); 1207 mlog_exit(status);
1215 unlock_kernel();
1216 return status; 1208 return status;
1217} 1209}
1218 1210
@@ -1645,13 +1637,9 @@ static void ocfs2_put_super(struct super_block *sb)
1645{ 1637{
1646 mlog_entry("(0x%p)\n", sb); 1638 mlog_entry("(0x%p)\n", sb);
1647 1639
1648 lock_kernel();
1649
1650 ocfs2_sync_blockdev(sb); 1640 ocfs2_sync_blockdev(sb);
1651 ocfs2_dismount_volume(sb, 0); 1641 ocfs2_dismount_volume(sb, 0);
1652 1642
1653 unlock_kernel();
1654
1655 mlog_exit_void(); 1643 mlog_exit_void();
1656} 1644}
1657 1645