diff options
author | Tao Ma <boyu.mt@taobao.com> | 2011-03-07 03:43:21 -0500 |
---|---|---|
committer | Tao Ma <boyu.mt@taobao.com> | 2011-03-07 03:43:21 -0500 |
commit | c1e8d35ef5ffb393b94a192034b5e3541e005d75 (patch) | |
tree | b9a7f089acd3408c2835a3dfd6aa7bb0407587b3 /fs/ocfs2/quota_global.c | |
parent | ef6b689b63b9f5227ccee6f16dd9ee3faf58a464 (diff) |
ocfs2: Remove EXIT from masklog.
mlog_exit is used to record the exit status of a function.
But because it is added in so many functions, if we enable it,
the system logs get filled up quickly and cause too much I/O.
So actually no one can open it for a production system or even
for a test.
This patch just try to remove it or change it. So:
1. if all the error paths already use mlog_errno, it is just removed.
Otherwise, it will be replaced by mlog_errno.
2. if it is used to print some return value, it is replaced with
mlog(0,...).
mlog_exit_ptr is changed to mlog(0.
All those mlog(0,...) will be replaced with trace events later.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Diffstat (limited to 'fs/ocfs2/quota_global.c')
-rw-r--r-- | fs/ocfs2/quota_global.c | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index 33397bd7e1bc..10a49e8a5f03 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c | |||
@@ -402,7 +402,8 @@ int ocfs2_global_read_info(struct super_block *sb, int type) | |||
402 | msecs_to_jiffies(oinfo->dqi_syncms)); | 402 | msecs_to_jiffies(oinfo->dqi_syncms)); |
403 | 403 | ||
404 | out_err: | 404 | out_err: |
405 | mlog_exit(status); | 405 | if (status) |
406 | mlog_errno(status); | ||
406 | return status; | 407 | return status; |
407 | out_unlock: | 408 | out_unlock: |
408 | ocfs2_unlock_global_qf(oinfo, 0); | 409 | ocfs2_unlock_global_qf(oinfo, 0); |
@@ -621,7 +622,6 @@ static int ocfs2_sync_dquot_helper(struct dquot *dquot, unsigned long type) | |||
621 | out_ilock: | 622 | out_ilock: |
622 | ocfs2_unlock_global_qf(oinfo, 1); | 623 | ocfs2_unlock_global_qf(oinfo, 1); |
623 | out: | 624 | out: |
624 | mlog_exit(status); | ||
625 | return status; | 625 | return status; |
626 | } | 626 | } |
627 | 627 | ||
@@ -660,7 +660,6 @@ static int ocfs2_write_dquot(struct dquot *dquot) | |||
660 | mutex_unlock(&sb_dqopt(dquot->dq_sb)->dqio_mutex); | 660 | mutex_unlock(&sb_dqopt(dquot->dq_sb)->dqio_mutex); |
661 | ocfs2_commit_trans(osb, handle); | 661 | ocfs2_commit_trans(osb, handle); |
662 | out: | 662 | out: |
663 | mlog_exit(status); | ||
664 | return status; | 663 | return status; |
665 | } | 664 | } |
666 | 665 | ||
@@ -722,7 +721,8 @@ out_ilock: | |||
722 | ocfs2_unlock_global_qf(oinfo, 1); | 721 | ocfs2_unlock_global_qf(oinfo, 1); |
723 | out: | 722 | out: |
724 | mutex_unlock(&dquot->dq_lock); | 723 | mutex_unlock(&dquot->dq_lock); |
725 | mlog_exit(status); | 724 | if (status) |
725 | mlog_errno(status); | ||
726 | return status; | 726 | return status; |
727 | } | 727 | } |
728 | 728 | ||
@@ -809,7 +809,8 @@ out_dq: | |||
809 | set_bit(DQ_ACTIVE_B, &dquot->dq_flags); | 809 | set_bit(DQ_ACTIVE_B, &dquot->dq_flags); |
810 | out: | 810 | out: |
811 | mutex_unlock(&dquot->dq_lock); | 811 | mutex_unlock(&dquot->dq_lock); |
812 | mlog_exit(status); | 812 | if (status) |
813 | mlog_errno(status); | ||
813 | return status; | 814 | return status; |
814 | } | 815 | } |
815 | 816 | ||
@@ -866,7 +867,8 @@ out_dlock: | |||
866 | out_ilock: | 867 | out_ilock: |
867 | ocfs2_unlock_global_qf(oinfo, 1); | 868 | ocfs2_unlock_global_qf(oinfo, 1); |
868 | out: | 869 | out: |
869 | mlog_exit(status); | 870 | if (status) |
871 | mlog_errno(status); | ||
870 | return status; | 872 | return status; |
871 | } | 873 | } |
872 | 874 | ||
@@ -891,7 +893,8 @@ static int ocfs2_write_info(struct super_block *sb, int type) | |||
891 | out_ilock: | 893 | out_ilock: |
892 | ocfs2_unlock_global_qf(oinfo, 1); | 894 | ocfs2_unlock_global_qf(oinfo, 1); |
893 | out: | 895 | out: |
894 | mlog_exit(status); | 896 | if (status) |
897 | mlog_errno(status); | ||
895 | return status; | 898 | return status; |
896 | } | 899 | } |
897 | 900 | ||