diff options
author | Mark Fasheh <mfasheh@suse.com> | 2008-10-07 17:25:16 -0400 |
---|---|---|
committer | Mark Fasheh <mfasheh@suse.com> | 2008-10-13 20:02:44 -0400 |
commit | a81cb88b64a479b78c6dd5666678d50171865db8 (patch) | |
tree | 9fe0f67e30d7c70d43785827e57736ac01558c24 /fs/ocfs2/journal.c | |
parent | fd8351f83d413b41da956109cf429c15881886e2 (diff) |
ocfs2: Don't check for NULL before brelse()
This is pointless as brelse() already does the check.
Signed-off-by: Mark Fasheh
Diffstat (limited to 'fs/ocfs2/journal.c')
-rw-r--r-- | fs/ocfs2/journal.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index 373d94366a4c..562ba652593e 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2/journal.c | |||
@@ -554,8 +554,7 @@ done: | |||
554 | if (status < 0) { | 554 | if (status < 0) { |
555 | if (inode_lock) | 555 | if (inode_lock) |
556 | ocfs2_inode_unlock(inode, 1); | 556 | ocfs2_inode_unlock(inode, 1); |
557 | if (bh != NULL) | 557 | brelse(bh); |
558 | brelse(bh); | ||
559 | if (inode) { | 558 | if (inode) { |
560 | OCFS2_I(inode)->ip_open_count--; | 559 | OCFS2_I(inode)->ip_open_count--; |
561 | iput(inode); | 560 | iput(inode); |
@@ -869,8 +868,7 @@ static int ocfs2_force_read_journal(struct inode *inode) | |||
869 | 868 | ||
870 | bail: | 869 | bail: |
871 | for(i = 0; i < CONCURRENT_JOURNAL_FILL; i++) | 870 | for(i = 0; i < CONCURRENT_JOURNAL_FILL; i++) |
872 | if (bhs[i]) | 871 | brelse(bhs[i]); |
873 | brelse(bhs[i]); | ||
874 | mlog_exit(status); | 872 | mlog_exit(status); |
875 | return status; | 873 | return status; |
876 | } | 874 | } |
@@ -1286,8 +1284,7 @@ done: | |||
1286 | if (inode) | 1284 | if (inode) |
1287 | iput(inode); | 1285 | iput(inode); |
1288 | 1286 | ||
1289 | if (bh) | 1287 | brelse(bh); |
1290 | brelse(bh); | ||
1291 | 1288 | ||
1292 | mlog_exit(status); | 1289 | mlog_exit(status); |
1293 | return status; | 1290 | return status; |