diff options
author | Tao Ma <boyu.mt@taobao.com> | 2011-02-20 22:10:44 -0500 |
---|---|---|
committer | Tao Ma <boyu.mt@taobao.com> | 2011-02-20 22:10:44 -0500 |
commit | ef6b689b63b9f5227ccee6f16dd9ee3faf58a464 (patch) | |
tree | ebe3416fcc221e152f2625e8e8794e92e3d8c979 /fs/ocfs2/inode.c | |
parent | 422e6c4bc4b48c15b3cb57a1ca71431abfc57e54 (diff) |
ocfs2: Remove ENTRY from masklog.
ENTRY is used to record the entry of a function.
But because it is added in so many functions, if we enable it,
the system logs get filled up quickly and cause too much I/O.
So actually no one can open it for a production system or even
for a test.
So for mlog_entry_void, we just remove it.
for mlog_entry(...), we replace it with mlog(0,...), and they
will be replace by trace event later.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Diffstat (limited to 'fs/ocfs2/inode.c')
-rw-r--r-- | fs/ocfs2/inode.c | 28 |
1 files changed, 11 insertions, 17 deletions
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 4068c6c4c6f6..16ee8e96f731 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c | |||
@@ -131,7 +131,7 @@ struct inode *ocfs2_iget(struct ocfs2_super *osb, u64 blkno, unsigned flags, | |||
131 | struct super_block *sb = osb->sb; | 131 | struct super_block *sb = osb->sb; |
132 | struct ocfs2_find_inode_args args; | 132 | struct ocfs2_find_inode_args args; |
133 | 133 | ||
134 | mlog_entry("(blkno = %llu)\n", (unsigned long long)blkno); | 134 | mlog(0, "(blkno = %llu)\n", (unsigned long long)blkno); |
135 | 135 | ||
136 | /* Ok. By now we've either got the offsets passed to us by the | 136 | /* Ok. By now we've either got the offsets passed to us by the |
137 | * caller, or we just pulled them off the bh. Lets do some | 137 | * caller, or we just pulled them off the bh. Lets do some |
@@ -192,7 +192,7 @@ static int ocfs2_find_actor(struct inode *inode, void *opaque) | |||
192 | struct ocfs2_inode_info *oi = OCFS2_I(inode); | 192 | struct ocfs2_inode_info *oi = OCFS2_I(inode); |
193 | int ret = 0; | 193 | int ret = 0; |
194 | 194 | ||
195 | mlog_entry("(0x%p, %lu, 0x%p)\n", inode, inode->i_ino, opaque); | 195 | mlog(0, "(0x%p, %lu, 0x%p)\n", inode, inode->i_ino, opaque); |
196 | 196 | ||
197 | args = opaque; | 197 | args = opaque; |
198 | 198 | ||
@@ -218,7 +218,7 @@ static int ocfs2_init_locked_inode(struct inode *inode, void *opaque) | |||
218 | static struct lock_class_key ocfs2_quota_ip_alloc_sem_key, | 218 | static struct lock_class_key ocfs2_quota_ip_alloc_sem_key, |
219 | ocfs2_file_ip_alloc_sem_key; | 219 | ocfs2_file_ip_alloc_sem_key; |
220 | 220 | ||
221 | mlog_entry("inode = %p, opaque = %p\n", inode, opaque); | 221 | mlog(0, "inode = %p, opaque = %p\n", inode, opaque); |
222 | 222 | ||
223 | inode->i_ino = args->fi_ino; | 223 | inode->i_ino = args->fi_ino; |
224 | OCFS2_I(inode)->ip_blkno = args->fi_blkno; | 224 | OCFS2_I(inode)->ip_blkno = args->fi_blkno; |
@@ -246,8 +246,8 @@ void ocfs2_populate_inode(struct inode *inode, struct ocfs2_dinode *fe, | |||
246 | struct ocfs2_super *osb; | 246 | struct ocfs2_super *osb; |
247 | int use_plocks = 1; | 247 | int use_plocks = 1; |
248 | 248 | ||
249 | mlog_entry("(0x%p, size:%llu)\n", inode, | 249 | mlog(0, "(0x%p, size:%llu)\n", inode, |
250 | (unsigned long long)le64_to_cpu(fe->i_size)); | 250 | (unsigned long long)le64_to_cpu(fe->i_size)); |
251 | 251 | ||
252 | sb = inode->i_sb; | 252 | sb = inode->i_sb; |
253 | osb = OCFS2_SB(sb); | 253 | osb = OCFS2_SB(sb); |
@@ -394,7 +394,7 @@ static int ocfs2_read_locked_inode(struct inode *inode, | |||
394 | int status, can_lock; | 394 | int status, can_lock; |
395 | u32 generation = 0; | 395 | u32 generation = 0; |
396 | 396 | ||
397 | mlog_entry("(0x%p, 0x%p)\n", inode, args); | 397 | mlog(0, "(0x%p, 0x%p)\n", inode, args); |
398 | 398 | ||
399 | status = -EINVAL; | 399 | status = -EINVAL; |
400 | if (inode == NULL || inode->i_sb == NULL) { | 400 | if (inode == NULL || inode->i_sb == NULL) { |
@@ -551,8 +551,6 @@ static int ocfs2_truncate_for_delete(struct ocfs2_super *osb, | |||
551 | struct ocfs2_dinode *fe; | 551 | struct ocfs2_dinode *fe; |
552 | handle_t *handle = NULL; | 552 | handle_t *handle = NULL; |
553 | 553 | ||
554 | mlog_entry_void(); | ||
555 | |||
556 | fe = (struct ocfs2_dinode *) fe_bh->b_data; | 554 | fe = (struct ocfs2_dinode *) fe_bh->b_data; |
557 | 555 | ||
558 | /* | 556 | /* |
@@ -980,7 +978,7 @@ static void ocfs2_delete_inode(struct inode *inode) | |||
980 | sigset_t oldset; | 978 | sigset_t oldset; |
981 | struct buffer_head *di_bh = NULL; | 979 | struct buffer_head *di_bh = NULL; |
982 | 980 | ||
983 | mlog_entry("(inode->i_ino = %lu)\n", inode->i_ino); | 981 | mlog(0, "(inode->i_ino = %lu)\n", inode->i_ino); |
984 | 982 | ||
985 | /* When we fail in read_inode() we mark inode as bad. The second test | 983 | /* When we fail in read_inode() we mark inode as bad. The second test |
986 | * catches the case when inode allocation fails before allocating | 984 | * catches the case when inode allocation fails before allocating |
@@ -1088,8 +1086,6 @@ static void ocfs2_clear_inode(struct inode *inode) | |||
1088 | int status; | 1086 | int status; |
1089 | struct ocfs2_inode_info *oi = OCFS2_I(inode); | 1087 | struct ocfs2_inode_info *oi = OCFS2_I(inode); |
1090 | 1088 | ||
1091 | mlog_entry_void(); | ||
1092 | |||
1093 | end_writeback(inode); | 1089 | end_writeback(inode); |
1094 | mlog(0, "Clearing inode: %llu, nlink = %u\n", | 1090 | mlog(0, "Clearing inode: %llu, nlink = %u\n", |
1095 | (unsigned long long)OCFS2_I(inode)->ip_blkno, inode->i_nlink); | 1091 | (unsigned long long)OCFS2_I(inode)->ip_blkno, inode->i_nlink); |
@@ -1204,8 +1200,6 @@ int ocfs2_drop_inode(struct inode *inode) | |||
1204 | struct ocfs2_inode_info *oi = OCFS2_I(inode); | 1200 | struct ocfs2_inode_info *oi = OCFS2_I(inode); |
1205 | int res; | 1201 | int res; |
1206 | 1202 | ||
1207 | mlog_entry_void(); | ||
1208 | |||
1209 | mlog(0, "Drop inode %llu, nlink = %u, ip_flags = 0x%x\n", | 1203 | mlog(0, "Drop inode %llu, nlink = %u, ip_flags = 0x%x\n", |
1210 | (unsigned long long)oi->ip_blkno, inode->i_nlink, oi->ip_flags); | 1204 | (unsigned long long)oi->ip_blkno, inode->i_nlink, oi->ip_flags); |
1211 | 1205 | ||
@@ -1226,8 +1220,8 @@ int ocfs2_inode_revalidate(struct dentry *dentry) | |||
1226 | struct inode *inode = dentry->d_inode; | 1220 | struct inode *inode = dentry->d_inode; |
1227 | int status = 0; | 1221 | int status = 0; |
1228 | 1222 | ||
1229 | mlog_entry("(inode = 0x%p, ino = %llu)\n", inode, | 1223 | mlog(0, "(inode = 0x%p, ino = %llu)\n", inode, |
1230 | inode ? (unsigned long long)OCFS2_I(inode)->ip_blkno : 0ULL); | 1224 | inode ? (unsigned long long)OCFS2_I(inode)->ip_blkno : 0ULL); |
1231 | 1225 | ||
1232 | if (!inode) { | 1226 | if (!inode) { |
1233 | mlog(0, "eep, no inode!\n"); | 1227 | mlog(0, "eep, no inode!\n"); |
@@ -1271,8 +1265,8 @@ int ocfs2_mark_inode_dirty(handle_t *handle, | |||
1271 | int status; | 1265 | int status; |
1272 | struct ocfs2_dinode *fe = (struct ocfs2_dinode *) bh->b_data; | 1266 | struct ocfs2_dinode *fe = (struct ocfs2_dinode *) bh->b_data; |
1273 | 1267 | ||
1274 | mlog_entry("(inode %llu)\n", | 1268 | mlog(0, "(inode %llu)\n", |
1275 | (unsigned long long)OCFS2_I(inode)->ip_blkno); | 1269 | (unsigned long long)OCFS2_I(inode)->ip_blkno); |
1276 | 1270 | ||
1277 | status = ocfs2_journal_access_di(handle, INODE_CACHE(inode), bh, | 1271 | status = ocfs2_journal_access_di(handle, INODE_CACHE(inode), bh, |
1278 | OCFS2_JOURNAL_ACCESS_WRITE); | 1272 | OCFS2_JOURNAL_ACCESS_WRITE); |