diff options
author | Mark Fasheh <mark.fasheh@oracle.com> | 2007-04-27 19:01:25 -0400 |
---|---|---|
committer | Mark Fasheh <mark.fasheh@oracle.com> | 2007-05-02 18:08:08 -0400 |
commit | 1ca1a111b1e6be843c9ce5245dcd570312998d94 (patch) | |
tree | e9f14300df896a4c7ee4f03db09cf08ddd027471 /fs/ocfs2/inode.c | |
parent | 6e4b0d5692cd27d3c9be893a9f5939a9cafbb09f (diff) |
ocfs2: fix sparse warnings in fs/ocfs2
None of these are actually harmful, but the noise makes looking for real
problems difficult.
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
Diffstat (limited to 'fs/ocfs2/inode.c')
-rw-r--r-- | fs/ocfs2/inode.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index b6cfc5cdb3b6..bc844bfe607c 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c | |||
@@ -215,7 +215,7 @@ int ocfs2_populate_inode(struct inode *inode, struct ocfs2_dinode *fe, | |||
215 | int status = -EINVAL; | 215 | int status = -EINVAL; |
216 | 216 | ||
217 | mlog_entry("(0x%p, size:%llu)\n", inode, | 217 | mlog_entry("(0x%p, size:%llu)\n", inode, |
218 | (unsigned long long)fe->i_size); | 218 | (unsigned long long)le64_to_cpu(fe->i_size)); |
219 | 219 | ||
220 | sb = inode->i_sb; | 220 | sb = inode->i_sb; |
221 | osb = OCFS2_SB(sb); | 221 | osb = OCFS2_SB(sb); |
@@ -267,7 +267,7 @@ int ocfs2_populate_inode(struct inode *inode, struct ocfs2_dinode *fe, | |||
267 | mlog(ML_ERROR, | 267 | mlog(ML_ERROR, |
268 | "ip_blkno %llu != i_blkno %llu!\n", | 268 | "ip_blkno %llu != i_blkno %llu!\n", |
269 | (unsigned long long)OCFS2_I(inode)->ip_blkno, | 269 | (unsigned long long)OCFS2_I(inode)->ip_blkno, |
270 | (unsigned long long)fe->i_blkno); | 270 | (unsigned long long)le64_to_cpu(fe->i_blkno)); |
271 | 271 | ||
272 | inode->i_nlink = le16_to_cpu(fe->i_links_count); | 272 | inode->i_nlink = le16_to_cpu(fe->i_links_count); |
273 | 273 | ||
@@ -320,7 +320,7 @@ int ocfs2_populate_inode(struct inode *inode, struct ocfs2_dinode *fe, | |||
320 | * the generation argument to | 320 | * the generation argument to |
321 | * ocfs2_inode_lock_res_init() will have to change. | 321 | * ocfs2_inode_lock_res_init() will have to change. |
322 | */ | 322 | */ |
323 | BUG_ON(fe->i_flags & cpu_to_le32(OCFS2_SYSTEM_FL)); | 323 | BUG_ON(le32_to_cpu(fe->i_flags) & OCFS2_SYSTEM_FL); |
324 | 324 | ||
325 | ocfs2_inode_lock_res_init(&OCFS2_I(inode)->ip_meta_lockres, | 325 | ocfs2_inode_lock_res_init(&OCFS2_I(inode)->ip_meta_lockres, |
326 | OCFS2_LOCK_TYPE_META, 0, inode); | 326 | OCFS2_LOCK_TYPE_META, 0, inode); |
@@ -456,7 +456,8 @@ static int ocfs2_read_locked_inode(struct inode *inode, | |||
456 | fe = (struct ocfs2_dinode *) bh->b_data; | 456 | fe = (struct ocfs2_dinode *) bh->b_data; |
457 | if (!OCFS2_IS_VALID_DINODE(fe)) { | 457 | if (!OCFS2_IS_VALID_DINODE(fe)) { |
458 | mlog(ML_ERROR, "Invalid dinode #%llu: signature = %.*s\n", | 458 | mlog(ML_ERROR, "Invalid dinode #%llu: signature = %.*s\n", |
459 | (unsigned long long)fe->i_blkno, 7, fe->i_signature); | 459 | (unsigned long long)le64_to_cpu(fe->i_blkno), 7, |
460 | fe->i_signature); | ||
460 | goto bail; | 461 | goto bail; |
461 | } | 462 | } |
462 | 463 | ||
@@ -831,8 +832,8 @@ static int ocfs2_query_inode_wipe(struct inode *inode, | |||
831 | "Inode %llu (on-disk %llu) not orphaned! " | 832 | "Inode %llu (on-disk %llu) not orphaned! " |
832 | "Disk flags 0x%x, inode flags 0x%x\n", | 833 | "Disk flags 0x%x, inode flags 0x%x\n", |
833 | (unsigned long long)oi->ip_blkno, | 834 | (unsigned long long)oi->ip_blkno, |
834 | (unsigned long long)di->i_blkno, di->i_flags, | 835 | (unsigned long long)le64_to_cpu(di->i_blkno), |
835 | oi->ip_flags); | 836 | le32_to_cpu(di->i_flags), oi->ip_flags); |
836 | goto bail; | 837 | goto bail; |
837 | } | 838 | } |
838 | 839 | ||