diff options
author | Joel Becker <joel.becker@oracle.com> | 2008-10-09 20:20:31 -0400 |
---|---|---|
committer | Mark Fasheh <mfasheh@suse.com> | 2008-10-14 14:51:57 -0400 |
commit | 0fcaa56a2a020dd6f90c202b7084e6f4cbedb6c2 (patch) | |
tree | 057204016523ce0274d4a23ec02944075f084e8c /fs/ocfs2/inode.c | |
parent | 31d33073ca38603dea705dae45e094a64ca062d6 (diff) |
ocfs2: Simplify ocfs2_read_block()
More than 30 callers of ocfs2_read_block() pass exactly OCFS2_BH_CACHED.
Only six pass a different flag set. Rather than have every caller care,
let's make ocfs2_read_block() take no flags and always do a cached read.
The remaining six places can call ocfs2_read_blocks() directly.
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
Diffstat (limited to 'fs/ocfs2/inode.c')
-rw-r--r-- | fs/ocfs2/inode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 6ec31b92a47f..c5ee9e3cf80b 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c | |||
@@ -461,7 +461,7 @@ static int ocfs2_read_locked_inode(struct inode *inode, | |||
461 | } | 461 | } |
462 | 462 | ||
463 | if (can_lock) | 463 | if (can_lock) |
464 | status = ocfs2_read_block(inode, args->fi_blkno, &bh, 0); | 464 | status = ocfs2_read_blocks(inode, args->fi_blkno, 1, &bh, 0); |
465 | else | 465 | else |
466 | status = ocfs2_read_blocks_sync(osb, args->fi_blkno, 1, &bh); | 466 | status = ocfs2_read_blocks_sync(osb, args->fi_blkno, 1, &bh); |
467 | if (status < 0) { | 467 | if (status < 0) { |
@@ -1165,7 +1165,7 @@ struct buffer_head *ocfs2_bread(struct inode *inode, | |||
1165 | goto fail; | 1165 | goto fail; |
1166 | } | 1166 | } |
1167 | 1167 | ||
1168 | tmperr = ocfs2_read_block(inode, p_blkno, &bh, readflags); | 1168 | tmperr = ocfs2_read_blocks(inode, p_blkno, 1, &bh, readflags); |
1169 | if (tmperr < 0) | 1169 | if (tmperr < 0) |
1170 | goto fail; | 1170 | goto fail; |
1171 | 1171 | ||