aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ocfs2/dlmglue.c
diff options
context:
space:
mode:
authorJoel Becker <jlbec@evilplan.org>2011-03-28 12:44:26 -0400
committerJoel Becker <jlbec@evilplan.org>2011-03-28 12:44:26 -0400
commit99bdc3880c611c7f2061fbd5372ef81b40217e26 (patch)
treeef68a53e28e9ee53ce9db3642bab5fa5b3d44866 /fs/ocfs2/dlmglue.c
parented59992e8d91b70053c53d846a76f7e1ac000454 (diff)
parentb4e1b7e88b2c87c358c2a88bec0c76d25accc604 (diff)
Merge branch 'mlog_replace_for_39' of git://repo.or.cz/taoma-kernel into ocfs2-merge-window-fix
Diffstat (limited to 'fs/ocfs2/dlmglue.c')
-rw-r--r--fs/ocfs2/dlmglue.c149
1 files changed, 6 insertions, 143 deletions
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 7484bb9a3438..7642d7ca73e5 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -397,8 +397,6 @@ static void ocfs2_build_lock_name(enum ocfs2_lock_type type,
397{ 397{
398 int len; 398 int len;
399 399
400 mlog_entry_void();
401
402 BUG_ON(type >= OCFS2_NUM_LOCK_TYPES); 400 BUG_ON(type >= OCFS2_NUM_LOCK_TYPES);
403 401
404 len = snprintf(name, OCFS2_LOCK_ID_MAX_LEN, "%c%s%016llx%08x", 402 len = snprintf(name, OCFS2_LOCK_ID_MAX_LEN, "%c%s%016llx%08x",
@@ -408,8 +406,6 @@ static void ocfs2_build_lock_name(enum ocfs2_lock_type type,
408 BUG_ON(len != (OCFS2_LOCK_ID_MAX_LEN - 1)); 406 BUG_ON(len != (OCFS2_LOCK_ID_MAX_LEN - 1));
409 407
410 mlog(0, "built lock resource with name: %s\n", name); 408 mlog(0, "built lock resource with name: %s\n", name);
411
412 mlog_exit_void();
413} 409}
414 410
415static DEFINE_SPINLOCK(ocfs2_dlm_tracking_lock); 411static DEFINE_SPINLOCK(ocfs2_dlm_tracking_lock);
@@ -725,8 +721,6 @@ void ocfs2_refcount_lock_res_init(struct ocfs2_lock_res *lockres,
725 721
726void ocfs2_lock_res_free(struct ocfs2_lock_res *res) 722void ocfs2_lock_res_free(struct ocfs2_lock_res *res)
727{ 723{
728 mlog_entry_void();
729
730 if (!(res->l_flags & OCFS2_LOCK_INITIALIZED)) 724 if (!(res->l_flags & OCFS2_LOCK_INITIALIZED))
731 return; 725 return;
732 726
@@ -752,14 +746,11 @@ void ocfs2_lock_res_free(struct ocfs2_lock_res *res)
752 memset(&res->l_lksb, 0, sizeof(res->l_lksb)); 746 memset(&res->l_lksb, 0, sizeof(res->l_lksb));
753 747
754 res->l_flags = 0UL; 748 res->l_flags = 0UL;
755 mlog_exit_void();
756} 749}
757 750
758static inline void ocfs2_inc_holders(struct ocfs2_lock_res *lockres, 751static inline void ocfs2_inc_holders(struct ocfs2_lock_res *lockres,
759 int level) 752 int level)
760{ 753{
761 mlog_entry_void();
762
763 BUG_ON(!lockres); 754 BUG_ON(!lockres);
764 755
765 switch(level) { 756 switch(level) {
@@ -772,15 +763,11 @@ static inline void ocfs2_inc_holders(struct ocfs2_lock_res *lockres,
772 default: 763 default:
773 BUG(); 764 BUG();
774 } 765 }
775
776 mlog_exit_void();
777} 766}
778 767
779static inline void ocfs2_dec_holders(struct ocfs2_lock_res *lockres, 768static inline void ocfs2_dec_holders(struct ocfs2_lock_res *lockres,
780 int level) 769 int level)
781{ 770{
782 mlog_entry_void();
783
784 BUG_ON(!lockres); 771 BUG_ON(!lockres);
785 772
786 switch(level) { 773 switch(level) {
@@ -795,7 +782,6 @@ static inline void ocfs2_dec_holders(struct ocfs2_lock_res *lockres,
795 default: 782 default:
796 BUG(); 783 BUG();
797 } 784 }
798 mlog_exit_void();
799} 785}
800 786
801/* WARNING: This function lives in a world where the only three lock 787/* WARNING: This function lives in a world where the only three lock
@@ -842,8 +828,6 @@ static void lockres_clear_flags(struct ocfs2_lock_res *lockres,
842 828
843static inline void ocfs2_generic_handle_downconvert_action(struct ocfs2_lock_res *lockres) 829static inline void ocfs2_generic_handle_downconvert_action(struct ocfs2_lock_res *lockres)
844{ 830{
845 mlog_entry_void();
846
847 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_BUSY)); 831 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_BUSY));
848 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_ATTACHED)); 832 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_ATTACHED));
849 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_BLOCKED)); 833 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_BLOCKED));
@@ -856,14 +840,10 @@ static inline void ocfs2_generic_handle_downconvert_action(struct ocfs2_lock_res
856 lockres_clear_flags(lockres, OCFS2_LOCK_BLOCKED); 840 lockres_clear_flags(lockres, OCFS2_LOCK_BLOCKED);
857 } 841 }
858 lockres_clear_flags(lockres, OCFS2_LOCK_BUSY); 842 lockres_clear_flags(lockres, OCFS2_LOCK_BUSY);
859
860 mlog_exit_void();
861} 843}
862 844
863static inline void ocfs2_generic_handle_convert_action(struct ocfs2_lock_res *lockres) 845static inline void ocfs2_generic_handle_convert_action(struct ocfs2_lock_res *lockres)
864{ 846{
865 mlog_entry_void();
866
867 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_BUSY)); 847 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_BUSY));
868 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_ATTACHED)); 848 BUG_ON(!(lockres->l_flags & OCFS2_LOCK_ATTACHED));
869 849
@@ -885,14 +865,10 @@ static inline void ocfs2_generic_handle_convert_action(struct ocfs2_lock_res *lo
885 lockres_or_flags(lockres, OCFS2_LOCK_UPCONVERT_FINISHING); 865 lockres_or_flags(lockres, OCFS2_LOCK_UPCONVERT_FINISHING);
886 866
887 lockres_clear_flags(lockres, OCFS2_LOCK_BUSY); 867 lockres_clear_flags(lockres, OCFS2_LOCK_BUSY);
888
889 mlog_exit_void();
890} 868}
891 869
892static inline void ocfs2_generic_handle_attach_action(struct ocfs2_lock_res *lockres) 870static inline void ocfs2_generic_handle_attach_action(struct ocfs2_lock_res *lockres)
893{ 871{
894 mlog_entry_void();
895
896 BUG_ON((!(lockres->l_flags & OCFS2_LOCK_BUSY))); 872 BUG_ON((!(lockres->l_flags & OCFS2_LOCK_BUSY)));
897 BUG_ON(lockres->l_flags & OCFS2_LOCK_ATTACHED); 873 BUG_ON(lockres->l_flags & OCFS2_LOCK_ATTACHED);
898 874
@@ -904,15 +880,12 @@ static inline void ocfs2_generic_handle_attach_action(struct ocfs2_lock_res *loc
904 lockres->l_level = lockres->l_requested; 880 lockres->l_level = lockres->l_requested;
905 lockres_or_flags(lockres, OCFS2_LOCK_ATTACHED); 881 lockres_or_flags(lockres, OCFS2_LOCK_ATTACHED);
906 lockres_clear_flags(lockres, OCFS2_LOCK_BUSY); 882 lockres_clear_flags(lockres, OCFS2_LOCK_BUSY);
907
908 mlog_exit_void();
909} 883}
910 884
911static int ocfs2_generic_handle_bast(struct ocfs2_lock_res *lockres, 885static int ocfs2_generic_handle_bast(struct ocfs2_lock_res *lockres,
912 int level) 886 int level)
913{ 887{
914 int needs_downconvert = 0; 888 int needs_downconvert = 0;
915 mlog_entry_void();
916 889
917 assert_spin_locked(&lockres->l_lock); 890 assert_spin_locked(&lockres->l_lock);
918 891
@@ -934,8 +907,7 @@ static int ocfs2_generic_handle_bast(struct ocfs2_lock_res *lockres,
934 907
935 if (needs_downconvert) 908 if (needs_downconvert)
936 lockres_or_flags(lockres, OCFS2_LOCK_BLOCKED); 909 lockres_or_flags(lockres, OCFS2_LOCK_BLOCKED);
937 910 mlog(0, "needs_downconvert = %d\n", needs_downconvert);
938 mlog_exit(needs_downconvert);
939 return needs_downconvert; 911 return needs_downconvert;
940} 912}
941 913
@@ -1147,8 +1119,6 @@ static void ocfs2_unlock_ast(struct ocfs2_dlm_lksb *lksb, int error)
1147 struct ocfs2_lock_res *lockres = ocfs2_lksb_to_lock_res(lksb); 1119 struct ocfs2_lock_res *lockres = ocfs2_lksb_to_lock_res(lksb);
1148 unsigned long flags; 1120 unsigned long flags;
1149 1121
1150 mlog_entry_void();
1151
1152 mlog(ML_BASTS, "UNLOCK AST fired for lockres %s, action = %d\n", 1122 mlog(ML_BASTS, "UNLOCK AST fired for lockres %s, action = %d\n",
1153 lockres->l_name, lockres->l_unlock_action); 1123 lockres->l_name, lockres->l_unlock_action);
1154 1124
@@ -1158,7 +1128,6 @@ static void ocfs2_unlock_ast(struct ocfs2_dlm_lksb *lksb, int error)
1158 "unlock_action %d\n", error, lockres->l_name, 1128 "unlock_action %d\n", error, lockres->l_name,
1159 lockres->l_unlock_action); 1129 lockres->l_unlock_action);
1160 spin_unlock_irqrestore(&lockres->l_lock, flags); 1130 spin_unlock_irqrestore(&lockres->l_lock, flags);
1161 mlog_exit_void();
1162 return; 1131 return;
1163 } 1132 }
1164 1133
@@ -1182,8 +1151,6 @@ static void ocfs2_unlock_ast(struct ocfs2_dlm_lksb *lksb, int error)
1182 lockres->l_unlock_action = OCFS2_UNLOCK_INVALID; 1151 lockres->l_unlock_action = OCFS2_UNLOCK_INVALID;
1183 wake_up(&lockres->l_event); 1152 wake_up(&lockres->l_event);
1184 spin_unlock_irqrestore(&lockres->l_lock, flags); 1153 spin_unlock_irqrestore(&lockres->l_lock, flags);
1185
1186 mlog_exit_void();
1187} 1154}
1188 1155
1189/* 1156/*
@@ -1229,7 +1196,6 @@ static inline void ocfs2_recover_from_dlm_error(struct ocfs2_lock_res *lockres,
1229{ 1196{
1230 unsigned long flags; 1197 unsigned long flags;
1231 1198
1232 mlog_entry_void();
1233 spin_lock_irqsave(&lockres->l_lock, flags); 1199 spin_lock_irqsave(&lockres->l_lock, flags);
1234 lockres_clear_flags(lockres, OCFS2_LOCK_BUSY); 1200 lockres_clear_flags(lockres, OCFS2_LOCK_BUSY);
1235 lockres_clear_flags(lockres, OCFS2_LOCK_UPCONVERT_FINISHING); 1201 lockres_clear_flags(lockres, OCFS2_LOCK_UPCONVERT_FINISHING);
@@ -1240,7 +1206,6 @@ static inline void ocfs2_recover_from_dlm_error(struct ocfs2_lock_res *lockres,
1240 spin_unlock_irqrestore(&lockres->l_lock, flags); 1206 spin_unlock_irqrestore(&lockres->l_lock, flags);
1241 1207
1242 wake_up(&lockres->l_event); 1208 wake_up(&lockres->l_event);
1243 mlog_exit_void();
1244} 1209}
1245 1210
1246/* Note: If we detect another process working on the lock (i.e., 1211/* Note: If we detect another process working on the lock (i.e.,
@@ -1256,8 +1221,6 @@ static int ocfs2_lock_create(struct ocfs2_super *osb,
1256 unsigned long flags; 1221 unsigned long flags;
1257 unsigned int gen; 1222 unsigned int gen;
1258 1223
1259 mlog_entry_void();
1260
1261 mlog(0, "lock %s, level = %d, flags = %u\n", lockres->l_name, level, 1224 mlog(0, "lock %s, level = %d, flags = %u\n", lockres->l_name, level,
1262 dlm_flags); 1225 dlm_flags);
1263 1226
@@ -1289,7 +1252,6 @@ static int ocfs2_lock_create(struct ocfs2_super *osb,
1289 mlog(0, "lock %s, return from ocfs2_dlm_lock\n", lockres->l_name); 1252 mlog(0, "lock %s, return from ocfs2_dlm_lock\n", lockres->l_name);
1290 1253
1291bail: 1254bail:
1292 mlog_exit(ret);
1293 return ret; 1255 return ret;
1294} 1256}
1295 1257
@@ -1412,8 +1374,6 @@ static int __ocfs2_cluster_lock(struct ocfs2_super *osb,
1412 unsigned int gen; 1374 unsigned int gen;
1413 int noqueue_attempted = 0; 1375 int noqueue_attempted = 0;
1414 1376
1415 mlog_entry_void();
1416
1417 ocfs2_init_mask_waiter(&mw); 1377 ocfs2_init_mask_waiter(&mw);
1418 1378
1419 if (lockres->l_ops->flags & LOCK_TYPE_USES_LVB) 1379 if (lockres->l_ops->flags & LOCK_TYPE_USES_LVB)
@@ -1579,7 +1539,6 @@ out:
1579 caller_ip); 1539 caller_ip);
1580 } 1540 }
1581#endif 1541#endif
1582 mlog_exit(ret);
1583 return ret; 1542 return ret;
1584} 1543}
1585 1544
@@ -1601,7 +1560,6 @@ static void __ocfs2_cluster_unlock(struct ocfs2_super *osb,
1601{ 1560{
1602 unsigned long flags; 1561 unsigned long flags;
1603 1562
1604 mlog_entry_void();
1605 spin_lock_irqsave(&lockres->l_lock, flags); 1563 spin_lock_irqsave(&lockres->l_lock, flags);
1606 ocfs2_dec_holders(lockres, level); 1564 ocfs2_dec_holders(lockres, level);
1607 ocfs2_downconvert_on_unlock(osb, lockres); 1565 ocfs2_downconvert_on_unlock(osb, lockres);
@@ -1610,7 +1568,6 @@ static void __ocfs2_cluster_unlock(struct ocfs2_super *osb,
1610 if (lockres->l_lockdep_map.key != NULL) 1568 if (lockres->l_lockdep_map.key != NULL)
1611 rwsem_release(&lockres->l_lockdep_map, 1, caller_ip); 1569 rwsem_release(&lockres->l_lockdep_map, 1, caller_ip);
1612#endif 1570#endif
1613 mlog_exit_void();
1614} 1571}
1615 1572
1616static int ocfs2_create_new_lock(struct ocfs2_super *osb, 1573static int ocfs2_create_new_lock(struct ocfs2_super *osb,
@@ -1644,8 +1601,6 @@ int ocfs2_create_new_inode_locks(struct inode *inode)
1644 BUG_ON(!inode); 1601 BUG_ON(!inode);
1645 BUG_ON(!ocfs2_inode_is_new(inode)); 1602 BUG_ON(!ocfs2_inode_is_new(inode));
1646 1603
1647 mlog_entry_void();
1648
1649 mlog(0, "Inode %llu\n", (unsigned long long)OCFS2_I(inode)->ip_blkno); 1604 mlog(0, "Inode %llu\n", (unsigned long long)OCFS2_I(inode)->ip_blkno);
1650 1605
1651 /* NOTE: That we don't increment any of the holder counts, nor 1606 /* NOTE: That we don't increment any of the holder counts, nor
@@ -1679,7 +1634,6 @@ int ocfs2_create_new_inode_locks(struct inode *inode)
1679 } 1634 }
1680 1635
1681bail: 1636bail:
1682 mlog_exit(ret);
1683 return ret; 1637 return ret;
1684} 1638}
1685 1639
@@ -1691,16 +1645,12 @@ int ocfs2_rw_lock(struct inode *inode, int write)
1691 1645
1692 BUG_ON(!inode); 1646 BUG_ON(!inode);
1693 1647
1694 mlog_entry_void();
1695
1696 mlog(0, "inode %llu take %s RW lock\n", 1648 mlog(0, "inode %llu take %s RW lock\n",
1697 (unsigned long long)OCFS2_I(inode)->ip_blkno, 1649 (unsigned long long)OCFS2_I(inode)->ip_blkno,
1698 write ? "EXMODE" : "PRMODE"); 1650 write ? "EXMODE" : "PRMODE");
1699 1651
1700 if (ocfs2_mount_local(osb)) { 1652 if (ocfs2_mount_local(osb))
1701 mlog_exit(0);
1702 return 0; 1653 return 0;
1703 }
1704 1654
1705 lockres = &OCFS2_I(inode)->ip_rw_lockres; 1655 lockres = &OCFS2_I(inode)->ip_rw_lockres;
1706 1656
@@ -1711,7 +1661,6 @@ int ocfs2_rw_lock(struct inode *inode, int write)
1711 if (status < 0) 1661 if (status < 0)
1712 mlog_errno(status); 1662 mlog_errno(status);
1713 1663
1714 mlog_exit(status);
1715 return status; 1664 return status;
1716} 1665}
1717 1666
@@ -1721,16 +1670,12 @@ void ocfs2_rw_unlock(struct inode *inode, int write)
1721 struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_rw_lockres; 1670 struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_rw_lockres;
1722 struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); 1671 struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
1723 1672
1724 mlog_entry_void();
1725
1726 mlog(0, "inode %llu drop %s RW lock\n", 1673 mlog(0, "inode %llu drop %s RW lock\n",
1727 (unsigned long long)OCFS2_I(inode)->ip_blkno, 1674 (unsigned long long)OCFS2_I(inode)->ip_blkno,
1728 write ? "EXMODE" : "PRMODE"); 1675 write ? "EXMODE" : "PRMODE");
1729 1676
1730 if (!ocfs2_mount_local(osb)) 1677 if (!ocfs2_mount_local(osb))
1731 ocfs2_cluster_unlock(OCFS2_SB(inode->i_sb), lockres, level); 1678 ocfs2_cluster_unlock(OCFS2_SB(inode->i_sb), lockres, level);
1732
1733 mlog_exit_void();
1734} 1679}
1735 1680
1736/* 1681/*
@@ -1744,8 +1689,6 @@ int ocfs2_open_lock(struct inode *inode)
1744 1689
1745 BUG_ON(!inode); 1690 BUG_ON(!inode);
1746 1691
1747 mlog_entry_void();
1748
1749 mlog(0, "inode %llu take PRMODE open lock\n", 1692 mlog(0, "inode %llu take PRMODE open lock\n",
1750 (unsigned long long)OCFS2_I(inode)->ip_blkno); 1693 (unsigned long long)OCFS2_I(inode)->ip_blkno);
1751 1694
@@ -1760,7 +1703,6 @@ int ocfs2_open_lock(struct inode *inode)
1760 mlog_errno(status); 1703 mlog_errno(status);
1761 1704
1762out: 1705out:
1763 mlog_exit(status);
1764 return status; 1706 return status;
1765} 1707}
1766 1708
@@ -1772,8 +1714,6 @@ int ocfs2_try_open_lock(struct inode *inode, int write)
1772 1714
1773 BUG_ON(!inode); 1715 BUG_ON(!inode);
1774 1716
1775 mlog_entry_void();
1776
1777 mlog(0, "inode %llu try to take %s open lock\n", 1717 mlog(0, "inode %llu try to take %s open lock\n",
1778 (unsigned long long)OCFS2_I(inode)->ip_blkno, 1718 (unsigned long long)OCFS2_I(inode)->ip_blkno,
1779 write ? "EXMODE" : "PRMODE"); 1719 write ? "EXMODE" : "PRMODE");
@@ -1795,7 +1735,6 @@ int ocfs2_try_open_lock(struct inode *inode, int write)
1795 level, DLM_LKF_NOQUEUE, 0); 1735 level, DLM_LKF_NOQUEUE, 0);
1796 1736
1797out: 1737out:
1798 mlog_exit(status);
1799 return status; 1738 return status;
1800} 1739}
1801 1740
@@ -1807,8 +1746,6 @@ void ocfs2_open_unlock(struct inode *inode)
1807 struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_open_lockres; 1746 struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_open_lockres;
1808 struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); 1747 struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
1809 1748
1810 mlog_entry_void();
1811
1812 mlog(0, "inode %llu drop open lock\n", 1749 mlog(0, "inode %llu drop open lock\n",
1813 (unsigned long long)OCFS2_I(inode)->ip_blkno); 1750 (unsigned long long)OCFS2_I(inode)->ip_blkno);
1814 1751
@@ -1823,7 +1760,7 @@ void ocfs2_open_unlock(struct inode *inode)
1823 DLM_LOCK_EX); 1760 DLM_LOCK_EX);
1824 1761
1825out: 1762out:
1826 mlog_exit_void(); 1763 return;
1827} 1764}
1828 1765
1829static int ocfs2_flock_handle_signal(struct ocfs2_lock_res *lockres, 1766static int ocfs2_flock_handle_signal(struct ocfs2_lock_res *lockres,
@@ -2039,8 +1976,6 @@ static void ocfs2_downconvert_on_unlock(struct ocfs2_super *osb,
2039{ 1976{
2040 int kick = 0; 1977 int kick = 0;
2041 1978
2042 mlog_entry_void();
2043
2044 /* If we know that another node is waiting on our lock, kick 1979 /* If we know that another node is waiting on our lock, kick
2045 * the downconvert thread * pre-emptively when we reach a release 1980 * the downconvert thread * pre-emptively when we reach a release
2046 * condition. */ 1981 * condition. */
@@ -2061,8 +1996,6 @@ static void ocfs2_downconvert_on_unlock(struct ocfs2_super *osb,
2061 1996
2062 if (kick) 1997 if (kick)
2063 ocfs2_wake_downconvert_thread(osb); 1998 ocfs2_wake_downconvert_thread(osb);
2064
2065 mlog_exit_void();
2066} 1999}
2067 2000
2068#define OCFS2_SEC_BITS 34 2001#define OCFS2_SEC_BITS 34
@@ -2091,8 +2024,6 @@ static void __ocfs2_stuff_meta_lvb(struct inode *inode)
2091 struct ocfs2_lock_res *lockres = &oi->ip_inode_lockres; 2024 struct ocfs2_lock_res *lockres = &oi->ip_inode_lockres;
2092 struct ocfs2_meta_lvb *lvb; 2025 struct ocfs2_meta_lvb *lvb;
2093 2026
2094 mlog_entry_void();
2095
2096 lvb = ocfs2_dlm_lvb(&lockres->l_lksb); 2027 lvb = ocfs2_dlm_lvb(&lockres->l_lksb);
2097 2028
2098 /* 2029 /*
@@ -2124,8 +2055,6 @@ static void __ocfs2_stuff_meta_lvb(struct inode *inode)
2124 2055
2125out: 2056out:
2126 mlog_meta_lvb(0, lockres); 2057 mlog_meta_lvb(0, lockres);
2127
2128 mlog_exit_void();
2129} 2058}
2130 2059
2131static void ocfs2_unpack_timespec(struct timespec *spec, 2060static void ocfs2_unpack_timespec(struct timespec *spec,
@@ -2141,8 +2070,6 @@ static void ocfs2_refresh_inode_from_lvb(struct inode *inode)
2141 struct ocfs2_lock_res *lockres = &oi->ip_inode_lockres; 2070 struct ocfs2_lock_res *lockres = &oi->ip_inode_lockres;
2142 struct ocfs2_meta_lvb *lvb; 2071 struct ocfs2_meta_lvb *lvb;
2143 2072
2144 mlog_entry_void();
2145
2146 mlog_meta_lvb(0, lockres); 2073 mlog_meta_lvb(0, lockres);
2147 2074
2148 lvb = ocfs2_dlm_lvb(&lockres->l_lksb); 2075 lvb = ocfs2_dlm_lvb(&lockres->l_lksb);
@@ -2173,8 +2100,6 @@ static void ocfs2_refresh_inode_from_lvb(struct inode *inode)
2173 ocfs2_unpack_timespec(&inode->i_ctime, 2100 ocfs2_unpack_timespec(&inode->i_ctime,
2174 be64_to_cpu(lvb->lvb_ictime_packed)); 2101 be64_to_cpu(lvb->lvb_ictime_packed));
2175 spin_unlock(&oi->ip_lock); 2102 spin_unlock(&oi->ip_lock);
2176
2177 mlog_exit_void();
2178} 2103}
2179 2104
2180static inline int ocfs2_meta_lvb_is_trustable(struct inode *inode, 2105static inline int ocfs2_meta_lvb_is_trustable(struct inode *inode,
@@ -2201,8 +2126,6 @@ static int ocfs2_should_refresh_lock_res(struct ocfs2_lock_res *lockres)
2201 unsigned long flags; 2126 unsigned long flags;
2202 int status = 0; 2127 int status = 0;
2203 2128
2204 mlog_entry_void();
2205
2206refresh_check: 2129refresh_check:
2207 spin_lock_irqsave(&lockres->l_lock, flags); 2130 spin_lock_irqsave(&lockres->l_lock, flags);
2208 if (!(lockres->l_flags & OCFS2_LOCK_NEEDS_REFRESH)) { 2131 if (!(lockres->l_flags & OCFS2_LOCK_NEEDS_REFRESH)) {
@@ -2223,7 +2146,7 @@ refresh_check:
2223 2146
2224 status = 1; 2147 status = 1;
2225bail: 2148bail:
2226 mlog_exit(status); 2149 mlog(0, "status %d\n", status);
2227 return status; 2150 return status;
2228} 2151}
2229 2152
@@ -2233,7 +2156,6 @@ static inline void ocfs2_complete_lock_res_refresh(struct ocfs2_lock_res *lockre
2233 int status) 2156 int status)
2234{ 2157{
2235 unsigned long flags; 2158 unsigned long flags;
2236 mlog_entry_void();
2237 2159
2238 spin_lock_irqsave(&lockres->l_lock, flags); 2160 spin_lock_irqsave(&lockres->l_lock, flags);
2239 lockres_clear_flags(lockres, OCFS2_LOCK_REFRESHING); 2161 lockres_clear_flags(lockres, OCFS2_LOCK_REFRESHING);
@@ -2242,8 +2164,6 @@ static inline void ocfs2_complete_lock_res_refresh(struct ocfs2_lock_res *lockre
2242 spin_unlock_irqrestore(&lockres->l_lock, flags); 2164 spin_unlock_irqrestore(&lockres->l_lock, flags);
2243 2165
2244 wake_up(&lockres->l_event); 2166 wake_up(&lockres->l_event);
2245
2246 mlog_exit_void();
2247} 2167}
2248 2168
2249/* may or may not return a bh if it went to disk. */ 2169/* may or may not return a bh if it went to disk. */
@@ -2256,8 +2176,6 @@ static int ocfs2_inode_lock_update(struct inode *inode,
2256 struct ocfs2_dinode *fe; 2176 struct ocfs2_dinode *fe;
2257 struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); 2177 struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
2258 2178
2259 mlog_entry_void();
2260
2261 if (ocfs2_mount_local(osb)) 2179 if (ocfs2_mount_local(osb))
2262 goto bail; 2180 goto bail;
2263 2181
@@ -2326,7 +2244,6 @@ static int ocfs2_inode_lock_update(struct inode *inode,
2326bail_refresh: 2244bail_refresh:
2327 ocfs2_complete_lock_res_refresh(lockres, status); 2245 ocfs2_complete_lock_res_refresh(lockres, status);
2328bail: 2246bail:
2329 mlog_exit(status);
2330 return status; 2247 return status;
2331} 2248}
2332 2249
@@ -2370,8 +2287,6 @@ int ocfs2_inode_lock_full_nested(struct inode *inode,
2370 2287
2371 BUG_ON(!inode); 2288 BUG_ON(!inode);
2372 2289
2373 mlog_entry_void();
2374
2375 mlog(0, "inode %llu, take %s META lock\n", 2290 mlog(0, "inode %llu, take %s META lock\n",
2376 (unsigned long long)OCFS2_I(inode)->ip_blkno, 2291 (unsigned long long)OCFS2_I(inode)->ip_blkno,
2377 ex ? "EXMODE" : "PRMODE"); 2292 ex ? "EXMODE" : "PRMODE");
@@ -2463,7 +2378,6 @@ bail:
2463 if (local_bh) 2378 if (local_bh)
2464 brelse(local_bh); 2379 brelse(local_bh);
2465 2380
2466 mlog_exit(status);
2467 return status; 2381 return status;
2468} 2382}
2469 2383
@@ -2513,7 +2427,6 @@ int ocfs2_inode_lock_atime(struct inode *inode,
2513{ 2427{
2514 int ret; 2428 int ret;
2515 2429
2516 mlog_entry_void();
2517 ret = ocfs2_inode_lock(inode, NULL, 0); 2430 ret = ocfs2_inode_lock(inode, NULL, 0);
2518 if (ret < 0) { 2431 if (ret < 0) {
2519 mlog_errno(ret); 2432 mlog_errno(ret);
@@ -2541,7 +2454,6 @@ int ocfs2_inode_lock_atime(struct inode *inode,
2541 } else 2454 } else
2542 *level = 0; 2455 *level = 0;
2543 2456
2544 mlog_exit(ret);
2545 return ret; 2457 return ret;
2546} 2458}
2547 2459
@@ -2552,8 +2464,6 @@ void ocfs2_inode_unlock(struct inode *inode,
2552 struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_inode_lockres; 2464 struct ocfs2_lock_res *lockres = &OCFS2_I(inode)->ip_inode_lockres;
2553 struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); 2465 struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
2554 2466
2555 mlog_entry_void();
2556
2557 mlog(0, "inode %llu drop %s META lock\n", 2467 mlog(0, "inode %llu drop %s META lock\n",
2558 (unsigned long long)OCFS2_I(inode)->ip_blkno, 2468 (unsigned long long)OCFS2_I(inode)->ip_blkno,
2559 ex ? "EXMODE" : "PRMODE"); 2469 ex ? "EXMODE" : "PRMODE");
@@ -2561,8 +2471,6 @@ void ocfs2_inode_unlock(struct inode *inode,
2561 if (!ocfs2_is_hard_readonly(OCFS2_SB(inode->i_sb)) && 2471 if (!ocfs2_is_hard_readonly(OCFS2_SB(inode->i_sb)) &&
2562 !ocfs2_mount_local(osb)) 2472 !ocfs2_mount_local(osb))
2563 ocfs2_cluster_unlock(OCFS2_SB(inode->i_sb), lockres, level); 2473 ocfs2_cluster_unlock(OCFS2_SB(inode->i_sb), lockres, level);
2564
2565 mlog_exit_void();
2566} 2474}
2567 2475
2568int ocfs2_orphan_scan_lock(struct ocfs2_super *osb, u32 *seqno) 2476int ocfs2_orphan_scan_lock(struct ocfs2_super *osb, u32 *seqno)
@@ -2613,8 +2521,6 @@ int ocfs2_super_lock(struct ocfs2_super *osb,
2613 int level = ex ? DLM_LOCK_EX : DLM_LOCK_PR; 2521 int level = ex ? DLM_LOCK_EX : DLM_LOCK_PR;
2614 struct ocfs2_lock_res *lockres = &osb->osb_super_lockres; 2522 struct ocfs2_lock_res *lockres = &osb->osb_super_lockres;
2615 2523
2616 mlog_entry_void();
2617
2618 if (ocfs2_is_hard_readonly(osb)) 2524 if (ocfs2_is_hard_readonly(osb))
2619 return -EROFS; 2525 return -EROFS;
2620 2526
@@ -2646,7 +2552,6 @@ int ocfs2_super_lock(struct ocfs2_super *osb,
2646 ocfs2_track_lock_refresh(lockres); 2552 ocfs2_track_lock_refresh(lockres);
2647 } 2553 }
2648bail: 2554bail:
2649 mlog_exit(status);
2650 return status; 2555 return status;
2651} 2556}
2652 2557
@@ -3057,8 +2962,6 @@ int ocfs2_dlm_init(struct ocfs2_super *osb)
3057 int status = 0; 2962 int status = 0;
3058 struct ocfs2_cluster_connection *conn = NULL; 2963 struct ocfs2_cluster_connection *conn = NULL;
3059 2964
3060 mlog_entry_void();
3061
3062 if (ocfs2_mount_local(osb)) { 2965 if (ocfs2_mount_local(osb)) {
3063 osb->node_num = 0; 2966 osb->node_num = 0;
3064 goto local; 2967 goto local;
@@ -3115,15 +3018,12 @@ bail:
3115 kthread_stop(osb->dc_task); 3018 kthread_stop(osb->dc_task);
3116 } 3019 }
3117 3020
3118 mlog_exit(status);
3119 return status; 3021 return status;
3120} 3022}
3121 3023
3122void ocfs2_dlm_shutdown(struct ocfs2_super *osb, 3024void ocfs2_dlm_shutdown(struct ocfs2_super *osb,
3123 int hangup_pending) 3025 int hangup_pending)
3124{ 3026{
3125 mlog_entry_void();
3126
3127 ocfs2_drop_osb_locks(osb); 3027 ocfs2_drop_osb_locks(osb);
3128 3028
3129 /* 3029 /*
@@ -3146,8 +3046,6 @@ void ocfs2_dlm_shutdown(struct ocfs2_super *osb,
3146 osb->cconn = NULL; 3046 osb->cconn = NULL;
3147 3047
3148 ocfs2_dlm_shutdown_debug(osb); 3048 ocfs2_dlm_shutdown_debug(osb);
3149
3150 mlog_exit_void();
3151} 3049}
3152 3050
3153static int ocfs2_drop_lock(struct ocfs2_super *osb, 3051static int ocfs2_drop_lock(struct ocfs2_super *osb,
@@ -3229,7 +3127,6 @@ static int ocfs2_drop_lock(struct ocfs2_super *osb,
3229 3127
3230 ocfs2_wait_on_busy_lock(lockres); 3128 ocfs2_wait_on_busy_lock(lockres);
3231out: 3129out:
3232 mlog_exit(0);
3233 return 0; 3130 return 0;
3234} 3131}
3235 3132
@@ -3287,8 +3184,6 @@ int ocfs2_drop_inode_locks(struct inode *inode)
3287{ 3184{
3288 int status, err; 3185 int status, err;
3289 3186
3290 mlog_entry_void();
3291
3292 /* No need to call ocfs2_mark_lockres_freeing here - 3187 /* No need to call ocfs2_mark_lockres_freeing here -
3293 * ocfs2_clear_inode has done it for us. */ 3188 * ocfs2_clear_inode has done it for us. */
3294 3189
@@ -3313,7 +3208,6 @@ int ocfs2_drop_inode_locks(struct inode *inode)
3313 if (err < 0 && !status) 3208 if (err < 0 && !status)
3314 status = err; 3209 status = err;
3315 3210
3316 mlog_exit(status);
3317 return status; 3211 return status;
3318} 3212}
3319 3213
@@ -3355,8 +3249,6 @@ static int ocfs2_downconvert_lock(struct ocfs2_super *osb,
3355 int ret; 3249 int ret;
3356 u32 dlm_flags = DLM_LKF_CONVERT; 3250 u32 dlm_flags = DLM_LKF_CONVERT;
3357 3251
3358 mlog_entry_void();
3359
3360 mlog(ML_BASTS, "lockres %s, level %d => %d\n", lockres->l_name, 3252 mlog(ML_BASTS, "lockres %s, level %d => %d\n", lockres->l_name,
3361 lockres->l_level, new_level); 3253 lockres->l_level, new_level);
3362 3254
@@ -3378,7 +3270,6 @@ static int ocfs2_downconvert_lock(struct ocfs2_super *osb,
3378 3270
3379 ret = 0; 3271 ret = 0;
3380bail: 3272bail:
3381 mlog_exit(ret);
3382 return ret; 3273 return ret;
3383} 3274}
3384 3275
@@ -3388,8 +3279,6 @@ static int ocfs2_prepare_cancel_convert(struct ocfs2_super *osb,
3388{ 3279{
3389 assert_spin_locked(&lockres->l_lock); 3280 assert_spin_locked(&lockres->l_lock);
3390 3281
3391 mlog_entry_void();
3392
3393 if (lockres->l_unlock_action == OCFS2_UNLOCK_CANCEL_CONVERT) { 3282 if (lockres->l_unlock_action == OCFS2_UNLOCK_CANCEL_CONVERT) {
3394 /* If we're already trying to cancel a lock conversion 3283 /* If we're already trying to cancel a lock conversion
3395 * then just drop the spinlock and allow the caller to 3284 * then just drop the spinlock and allow the caller to
@@ -3419,8 +3308,6 @@ static int ocfs2_cancel_convert(struct ocfs2_super *osb,
3419{ 3308{
3420 int ret; 3309 int ret;
3421 3310
3422 mlog_entry_void();
3423
3424 ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb, 3311 ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb,
3425 DLM_LKF_CANCEL); 3312 DLM_LKF_CANCEL);
3426 if (ret) { 3313 if (ret) {
@@ -3430,7 +3317,6 @@ static int ocfs2_cancel_convert(struct ocfs2_super *osb,
3430 3317
3431 mlog(ML_BASTS, "lockres %s\n", lockres->l_name); 3318 mlog(ML_BASTS, "lockres %s\n", lockres->l_name);
3432 3319
3433 mlog_exit(ret);
3434 return ret; 3320 return ret;
3435} 3321}
3436 3322
@@ -3446,8 +3332,6 @@ static int ocfs2_unblock_lock(struct ocfs2_super *osb,
3446 int set_lvb = 0; 3332 int set_lvb = 0;
3447 unsigned int gen; 3333 unsigned int gen;
3448 3334
3449 mlog_entry_void();
3450
3451 spin_lock_irqsave(&lockres->l_lock, flags); 3335 spin_lock_irqsave(&lockres->l_lock, flags);
3452 3336
3453recheck: 3337recheck:
@@ -3622,14 +3506,14 @@ downconvert:
3622 gen); 3506 gen);
3623 3507
3624leave: 3508leave:
3625 mlog_exit(ret); 3509 if (ret)
3510 mlog_errno(ret);
3626 return ret; 3511 return ret;
3627 3512
3628leave_requeue: 3513leave_requeue:
3629 spin_unlock_irqrestore(&lockres->l_lock, flags); 3514 spin_unlock_irqrestore(&lockres->l_lock, flags);
3630 ctl->requeue = 1; 3515 ctl->requeue = 1;
3631 3516
3632 mlog_exit(0);
3633 return 0; 3517 return 0;
3634} 3518}
3635 3519
@@ -3862,8 +3746,6 @@ static void ocfs2_set_qinfo_lvb(struct ocfs2_lock_res *lockres)
3862 struct mem_dqinfo *info = sb_dqinfo(oinfo->dqi_gi.dqi_sb, 3746 struct mem_dqinfo *info = sb_dqinfo(oinfo->dqi_gi.dqi_sb,
3863 oinfo->dqi_gi.dqi_type); 3747 oinfo->dqi_gi.dqi_type);
3864 3748
3865 mlog_entry_void();
3866
3867 lvb = ocfs2_dlm_lvb(&lockres->l_lksb); 3749 lvb = ocfs2_dlm_lvb(&lockres->l_lksb);
3868 lvb->lvb_version = OCFS2_QINFO_LVB_VERSION; 3750 lvb->lvb_version = OCFS2_QINFO_LVB_VERSION;
3869 lvb->lvb_bgrace = cpu_to_be32(info->dqi_bgrace); 3751 lvb->lvb_bgrace = cpu_to_be32(info->dqi_bgrace);
@@ -3872,8 +3754,6 @@ static void ocfs2_set_qinfo_lvb(struct ocfs2_lock_res *lockres)
3872 lvb->lvb_blocks = cpu_to_be32(oinfo->dqi_gi.dqi_blocks); 3754 lvb->lvb_blocks = cpu_to_be32(oinfo->dqi_gi.dqi_blocks);
3873 lvb->lvb_free_blk = cpu_to_be32(oinfo->dqi_gi.dqi_free_blk); 3755 lvb->lvb_free_blk = cpu_to_be32(oinfo->dqi_gi.dqi_free_blk);
3874 lvb->lvb_free_entry = cpu_to_be32(oinfo->dqi_gi.dqi_free_entry); 3756 lvb->lvb_free_entry = cpu_to_be32(oinfo->dqi_gi.dqi_free_entry);
3875
3876 mlog_exit_void();
3877} 3757}
3878 3758
3879void ocfs2_qinfo_unlock(struct ocfs2_mem_dqinfo *oinfo, int ex) 3759void ocfs2_qinfo_unlock(struct ocfs2_mem_dqinfo *oinfo, int ex)
@@ -3882,10 +3762,8 @@ void ocfs2_qinfo_unlock(struct ocfs2_mem_dqinfo *oinfo, int ex)
3882 struct ocfs2_super *osb = OCFS2_SB(oinfo->dqi_gi.dqi_sb); 3762 struct ocfs2_super *osb = OCFS2_SB(oinfo->dqi_gi.dqi_sb);
3883 int level = ex ? DLM_LOCK_EX : DLM_LOCK_PR; 3763 int level = ex ? DLM_LOCK_EX : DLM_LOCK_PR;
3884 3764
3885 mlog_entry_void();
3886 if (!ocfs2_is_hard_readonly(osb) && !ocfs2_mount_local(osb)) 3765 if (!ocfs2_is_hard_readonly(osb) && !ocfs2_mount_local(osb))
3887 ocfs2_cluster_unlock(osb, lockres, level); 3766 ocfs2_cluster_unlock(osb, lockres, level);
3888 mlog_exit_void();
3889} 3767}
3890 3768
3891static int ocfs2_refresh_qinfo(struct ocfs2_mem_dqinfo *oinfo) 3769static int ocfs2_refresh_qinfo(struct ocfs2_mem_dqinfo *oinfo)
@@ -3940,8 +3818,6 @@ int ocfs2_qinfo_lock(struct ocfs2_mem_dqinfo *oinfo, int ex)
3940 int level = ex ? DLM_LOCK_EX : DLM_LOCK_PR; 3818 int level = ex ? DLM_LOCK_EX : DLM_LOCK_PR;
3941 int status = 0; 3819 int status = 0;
3942 3820
3943 mlog_entry_void();
3944
3945 /* On RO devices, locking really isn't needed... */ 3821 /* On RO devices, locking really isn't needed... */
3946 if (ocfs2_is_hard_readonly(osb)) { 3822 if (ocfs2_is_hard_readonly(osb)) {
3947 if (ex) 3823 if (ex)
@@ -3964,7 +3840,6 @@ int ocfs2_qinfo_lock(struct ocfs2_mem_dqinfo *oinfo, int ex)
3964 ocfs2_qinfo_unlock(oinfo, ex); 3840 ocfs2_qinfo_unlock(oinfo, ex);
3965 ocfs2_complete_lock_res_refresh(lockres, status); 3841 ocfs2_complete_lock_res_refresh(lockres, status);
3966bail: 3842bail:
3967 mlog_exit(status);
3968 return status; 3843 return status;
3969} 3844}
3970 3845
@@ -4010,8 +3885,6 @@ static void ocfs2_process_blocked_lock(struct ocfs2_super *osb,
4010 * considered valid until we remove the OCFS2_LOCK_QUEUED 3885 * considered valid until we remove the OCFS2_LOCK_QUEUED
4011 * flag. */ 3886 * flag. */
4012 3887
4013 mlog_entry_void();
4014
4015 BUG_ON(!lockres); 3888 BUG_ON(!lockres);
4016 BUG_ON(!lockres->l_ops); 3889 BUG_ON(!lockres->l_ops);
4017 3890
@@ -4045,15 +3918,11 @@ unqueue:
4045 if (ctl.unblock_action != UNBLOCK_CONTINUE 3918 if (ctl.unblock_action != UNBLOCK_CONTINUE
4046 && lockres->l_ops->post_unlock) 3919 && lockres->l_ops->post_unlock)
4047 lockres->l_ops->post_unlock(osb, lockres); 3920 lockres->l_ops->post_unlock(osb, lockres);
4048
4049 mlog_exit_void();
4050} 3921}
4051 3922
4052static void ocfs2_schedule_blocked_lock(struct ocfs2_super *osb, 3923static void ocfs2_schedule_blocked_lock(struct ocfs2_super *osb,
4053 struct ocfs2_lock_res *lockres) 3924 struct ocfs2_lock_res *lockres)
4054{ 3925{
4055 mlog_entry_void();
4056
4057 assert_spin_locked(&lockres->l_lock); 3926 assert_spin_locked(&lockres->l_lock);
4058 3927
4059 if (lockres->l_flags & OCFS2_LOCK_FREEING) { 3928 if (lockres->l_flags & OCFS2_LOCK_FREEING) {
@@ -4074,8 +3943,6 @@ static void ocfs2_schedule_blocked_lock(struct ocfs2_super *osb,
4074 osb->blocked_lock_count++; 3943 osb->blocked_lock_count++;
4075 } 3944 }
4076 spin_unlock(&osb->dc_task_lock); 3945 spin_unlock(&osb->dc_task_lock);
4077
4078 mlog_exit_void();
4079} 3946}
4080 3947
4081static void ocfs2_downconvert_thread_do_work(struct ocfs2_super *osb) 3948static void ocfs2_downconvert_thread_do_work(struct ocfs2_super *osb)
@@ -4083,8 +3950,6 @@ static void ocfs2_downconvert_thread_do_work(struct ocfs2_super *osb)
4083 unsigned long processed; 3950 unsigned long processed;
4084 struct ocfs2_lock_res *lockres; 3951 struct ocfs2_lock_res *lockres;
4085 3952
4086 mlog_entry_void();
4087
4088 spin_lock(&osb->dc_task_lock); 3953 spin_lock(&osb->dc_task_lock);
4089 /* grab this early so we know to try again if a state change and 3954 /* grab this early so we know to try again if a state change and
4090 * wake happens part-way through our work */ 3955 * wake happens part-way through our work */
@@ -4108,8 +3973,6 @@ static void ocfs2_downconvert_thread_do_work(struct ocfs2_super *osb)
4108 spin_lock(&osb->dc_task_lock); 3973 spin_lock(&osb->dc_task_lock);
4109 } 3974 }
4110 spin_unlock(&osb->dc_task_lock); 3975 spin_unlock(&osb->dc_task_lock);
4111
4112 mlog_exit_void();
4113} 3976}
4114 3977
4115static int ocfs2_downconvert_thread_lists_empty(struct ocfs2_super *osb) 3978static int ocfs2_downconvert_thread_lists_empty(struct ocfs2_super *osb)