diff options
author | Tao Ma <boyu.mt@taobao.com> | 2011-02-20 22:10:44 -0500 |
---|---|---|
committer | Tao Ma <boyu.mt@taobao.com> | 2011-02-20 22:10:44 -0500 |
commit | ef6b689b63b9f5227ccee6f16dd9ee3faf58a464 (patch) | |
tree | ebe3416fcc221e152f2625e8e8794e92e3d8c979 /fs/ocfs2/dir.c | |
parent | 422e6c4bc4b48c15b3cb57a1ca71431abfc57e54 (diff) |
ocfs2: Remove ENTRY from masklog.
ENTRY is used to record the entry of a function.
But because it is added in so many functions, if we enable it,
the system logs get filled up quickly and cause too much I/O.
So actually no one can open it for a production system or even
for a test.
So for mlog_entry_void, we just remove it.
for mlog_entry(...), we replace it with mlog(0,...), and they
will be replace by trace event later.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Diffstat (limited to 'fs/ocfs2/dir.c')
-rw-r--r-- | fs/ocfs2/dir.c | 20 |
1 files changed, 5 insertions, 15 deletions
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index d417b3f9b0c7..2c983f083f8a 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c | |||
@@ -367,8 +367,6 @@ static int inline ocfs2_search_dirblock(struct buffer_head *bh, | |||
367 | int de_len; | 367 | int de_len; |
368 | int ret = 0; | 368 | int ret = 0; |
369 | 369 | ||
370 | mlog_entry_void(); | ||
371 | |||
372 | de_buf = first_de; | 370 | de_buf = first_de; |
373 | dlimit = de_buf + bytes; | 371 | dlimit = de_buf + bytes; |
374 | 372 | ||
@@ -706,8 +704,6 @@ static struct buffer_head *ocfs2_find_entry_el(const char *name, int namelen, | |||
706 | int num = 0; | 704 | int num = 0; |
707 | int nblocks, i, err; | 705 | int nblocks, i, err; |
708 | 706 | ||
709 | mlog_entry_void(); | ||
710 | |||
711 | sb = dir->i_sb; | 707 | sb = dir->i_sb; |
712 | 708 | ||
713 | nblocks = i_size_read(dir) >> sb->s_blocksize_bits; | 709 | nblocks = i_size_read(dir) >> sb->s_blocksize_bits; |
@@ -1166,7 +1162,7 @@ static int __ocfs2_delete_entry(handle_t *handle, struct inode *dir, | |||
1166 | int i, status = -ENOENT; | 1162 | int i, status = -ENOENT; |
1167 | ocfs2_journal_access_func access = ocfs2_journal_access_db; | 1163 | ocfs2_journal_access_func access = ocfs2_journal_access_db; |
1168 | 1164 | ||
1169 | mlog_entry("(0x%p, 0x%p, 0x%p, 0x%p)\n", handle, dir, de_del, bh); | 1165 | mlog(0, "(0x%p, 0x%p, 0x%p, 0x%p)\n", handle, dir, de_del, bh); |
1170 | 1166 | ||
1171 | if (OCFS2_I(dir)->ip_dyn_features & OCFS2_INLINE_DATA_FL) | 1167 | if (OCFS2_I(dir)->ip_dyn_features & OCFS2_INLINE_DATA_FL) |
1172 | access = ocfs2_journal_access_di; | 1168 | access = ocfs2_journal_access_di; |
@@ -1632,8 +1628,6 @@ int __ocfs2_add_entry(handle_t *handle, | |||
1632 | struct buffer_head *insert_bh = lookup->dl_leaf_bh; | 1628 | struct buffer_head *insert_bh = lookup->dl_leaf_bh; |
1633 | char *data_start = insert_bh->b_data; | 1629 | char *data_start = insert_bh->b_data; |
1634 | 1630 | ||
1635 | mlog_entry_void(); | ||
1636 | |||
1637 | if (!namelen) | 1631 | if (!namelen) |
1638 | return -EINVAL; | 1632 | return -EINVAL; |
1639 | 1633 | ||
@@ -2028,8 +2022,8 @@ int ocfs2_readdir(struct file * filp, void * dirent, filldir_t filldir) | |||
2028 | struct inode *inode = filp->f_path.dentry->d_inode; | 2022 | struct inode *inode = filp->f_path.dentry->d_inode; |
2029 | int lock_level = 0; | 2023 | int lock_level = 0; |
2030 | 2024 | ||
2031 | mlog_entry("dirino=%llu\n", | 2025 | mlog(0, "dirino=%llu\n", |
2032 | (unsigned long long)OCFS2_I(inode)->ip_blkno); | 2026 | (unsigned long long)OCFS2_I(inode)->ip_blkno); |
2033 | 2027 | ||
2034 | error = ocfs2_inode_lock_atime(inode, filp->f_vfsmnt, &lock_level); | 2028 | error = ocfs2_inode_lock_atime(inode, filp->f_vfsmnt, &lock_level); |
2035 | if (lock_level && error >= 0) { | 2029 | if (lock_level && error >= 0) { |
@@ -2114,8 +2108,8 @@ int ocfs2_check_dir_for_entry(struct inode *dir, | |||
2114 | int ret; | 2108 | int ret; |
2115 | struct ocfs2_dir_lookup_result lookup = { NULL, }; | 2109 | struct ocfs2_dir_lookup_result lookup = { NULL, }; |
2116 | 2110 | ||
2117 | mlog_entry("dir %llu, name '%.*s'\n", | 2111 | mlog(0, "dir %llu, name '%.*s'\n", |
2118 | (unsigned long long)OCFS2_I(dir)->ip_blkno, namelen, name); | 2112 | (unsigned long long)OCFS2_I(dir)->ip_blkno, namelen, name); |
2119 | 2113 | ||
2120 | ret = -EEXIST; | 2114 | ret = -EEXIST; |
2121 | if (ocfs2_find_entry(name, namelen, dir, &lookup) == 0) | 2115 | if (ocfs2_find_entry(name, namelen, dir, &lookup) == 0) |
@@ -2324,8 +2318,6 @@ static int ocfs2_fill_new_dir_el(struct ocfs2_super *osb, | |||
2324 | struct buffer_head *new_bh = NULL; | 2318 | struct buffer_head *new_bh = NULL; |
2325 | struct ocfs2_dir_entry *de; | 2319 | struct ocfs2_dir_entry *de; |
2326 | 2320 | ||
2327 | mlog_entry_void(); | ||
2328 | |||
2329 | if (ocfs2_new_dir_wants_trailer(inode)) | 2321 | if (ocfs2_new_dir_wants_trailer(inode)) |
2330 | size = ocfs2_dir_trailer_blk_off(parent->i_sb); | 2322 | size = ocfs2_dir_trailer_blk_off(parent->i_sb); |
2331 | 2323 | ||
@@ -3270,8 +3262,6 @@ static int ocfs2_extend_dir(struct ocfs2_super *osb, | |||
3270 | struct ocfs2_extent_tree et; | 3262 | struct ocfs2_extent_tree et; |
3271 | struct buffer_head *dx_root_bh = lookup->dl_dx_root_bh; | 3263 | struct buffer_head *dx_root_bh = lookup->dl_dx_root_bh; |
3272 | 3264 | ||
3273 | mlog_entry_void(); | ||
3274 | |||
3275 | if (OCFS2_I(dir)->ip_dyn_features & OCFS2_INLINE_DATA_FL) { | 3265 | if (OCFS2_I(dir)->ip_dyn_features & OCFS2_INLINE_DATA_FL) { |
3276 | /* | 3266 | /* |
3277 | * This would be a code error as an inline directory should | 3267 | * This would be a code error as an inline directory should |