fs: replace NIPQUAD()

Using NIPQUAD() with NIPQUAD_FMT, %d.%d.%d.%d or %u.%u.%u.%u
can be replaced with %pI4

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 14 insertions, 15 deletions

diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c
index 2bcf706d9dd3..9fbe849f6344 100644
--- a/fs/ocfs2/cluster/tcp.c
+++ b/fs/ocfs2/cluster/tcp.c
@@ -1597,8 +1597,8 @@ static void o2net_start_connect(struct work_struct *work)
         ret = sock->ops->bind(sock, (struct sockaddr *)&myaddr,
                               sizeof(myaddr));
         if (ret) {
-                mlog(ML_ERROR, "bind failed with %d at address %u.%u.%u.%u\n",
-                     ret, NIPQUAD(mynode->nd_ipv4_address));
+                mlog(ML_ERROR, "bind failed with %d at address %pI4\n",
+                     ret, &mynode->nd_ipv4_address);
                 goto out;
         }
 
@@ -1790,17 +1790,16 @@ static int o2net_accept_one(struct socket *sock)
 
         node = o2nm_get_node_by_ip(sin.sin_addr.s_addr);
         if (node == NULL) {
-                mlog(ML_NOTICE, "attempt to connect from unknown node at "
-                     "%u.%u.%u.%u:%d\n", NIPQUAD(sin.sin_addr.s_addr),
-                     ntohs(sin.sin_port));
+                mlog(ML_NOTICE, "attempt to connect from unknown node at %pI4:%d\n",
+                     &sin.sin_addr.s_addr, ntohs(sin.sin_port));
                 ret = -EINVAL;
                 goto out;
         }
 
         if (o2nm_this_node() > node->nd_num) {
                 mlog(ML_NOTICE, "unexpected connect attempted from a lower "
-                     "numbered node '%s' at " "%u.%u.%u.%u:%d with num %u\n",
-                     node->nd_name, NIPQUAD(sin.sin_addr.s_addr),
+                     "numbered node '%s' at " "%pI4:%d with num %u\n",
+                     node->nd_name, &sin.sin_addr.s_addr,
                      ntohs(sin.sin_port), node->nd_num);
                 ret = -EINVAL;
                 goto out;
@@ -1810,8 +1809,8 @@ static int o2net_accept_one(struct socket *sock)
          * and tries to connect before we see their heartbeat */
         if (!o2hb_check_node_heartbeating_from_callback(node->nd_num)) {
                 mlog(ML_CONN, "attempt to connect from node '%s' at "
-                     "%u.%u.%u.%u:%d but it isn't heartbeating\n",
-                     node->nd_name, NIPQUAD(sin.sin_addr.s_addr),
+                     "%pI4:%d but it isn't heartbeating\n",
+                     node->nd_name, &sin.sin_addr.s_addr,
                      ntohs(sin.sin_port));
                 ret = -EINVAL;
                 goto out;
@@ -1827,8 +1826,8 @@ static int o2net_accept_one(struct socket *sock)
         spin_unlock(&nn->nn_lock);
         if (ret) {
                 mlog(ML_NOTICE, "attempt to connect from node '%s' at "
-                     "%u.%u.%u.%u:%d but it already has an open connection\n",
-                     node->nd_name, NIPQUAD(sin.sin_addr.s_addr),
+                     "%pI4:%d but it already has an open connection\n",
+                     node->nd_name, &sin.sin_addr.s_addr,
                      ntohs(sin.sin_port));
                 goto out;
         }
@@ -1924,15 +1923,15 @@ static int o2net_open_listening_sock(__be32 addr, __be16 port)
         sock->sk->sk_reuse = 1;
         ret = sock->ops->bind(sock, (struct sockaddr *)&sin, sizeof(sin));
         if (ret < 0) {
-                mlog(ML_ERROR, "unable to bind socket at %u.%u.%u.%u:%u, "
-                     "ret=%d\n", NIPQUAD(addr), ntohs(port), ret);
+                mlog(ML_ERROR, "unable to bind socket at %pI4:%u, "
+                     "ret=%d\n", &addr, ntohs(port), ret);
                 goto out;
         }
 
         ret = sock->ops->listen(sock, 64);
         if (ret < 0) {
-                mlog(ML_ERROR, "unable to listen on %u.%u.%u.%u:%u, ret=%d\n",
-                     NIPQUAD(addr), ntohs(port), ret);
+                mlog(ML_ERROR, "unable to listen on %pI4:%u, ret=%d\n",
+                     &addr, ntohs(port), ret);
         }
 
 out: