diff options
author | Joel Becker <joel.becker@oracle.com> | 2008-10-09 20:20:31 -0400 |
---|---|---|
committer | Mark Fasheh <mfasheh@suse.com> | 2008-10-14 14:51:57 -0400 |
commit | 0fcaa56a2a020dd6f90c202b7084e6f4cbedb6c2 (patch) | |
tree | 057204016523ce0274d4a23ec02944075f084e8c /fs/ocfs2/aops.c | |
parent | 31d33073ca38603dea705dae45e094a64ca062d6 (diff) |
ocfs2: Simplify ocfs2_read_block()
More than 30 callers of ocfs2_read_block() pass exactly OCFS2_BH_CACHED.
Only six pass a different flag set. Rather than have every caller care,
let's make ocfs2_read_block() take no flags and always do a cached read.
The remaining six places can call ocfs2_read_blocks() directly.
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
Diffstat (limited to 'fs/ocfs2/aops.c')
-rw-r--r-- | fs/ocfs2/aops.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index f232a0e3c30f..c22543b33420 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c | |||
@@ -68,8 +68,7 @@ static int ocfs2_symlink_get_block(struct inode *inode, sector_t iblock, | |||
68 | goto bail; | 68 | goto bail; |
69 | } | 69 | } |
70 | 70 | ||
71 | status = ocfs2_read_block(inode, OCFS2_I(inode)->ip_blkno, | 71 | status = ocfs2_read_block(inode, OCFS2_I(inode)->ip_blkno, &bh); |
72 | &bh, OCFS2_BH_CACHED); | ||
73 | if (status < 0) { | 72 | if (status < 0) { |
74 | mlog_errno(status); | 73 | mlog_errno(status); |
75 | goto bail; | 74 | goto bail; |
@@ -263,8 +262,7 @@ static int ocfs2_readpage_inline(struct inode *inode, struct page *page) | |||
263 | BUG_ON(!PageLocked(page)); | 262 | BUG_ON(!PageLocked(page)); |
264 | BUG_ON(!(OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_DATA_FL)); | 263 | BUG_ON(!(OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_DATA_FL)); |
265 | 264 | ||
266 | ret = ocfs2_read_block(inode, OCFS2_I(inode)->ip_blkno, &di_bh, | 265 | ret = ocfs2_read_block(inode, OCFS2_I(inode)->ip_blkno, &di_bh); |
267 | OCFS2_BH_CACHED); | ||
268 | if (ret) { | 266 | if (ret) { |
269 | mlog_errno(ret); | 267 | mlog_errno(ret); |
270 | goto out; | 268 | goto out; |