diff options
author | Tao Ma <boyu.mt@taobao.com> | 2011-02-20 22:10:44 -0500 |
---|---|---|
committer | Tao Ma <boyu.mt@taobao.com> | 2011-02-20 22:10:44 -0500 |
commit | ef6b689b63b9f5227ccee6f16dd9ee3faf58a464 (patch) | |
tree | ebe3416fcc221e152f2625e8e8794e92e3d8c979 /fs/ocfs2/aops.c | |
parent | 422e6c4bc4b48c15b3cb57a1ca71431abfc57e54 (diff) |
ocfs2: Remove ENTRY from masklog.
ENTRY is used to record the entry of a function.
But because it is added in so many functions, if we enable it,
the system logs get filled up quickly and cause too much I/O.
So actually no one can open it for a production system or even
for a test.
So for mlog_entry_void, we just remove it.
for mlog_entry(...), we replace it with mlog(0,...), and they
will be replace by trace event later.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Diffstat (limited to 'fs/ocfs2/aops.c')
-rw-r--r-- | fs/ocfs2/aops.c | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 1fbb0e20131b..5dbfc9e45195 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c | |||
@@ -59,8 +59,8 @@ static int ocfs2_symlink_get_block(struct inode *inode, sector_t iblock, | |||
59 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); | 59 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); |
60 | void *kaddr; | 60 | void *kaddr; |
61 | 61 | ||
62 | mlog_entry("(0x%p, %llu, 0x%p, %d)\n", inode, | 62 | mlog(0, "(0x%p, %llu, 0x%p, %d)\n", inode, |
63 | (unsigned long long)iblock, bh_result, create); | 63 | (unsigned long long)iblock, bh_result, create); |
64 | 64 | ||
65 | BUG_ON(ocfs2_inode_is_fast_symlink(inode)); | 65 | BUG_ON(ocfs2_inode_is_fast_symlink(inode)); |
66 | 66 | ||
@@ -136,8 +136,8 @@ int ocfs2_get_block(struct inode *inode, sector_t iblock, | |||
136 | u64 p_blkno, count, past_eof; | 136 | u64 p_blkno, count, past_eof; |
137 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); | 137 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); |
138 | 138 | ||
139 | mlog_entry("(0x%p, %llu, 0x%p, %d)\n", inode, | 139 | mlog(0, "(0x%p, %llu, 0x%p, %d)\n", inode, |
140 | (unsigned long long)iblock, bh_result, create); | 140 | (unsigned long long)iblock, bh_result, create); |
141 | 141 | ||
142 | if (OCFS2_I(inode)->ip_flags & OCFS2_INODE_SYSTEM_FILE) | 142 | if (OCFS2_I(inode)->ip_flags & OCFS2_INODE_SYSTEM_FILE) |
143 | mlog(ML_NOTICE, "get_block on system inode 0x%p (%lu)\n", | 143 | mlog(ML_NOTICE, "get_block on system inode 0x%p (%lu)\n", |
@@ -278,7 +278,7 @@ static int ocfs2_readpage(struct file *file, struct page *page) | |||
278 | loff_t start = (loff_t)page->index << PAGE_CACHE_SHIFT; | 278 | loff_t start = (loff_t)page->index << PAGE_CACHE_SHIFT; |
279 | int ret, unlock = 1; | 279 | int ret, unlock = 1; |
280 | 280 | ||
281 | mlog_entry("(0x%p, %lu)\n", file, (page ? page->index : 0)); | 281 | mlog(0, "(0x%p, %lu)\n", file, (page ? page->index : 0)); |
282 | 282 | ||
283 | ret = ocfs2_inode_lock_with_page(inode, NULL, 0, page); | 283 | ret = ocfs2_inode_lock_with_page(inode, NULL, 0, page); |
284 | if (ret != 0) { | 284 | if (ret != 0) { |
@@ -398,7 +398,7 @@ static int ocfs2_writepage(struct page *page, struct writeback_control *wbc) | |||
398 | { | 398 | { |
399 | int ret; | 399 | int ret; |
400 | 400 | ||
401 | mlog_entry("(0x%p)\n", page); | 401 | mlog(0, "(0x%p)\n", page); |
402 | 402 | ||
403 | ret = block_write_full_page(page, ocfs2_get_block, wbc); | 403 | ret = block_write_full_page(page, ocfs2_get_block, wbc); |
404 | 404 | ||
@@ -450,7 +450,7 @@ static sector_t ocfs2_bmap(struct address_space *mapping, sector_t block) | |||
450 | int err = 0; | 450 | int err = 0; |
451 | struct inode *inode = mapping->host; | 451 | struct inode *inode = mapping->host; |
452 | 452 | ||
453 | mlog_entry("(block = %llu)\n", (unsigned long long)block); | 453 | mlog(0, "(block = %llu)\n", (unsigned long long)block); |
454 | 454 | ||
455 | /* We don't need to lock journal system files, since they aren't | 455 | /* We don't need to lock journal system files, since they aren't |
456 | * accessed concurrently from multiple nodes. | 456 | * accessed concurrently from multiple nodes. |
@@ -618,8 +618,6 @@ static ssize_t ocfs2_direct_IO(int rw, | |||
618 | struct inode *inode = file->f_path.dentry->d_inode->i_mapping->host; | 618 | struct inode *inode = file->f_path.dentry->d_inode->i_mapping->host; |
619 | int ret; | 619 | int ret; |
620 | 620 | ||
621 | mlog_entry_void(); | ||
622 | |||
623 | /* | 621 | /* |
624 | * Fallback to buffered I/O if we see an inode without | 622 | * Fallback to buffered I/O if we see an inode without |
625 | * extents. | 623 | * extents. |