diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-05 09:40:36 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/ntfs | |
parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ntfs')
-rw-r--r-- | fs/ntfs/super.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c index 6aa7c4713536..a9ec4e1084e4 100644 --- a/fs/ntfs/super.c +++ b/fs/ntfs/super.c | |||
@@ -2246,6 +2246,9 @@ static void ntfs_put_super(struct super_block *sb) | |||
2246 | ntfs_volume *vol = NTFS_SB(sb); | 2246 | ntfs_volume *vol = NTFS_SB(sb); |
2247 | 2247 | ||
2248 | ntfs_debug("Entering."); | 2248 | ntfs_debug("Entering."); |
2249 | |||
2250 | lock_kernel(); | ||
2251 | |||
2249 | #ifdef NTFS_RW | 2252 | #ifdef NTFS_RW |
2250 | /* | 2253 | /* |
2251 | * Commit all inodes while they are still open in case some of them | 2254 | * Commit all inodes while they are still open in case some of them |
@@ -2444,7 +2447,8 @@ static void ntfs_put_super(struct super_block *sb) | |||
2444 | } | 2447 | } |
2445 | sb->s_fs_info = NULL; | 2448 | sb->s_fs_info = NULL; |
2446 | kfree(vol); | 2449 | kfree(vol); |
2447 | return; | 2450 | |
2451 | unlock_kernel(); | ||
2448 | } | 2452 | } |
2449 | 2453 | ||
2450 | /** | 2454 | /** |