diff options
author | Zhang Qiang <zhangqiang.buaa@gmail.com> | 2009-08-09 07:13:10 -0400 |
---|---|---|
committer | Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> | 2009-09-14 05:27:14 -0400 |
commit | a4f0b9c5b4ae83636dafde8f3a0e04b5e411a0f3 (patch) | |
tree | 885111c7beec6e69680768c7fb1a8b22d53cd175 /fs/nilfs2 | |
parent | c1b353f04a42f1b531be920149b85343d56a6b3b (diff) |
nilfs2: An unassigned variable is assigned to a never used structure member
nilfs2: In procedure 'nilfs_get_sb()', when a nilfs filesysttem is
mounted for the first time, local variable 'nilfs->ns_last_cno' is
used before loading the latest checkpoint number from disk (in
'nilfs_fill_super'). 'nilfs->ns_last_cno' is assigned to 'sd.cno', but
'sd.cno' has never been used in the procedure.
Signed-off-by: Zhang Qiang <zhangqiang.buaa@gmail.com>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Diffstat (limited to 'fs/nilfs2')
-rw-r--r-- | fs/nilfs2/super.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index ed8ec5718ae6..019752f7d2da 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c | |||
@@ -1103,10 +1103,6 @@ nilfs_get_sb(struct file_system_type *fs_type, int flags, | |||
1103 | */ | 1103 | */ |
1104 | sd.sbi = nilfs_find_sbinfo(nilfs, !(flags & MS_RDONLY), sd.cno); | 1104 | sd.sbi = nilfs_find_sbinfo(nilfs, !(flags & MS_RDONLY), sd.cno); |
1105 | 1105 | ||
1106 | if (!sd.cno) | ||
1107 | /* trying to get the latest checkpoint. */ | ||
1108 | sd.cno = nilfs_last_cno(nilfs); | ||
1109 | |||
1110 | /* | 1106 | /* |
1111 | * Get super block instance holding the nilfs_sb_info struct. | 1107 | * Get super block instance holding the nilfs_sb_info struct. |
1112 | * A new instance is allocated if no existing mount is present or | 1108 | * A new instance is allocated if no existing mount is present or |