diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2011-12-12 15:51:45 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-01-03 22:52:40 -0500 |
commit | 6b520e0565422966cdf1c3759bd73df77b0f248c (patch) | |
tree | f63a26afa7342eb59b125271b16e30a219b59094 /fs/nilfs2/super.c | |
parent | 2a79f17e4a641a2f463cb512cb0ec349844a147b (diff) |
vfs: fix the stupidity with i_dentry in inode destructors
Seeing that just about every destructor got that INIT_LIST_HEAD() copied into
it, there is no point whatsoever keeping this INIT_LIST_HEAD in inode_init_once();
the cost of taking it into inode_init_always() will be negligible for pipes
and sockets and negative for everything else. Not to mention the removal of
boilerplate code from ->destroy_inode() instances...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/nilfs2/super.c')
-rw-r--r-- | fs/nilfs2/super.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 8351c44a7320..5356c7169d50 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c | |||
@@ -175,8 +175,6 @@ static void nilfs_i_callback(struct rcu_head *head) | |||
175 | struct inode *inode = container_of(head, struct inode, i_rcu); | 175 | struct inode *inode = container_of(head, struct inode, i_rcu); |
176 | struct nilfs_mdt_info *mdi = NILFS_MDT(inode); | 176 | struct nilfs_mdt_info *mdi = NILFS_MDT(inode); |
177 | 177 | ||
178 | INIT_LIST_HEAD(&inode->i_dentry); | ||
179 | |||
180 | if (mdi) { | 178 | if (mdi) { |
181 | kfree(mdi->mi_bgl); /* kfree(NULL) is safe */ | 179 | kfree(mdi->mi_bgl); /* kfree(NULL) is safe */ |
182 | kfree(mdi); | 180 | kfree(mdi); |