diff options
author | J. Bruce Fields <bfields@citi.umich.edu> | 2010-02-21 20:41:19 -0500 |
---|---|---|
committer | J. Bruce Fields <bfields@citi.umich.edu> | 2010-04-02 16:36:30 -0400 |
commit | 147efd0dd702ce2f1ab44449bd70369405ef68fd (patch) | |
tree | 8d50a3d1bc78fffb9189a1ba3927f53c2ee8bb8a /fs/nfsd | |
parent | 227f98d98d2ed7929f41426adc21f57b927354a6 (diff) |
nfsd4: shutdown callbacks on expiry
Once we've expired the client, there's no further purpose to the
callbacks; go ahead and shut down the callback client rather than
waiting for the last reference to go.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'fs/nfsd')
-rw-r--r-- | fs/nfsd/nfs4state.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index efef7f2442d5..9ce58318ca8c 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c | |||
@@ -697,9 +697,6 @@ shutdown_callback_client(struct nfs4_client *clp) | |||
697 | static inline void | 697 | static inline void |
698 | free_client(struct nfs4_client *clp) | 698 | free_client(struct nfs4_client *clp) |
699 | { | 699 | { |
700 | shutdown_callback_client(clp); | ||
701 | if (clp->cl_cb_xprt) | ||
702 | svc_xprt_put(clp->cl_cb_xprt); | ||
703 | if (clp->cl_cred.cr_group_info) | 700 | if (clp->cl_cred.cr_group_info) |
704 | put_group_info(clp->cl_cred.cr_group_info); | 701 | put_group_info(clp->cl_cred.cr_group_info); |
705 | kfree(clp->cl_principal); | 702 | kfree(clp->cl_principal); |
@@ -752,6 +749,9 @@ expire_client(struct nfs4_client *clp) | |||
752 | se_perclnt); | 749 | se_perclnt); |
753 | release_session(ses); | 750 | release_session(ses); |
754 | } | 751 | } |
752 | shutdown_callback_client(clp); | ||
753 | if (clp->cl_cb_xprt) | ||
754 | svc_xprt_put(clp->cl_cb_xprt); | ||
755 | put_nfs4_client(clp); | 755 | put_nfs4_client(clp); |
756 | } | 756 | } |
757 | 757 | ||