diff options
author | David Woodhouse <dwmw2@infradead.org> | 2008-08-17 12:21:18 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2008-10-23 05:13:11 -0400 |
commit | c002a6c7977320f95b5edede5ce4e0eeecf291ff (patch) | |
tree | 9646d953e813251de9bd991ed877f1f1f46af7c4 /fs/nfsd | |
parent | 53c9c5c0e32c69f9df1822e47671c13e3402c82f (diff) |
[PATCH] Optimise NFS readdir hack slightly.
Avoid calling the underlying ->readdir() again when we reached the end
already; keep going round the loop only if we stopped due to our own
buffer being full.
[AV: tidy the things up a bit, while we are there]
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/nfsd')
-rw-r--r-- | fs/nfsd/vfs.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index e3e37f7c8477..49d4b8725ca3 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -1891,7 +1891,6 @@ static int nfsd_buffered_readdir(struct file *file, filldir_t func, | |||
1891 | if (!size) | 1891 | if (!size) |
1892 | break; | 1892 | break; |
1893 | 1893 | ||
1894 | |||
1895 | de = (struct buffered_dirent *)buf.dirent; | 1894 | de = (struct buffered_dirent *)buf.dirent; |
1896 | while (size > 0) { | 1895 | while (size > 0) { |
1897 | offset = de->offset; | 1896 | offset = de->offset; |
@@ -1908,7 +1907,9 @@ static int nfsd_buffered_readdir(struct file *file, filldir_t func, | |||
1908 | size -= reclen; | 1907 | size -= reclen; |
1909 | de = (struct buffered_dirent *)((char *)de + reclen); | 1908 | de = (struct buffered_dirent *)((char *)de + reclen); |
1910 | } | 1909 | } |
1911 | offset = vfs_llseek(file, 0, 1); | 1910 | offset = vfs_llseek(file, 0, SEEK_CUR); |
1911 | if (!buf.full) | ||
1912 | break; | ||
1912 | } | 1913 | } |
1913 | 1914 | ||
1914 | done: | 1915 | done: |