diff options
author | Bernd Schubert <bernd.schubert@itwm.fraunhofer.de> | 2012-03-18 22:44:49 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2012-03-18 22:44:49 -0400 |
commit | 999448a8c0202d8c41711c92385323520644527b (patch) | |
tree | 50dc184cdbb8a695419636511429d1a2b6fc5568 /fs/nfsd | |
parent | d1f5273e9adb40724a85272f248f210dc4ce919a (diff) |
nfsd: rename 'int access' to 'int may_flags' in nfsd_open()
Just rename this variable, as the next patch will add a flag and
'access' as variable name would not be correct any more.
Signed-off-by: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Acked-by: J. Bruce Fields<bfields@redhat.com>
Diffstat (limited to 'fs/nfsd')
-rw-r--r-- | fs/nfsd/vfs.c | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index edf6d3ed8777..a6db4cb874d5 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -737,12 +737,13 @@ static int nfsd_open_break_lease(struct inode *inode, int access) | |||
737 | 737 | ||
738 | /* | 738 | /* |
739 | * Open an existing file or directory. | 739 | * Open an existing file or directory. |
740 | * The access argument indicates the type of open (read/write/lock) | 740 | * The may_flags argument indicates the type of open (read/write/lock) |
741 | * and additional flags. | ||
741 | * N.B. After this call fhp needs an fh_put | 742 | * N.B. After this call fhp needs an fh_put |
742 | */ | 743 | */ |
743 | __be32 | 744 | __be32 |
744 | nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, | 745 | nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, |
745 | int access, struct file **filp) | 746 | int may_flags, struct file **filp) |
746 | { | 747 | { |
747 | struct dentry *dentry; | 748 | struct dentry *dentry; |
748 | struct inode *inode; | 749 | struct inode *inode; |
@@ -757,7 +758,7 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, | |||
757 | * and (hopefully) checked permission - so allow OWNER_OVERRIDE | 758 | * and (hopefully) checked permission - so allow OWNER_OVERRIDE |
758 | * in case a chmod has now revoked permission. | 759 | * in case a chmod has now revoked permission. |
759 | */ | 760 | */ |
760 | err = fh_verify(rqstp, fhp, type, access | NFSD_MAY_OWNER_OVERRIDE); | 761 | err = fh_verify(rqstp, fhp, type, may_flags | NFSD_MAY_OWNER_OVERRIDE); |
761 | if (err) | 762 | if (err) |
762 | goto out; | 763 | goto out; |
763 | 764 | ||
@@ -768,7 +769,7 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, | |||
768 | * or any access when mandatory locking enabled | 769 | * or any access when mandatory locking enabled |
769 | */ | 770 | */ |
770 | err = nfserr_perm; | 771 | err = nfserr_perm; |
771 | if (IS_APPEND(inode) && (access & NFSD_MAY_WRITE)) | 772 | if (IS_APPEND(inode) && (may_flags & NFSD_MAY_WRITE)) |
772 | goto out; | 773 | goto out; |
773 | /* | 774 | /* |
774 | * We must ignore files (but only files) which might have mandatory | 775 | * We must ignore files (but only files) which might have mandatory |
@@ -781,12 +782,12 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, | |||
781 | if (!inode->i_fop) | 782 | if (!inode->i_fop) |
782 | goto out; | 783 | goto out; |
783 | 784 | ||
784 | host_err = nfsd_open_break_lease(inode, access); | 785 | host_err = nfsd_open_break_lease(inode, may_flags); |
785 | if (host_err) /* NOMEM or WOULDBLOCK */ | 786 | if (host_err) /* NOMEM or WOULDBLOCK */ |
786 | goto out_nfserr; | 787 | goto out_nfserr; |
787 | 788 | ||
788 | if (access & NFSD_MAY_WRITE) { | 789 | if (may_flags & NFSD_MAY_WRITE) { |
789 | if (access & NFSD_MAY_READ) | 790 | if (may_flags & NFSD_MAY_READ) |
790 | flags = O_RDWR|O_LARGEFILE; | 791 | flags = O_RDWR|O_LARGEFILE; |
791 | else | 792 | else |
792 | flags = O_WRONLY|O_LARGEFILE; | 793 | flags = O_WRONLY|O_LARGEFILE; |
@@ -796,7 +797,8 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, umode_t type, | |||
796 | if (IS_ERR(*filp)) | 797 | if (IS_ERR(*filp)) |
797 | host_err = PTR_ERR(*filp); | 798 | host_err = PTR_ERR(*filp); |
798 | else | 799 | else |
799 | host_err = ima_file_check(*filp, access); | 800 | host_err = ima_file_check(*filp, may_flags); |
801 | |||
800 | out_nfserr: | 802 | out_nfserr: |
801 | err = nfserrno(host_err); | 803 | err = nfserrno(host_err); |
802 | out: | 804 | out: |