diff options
author | J.Bruce Fields <bfields@fieldses.org> | 2006-12-13 03:35:20 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-13 12:05:53 -0500 |
commit | e57101991156aaba97c630f38e880f0d4012edcd (patch) | |
tree | 5d0a405f254e8e17663746abdc9e5a75428ecc1f /fs/nfsd/nfs4proc.c | |
parent | b797b5beac966df5c5d96c0d39fe366f57135343 (diff) |
[PATCH] knfsd: nfsd4: clarify units of COMPOUND_SLACK_SPACE
A comment here incorrectly states that "slack_space" is measured in words, not
bytes. Remove the comment, and adjust a variable name and a few comments to
clarify the situation.
This is pure cleanup; there should be no change in functionality.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/nfsd/nfs4proc.c')
-rw-r--r-- | fs/nfsd/nfs4proc.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 50bc94243ca1..793a0b0a6cdd 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c | |||
@@ -740,7 +740,7 @@ nfsd4_proc_compound(struct svc_rqst *rqstp, | |||
740 | struct svc_fh *current_fh = NULL; | 740 | struct svc_fh *current_fh = NULL; |
741 | struct svc_fh *save_fh = NULL; | 741 | struct svc_fh *save_fh = NULL; |
742 | struct nfs4_stateowner *replay_owner = NULL; | 742 | struct nfs4_stateowner *replay_owner = NULL; |
743 | int slack_space; /* in words, not bytes! */ | 743 | int slack_bytes; |
744 | __be32 status; | 744 | __be32 status; |
745 | 745 | ||
746 | status = nfserr_resource; | 746 | status = nfserr_resource; |
@@ -790,10 +790,10 @@ nfsd4_proc_compound(struct svc_rqst *rqstp, | |||
790 | * failed response to the next operation. If we don't | 790 | * failed response to the next operation. If we don't |
791 | * have enough room, fail with ERR_RESOURCE. | 791 | * have enough room, fail with ERR_RESOURCE. |
792 | */ | 792 | */ |
793 | /* FIXME - is slack_space *really* words, or bytes??? - neilb */ | 793 | slack_bytes = (char *)resp->end - (char *)resp->p; |
794 | slack_space = (char *)resp->end - (char *)resp->p; | 794 | if (slack_bytes < COMPOUND_SLACK_SPACE |
795 | if (slack_space < COMPOUND_SLACK_SPACE + COMPOUND_ERR_SLACK_SPACE) { | 795 | + COMPOUND_ERR_SLACK_SPACE) { |
796 | BUG_ON(slack_space < COMPOUND_ERR_SLACK_SPACE); | 796 | BUG_ON(slack_bytes < COMPOUND_ERR_SLACK_SPACE); |
797 | op->status = nfserr_resource; | 797 | op->status = nfserr_resource; |
798 | goto encode_op; | 798 | goto encode_op; |
799 | } | 799 | } |