litmus-rt.git - The LITMUS^RT kernel.

diff options

author	Denis V. Lunev <den@openvz.org>	2008-08-11 04:02:34 -0400
committer	Trond Myklebust <Trond.Myklebust@netapp.com>	2008-10-07 18:15:16 -0400
commit	44d5759d3fdad660f000ef319f0ec33a6ac6ae28 (patch)
tree	2d6508f919c21a3f25254567d88606438f339c38 /fs/nfs
parent	c9f6cde6e26ef98ee9c4b6288b126ac9c580d88b (diff)

nfs: BUG_ON in nfs_follow_mountpoint

Unfortunately, BUG_ON(IS_ROOT(dentry)) can happen inside nfs_follow_mountpoint with NFS running Fedora 8 using a specific setup. https://bugzilla.redhat.com/show_bug.cgi?id=458622 So, the situation should be handled on NFS client gracefully. Signed-off-by: Denis V. Lunev <den@openvz.org> CC: Trond Myklebust <Trond.Myklebust@netapp.com> CC: J. Bruce Fields <bfields@fieldses.org> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

Diffstat (limited to 'fs/nfs')

-rw-r--r--

fs/nfs/namespace.c

1 files changed, 4 insertions, 1 deletions


diff --git a/fs/nfs/namespace.c b/fs/nfs/namespace.c index d398775a3af5..64a288ee046d 100644 --- a/fs/nfs/namespace.c +++ b/fs/nfs/namespace.c
@@ -105,7 +105,10 @@ static void * nfs_follow_mountpoint(struct dentry dentry, struct nameidata nd)
105		105
106	dprintk("--> nfs_follow_mountpoint()\n");	106	dprintk("--> nfs_follow_mountpoint()\n");
107		107
108	BUG_ON(IS_ROOT(dentry));	108	err = -ESTALE;
		109	if (IS_ROOT(dentry))
		110	goto out_err;
		111
109	dprintk("%s: enter\n", __func__);	112	dprintk("%s: enter\n", __func__);
110	dput(nd->path.dentry);	113	dput(nd->path.dentry);
111	nd->path.dentry = dget(dentry);	114	nd->path.dentry = dget(dentry);

/* * AGPGART module version 0.99 * Copyright (C) 1999 Jeff Hartmann * Copyright (C) 1999 Precision Insight, Inc. * Copyright (C) 1999 Xi Graphics, Inc. * * Permission is hereby granted, free of charge, to any person obtaining a * copy of this software and associated documentation files (the "Software"), * to deal in the Software without restriction, including without limitation * the rights to use, copy, modify, merge, publish, distribute, sublicense, * and/or sell copies of the Software, and to permit persons to whom the * Software is furnished to do so, subject to the following conditions: * * The above copyright notice and this permission notice shall be included * in all copies or substantial portions of the Software. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL * JEFF HARTMANN, OR ANY OTHER CONTRIBUTORS BE LIABLE FOR ANY CLAIM, * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE * OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. * */ #ifndef _AGP_H #define _AGP_H 1 #define AGPIOC_BASE 'A' #define AGPIOC_INFO _IOR (AGPIOC_BASE, 0, struct agp_info*) #define AGPIOC_ACQUIRE _IO (AGPIOC_BASE, 1) #define AGPIOC_RELEASE _IO (AGPIOC_BASE, 2) #define AGPIOC_SETUP _IOW (AGPIOC_BASE, 3, struct agp_setup*) #define AGPIOC_RESERVE _IOW (AGPIOC_BASE, 4, struct agp_region*) #define AGPIOC_PROTECT _IOW (AGPIOC_BASE, 5, struct agp_region*) #define AGPIOC_ALLOCATE _IOWR(AGPIOC_BASE, 6, struct agp_allocate*) #define AGPIOC_DEALLOCATE _IOW (AGPIOC_BASE, 7, int) #define AGPIOC_BIND _IOW (AGPIOC_BASE, 8, struct agp_bind*) #define AGPIOC_UNBIND _IOW (AGPIOC_BASE, 9, struct agp_unbind*) #define AGP_DEVICE "/dev/agpgart" #ifndef TRUE #define TRUE 1 #endif #ifndef FALSE #define FALSE 0 #endif #ifndef __KERNEL__ #include <linux/types.h> #include <asm/types.h> struct agp_version { __u16 major; __u16 minor; }; typedef struct _agp_info { struct agp_version version; /* version of the driver */ __u32 bridge_id; /* bridge vendor/device */ __u32 agp_mode; /* mode info of bridge */ unsigned long aper_base;/* base of aperture */ size_t aper_size; /* size of aperture */ size_t pg_total; /* max pages (swap + system) */ size_t pg_system; /* max pages (system) */ size_t pg_used; /* current pages used */ } agp_info; typedef struct _agp_setup { __u32 agp_mode; /* mode info of bridge */ } agp_setup; /* * The "prot" down below needs still a "sleep" flag somehow ... */ typedef struct _agp_segment { off_t pg_start; /* starting page to populate */ size_t pg_count; /* number of pages */ int prot; /* prot flags for mmap */ } agp_segment; typedef struct _agp_region { pid_t pid; /* pid of process */ size_t seg_count; /* number of segments */ struct _agp_segment *seg_list; } agp_region; typedef struct _agp_allocate { int key; /* tag of allocation */ size_t pg_count; /* number of pages */ __u32 type; /* 0 == normal, other devspec */ __u32 physical; /* device specific (some devices * need a phys address of the * actual page behind the gatt * table) */ } agp_allocate; typedef struct _agp_bind { int key; /* tag of allocation */ off_t pg_start; /* starting page to populate */ } agp_bind; typedef struct _agp_unbind { int key; /* tag of allocation */ __u32 priority; /* priority for paging out */ } agp_unbind; #else /* __KERNEL__ */ #include <linux/mutex.h> #include <linux/agp_backend.h> #define AGPGART_MINOR 175 struct agp_info { struct agp_version version; /* version of the driver */ u32 bridge_id; /* bridge vendor/device */ u32 agp_mode; /* mode info of bridge */ unsigned long aper_base;/* base of aperture */ size_t aper_size; /* size of aperture */ size_t pg_total; /* max pages (swap + system) */ size_t pg_system; /* max pages (system) */ size_t pg_used; /* current pages used */ }; struct agp_setup { u32 agp_mode; /* mode info of bridge */ }; /* * The "prot" down below needs still a "sleep" flag somehow ... */ struct agp_segment { off_t pg_start; /* starting page to populate */ size_t pg_count; /* number of pages */ int prot; /* prot flags for mmap */ }; struct agp_segment_priv { off_t pg_start; size_t pg_count; pgprot_t prot; }; struct agp_region { pid_t pid; /* pid of process */ size_t seg_count; /* number of segments */ struct agp_segment *seg_list; }; struct agp_allocate { int key; /* tag of allocation */ size_t pg_count; /* number of pages */ u32 type; /* 0 == normal, other devspec */ u32 physical; /* device specific (some devices * need a phys address of the * actual page behind the gatt * table) */ }; struct agp_bind { int key; /* tag of allocation */ off_t pg_start; /* starting page to populate */ }; struct agp_unbind { int key; /* tag of allocation */ u32 priority; /* priority for paging out */ }; struct agp_client { struct agp_client *next; struct agp_client *prev; pid_t pid; int num_segments; struct agp_segment_priv **segments; }; struct agp_controller { struct agp_controller *next; struct agp_controller *prev; pid_t pid; int num_clients; struct agp_memory *pool; struct agp_client *clients; }; #define AGP_FF_ALLOW_CLIENT 0 #define AGP_FF_ALLOW_CONTROLLER 1 #define AGP_FF_IS_CLIENT 2 #define AGP_FF_IS_CONTROLLER 3 #define AGP_FF_IS_VALID 4 struct agp_file_private { struct agp_file_private *next; struct agp_file_private *prev; pid_t my_pid; long access_flags; /* long req'd for set_bit --RR */ }; struct agp_front_data { struct mutex agp_mutex; struct agp_controller *current_controller; struct agp_controller *controllers; struct agp_file_private *file_priv_list; u8 used_by_controller; u8 backend_acquired; }; #endif /* __KERNEL__ */ #endif /* _AGP_H */


context:
space:
mode: