diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2010-06-16 09:52:27 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2010-06-22 13:24:03 -0400 |
commit | fe74ba3a8db003410e48863a5cafa6ac90674540 (patch) | |
tree | 8a3014b14a3c48d997ac08a378128e8b4202b00d /fs/nfs | |
parent | d77d76ffb638bd013782138cca6d8f4918c5afd6 (diff) |
NFSv41: Cleanup for nfs4_alloc_session.
There is no reason to change the nfs_client state every time we allocate a
new session. Move that line into nfs4_init_client_minor_version.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/nfs')
-rw-r--r-- | fs/nfs/client.c | 7 | ||||
-rw-r--r-- | fs/nfs/nfs4proc.c | 7 |
2 files changed, 7 insertions, 7 deletions
diff --git a/fs/nfs/client.c b/fs/nfs/client.c index 1df708fd4205..4e7df2adb212 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c | |||
@@ -1157,6 +1157,13 @@ static int nfs4_init_client_minor_version(struct nfs_client *clp) | |||
1157 | return -ENOMEM; | 1157 | return -ENOMEM; |
1158 | 1158 | ||
1159 | clp->cl_session = session; | 1159 | clp->cl_session = session; |
1160 | /* | ||
1161 | * The create session reply races with the server back | ||
1162 | * channel probe. Mark the client NFS_CS_SESSION_INITING | ||
1163 | * so that the client back channel can find the | ||
1164 | * nfs_client struct | ||
1165 | */ | ||
1166 | clp->cl_cons_state = NFS_CS_SESSION_INITING; | ||
1160 | } | 1167 | } |
1161 | #endif /* CONFIG_NFS_V4_1 */ | 1168 | #endif /* CONFIG_NFS_V4_1 */ |
1162 | 1169 | ||
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 5d87563d0c1a..b4132fe14282 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c | |||
@@ -4795,13 +4795,6 @@ struct nfs4_session *nfs4_alloc_session(struct nfs_client *clp) | |||
4795 | if (!session) | 4795 | if (!session) |
4796 | return NULL; | 4796 | return NULL; |
4797 | 4797 | ||
4798 | /* | ||
4799 | * The create session reply races with the server back | ||
4800 | * channel probe. Mark the client NFS_CS_SESSION_INITING | ||
4801 | * so that the client back channel can find the | ||
4802 | * nfs_client struct | ||
4803 | */ | ||
4804 | clp->cl_cons_state = NFS_CS_SESSION_INITING; | ||
4805 | init_completion(&session->complete); | 4798 | init_completion(&session->complete); |
4806 | 4799 | ||
4807 | tbl = &session->fc_slot_table; | 4800 | tbl = &session->fc_slot_table; |