diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2006-10-20 02:28:42 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-20 13:26:39 -0400 |
| commit | b87c0adfeaaf8d8310c4f790d76072a5961b3518 (patch) | |
| tree | 1c3f2395436f6ec3c8abc94af8266709860b0839 /fs/nfs | |
| parent | 85233a7a436a48a0b98e7976a66797e5da79c9d6 (diff) | |
[PATCH] NFS: remove unused check in nfs4_open_revalidate
Coverity spotted a superfluous error check in nfs4_open_revalidate(). Remove
it.
Coverity: #cid 847
Test plan:
Code inspection; another pass through Coverity.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/nfs')
| -rw-r--r-- | fs/nfs/nfs4proc.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 47c7e6e3910d..7421bcb3b728 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c | |||
| @@ -1314,11 +1314,9 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st | |||
| 1314 | case -EROFS: | 1314 | case -EROFS: |
| 1315 | lookup_instantiate_filp(nd, (struct dentry *)state, NULL); | 1315 | lookup_instantiate_filp(nd, (struct dentry *)state, NULL); |
| 1316 | return 1; | 1316 | return 1; |
| 1317 | case -ENOENT: | 1317 | default: |
| 1318 | if (dentry->d_inode == NULL) | 1318 | goto out_drop; |
| 1319 | return 1; | ||
| 1320 | } | 1319 | } |
| 1321 | goto out_drop; | ||
| 1322 | } | 1320 | } |
| 1323 | if (state->inode == dentry->d_inode) { | 1321 | if (state->inode == dentry->d_inode) { |
| 1324 | nfs4_intent_set_file(nd, dentry, state); | 1322 | nfs4_intent_set_file(nd, dentry, state); |