diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2006-09-27 04:49:40 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 11:26:10 -0400 |
commit | 1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b (patch) | |
tree | fade83955f75e718e39153d6f81d221403338bed /fs/nfs | |
parent | f52720ca5f48574e347dff35ffe6b389ace61537 (diff) |
[PATCH] Really ignore kmem_cache_destroy return value
* Rougly half of callers already do it by not checking return value
* Code in drivers/acpi/osl.c does the following to be sure:
(void)kmem_cache_destroy(cache);
* Those who check it printk something, however, slab_error already printed
the name of failed cache.
* XFS BUGs on failed kmem_cache_destroy which is not the decision
low-level filesystem driver should make. Converted to ignore.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/nfs')
-rw-r--r-- | fs/nfs/direct.c | 3 | ||||
-rw-r--r-- | fs/nfs/inode.c | 3 | ||||
-rw-r--r-- | fs/nfs/pagelist.c | 3 | ||||
-rw-r--r-- | fs/nfs/read.c | 3 | ||||
-rw-r--r-- | fs/nfs/write.c | 3 |
5 files changed, 5 insertions, 10 deletions
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index 76ca1cbc38f9..377839bed172 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c | |||
@@ -855,6 +855,5 @@ int __init nfs_init_directcache(void) | |||
855 | */ | 855 | */ |
856 | void nfs_destroy_directcache(void) | 856 | void nfs_destroy_directcache(void) |
857 | { | 857 | { |
858 | if (kmem_cache_destroy(nfs_direct_cachep)) | 858 | kmem_cache_destroy(nfs_direct_cachep); |
859 | printk(KERN_INFO "nfs_direct_cache: not all structures were freed\n"); | ||
860 | } | 859 | } |
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index a9d0f71eb5f7..931f52a19579 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c | |||
@@ -1134,8 +1134,7 @@ static int __init nfs_init_inodecache(void) | |||
1134 | 1134 | ||
1135 | static void nfs_destroy_inodecache(void) | 1135 | static void nfs_destroy_inodecache(void) |
1136 | { | 1136 | { |
1137 | if (kmem_cache_destroy(nfs_inode_cachep)) | 1137 | kmem_cache_destroy(nfs_inode_cachep); |
1138 | printk(KERN_INFO "nfs_inode_cache: not all structures were freed\n"); | ||
1139 | } | 1138 | } |
1140 | 1139 | ||
1141 | /* | 1140 | /* |
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c index 36e902a88ca1..829af323f288 100644 --- a/fs/nfs/pagelist.c +++ b/fs/nfs/pagelist.c | |||
@@ -392,7 +392,6 @@ int __init nfs_init_nfspagecache(void) | |||
392 | 392 | ||
393 | void nfs_destroy_nfspagecache(void) | 393 | void nfs_destroy_nfspagecache(void) |
394 | { | 394 | { |
395 | if (kmem_cache_destroy(nfs_page_cachep)) | 395 | kmem_cache_destroy(nfs_page_cachep); |
396 | printk(KERN_INFO "nfs_page: not all structures were freed\n"); | ||
397 | } | 396 | } |
398 | 397 | ||
diff --git a/fs/nfs/read.c b/fs/nfs/read.c index 69f1549da2b9..c2e49c397a27 100644 --- a/fs/nfs/read.c +++ b/fs/nfs/read.c | |||
@@ -737,6 +737,5 @@ int __init nfs_init_readpagecache(void) | |||
737 | void nfs_destroy_readpagecache(void) | 737 | void nfs_destroy_readpagecache(void) |
738 | { | 738 | { |
739 | mempool_destroy(nfs_rdata_mempool); | 739 | mempool_destroy(nfs_rdata_mempool); |
740 | if (kmem_cache_destroy(nfs_rdata_cachep)) | 740 | kmem_cache_destroy(nfs_rdata_cachep); |
741 | printk(KERN_INFO "nfs_read_data: not all structures were freed\n"); | ||
742 | } | 741 | } |
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index c12effb46fe5..b674462793d3 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c | |||
@@ -1565,7 +1565,6 @@ void nfs_destroy_writepagecache(void) | |||
1565 | { | 1565 | { |
1566 | mempool_destroy(nfs_commit_mempool); | 1566 | mempool_destroy(nfs_commit_mempool); |
1567 | mempool_destroy(nfs_wdata_mempool); | 1567 | mempool_destroy(nfs_wdata_mempool); |
1568 | if (kmem_cache_destroy(nfs_wdata_cachep)) | 1568 | kmem_cache_destroy(nfs_wdata_cachep); |
1569 | printk(KERN_INFO "nfs_write_data: not all structures were freed\n"); | ||
1570 | } | 1569 | } |
1571 | 1570 | ||