diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2007-02-02 17:46:09 -0500 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2007-02-03 18:35:03 -0500 |
commit | f2d0d85e58099d518cb50b1c95fc1fc62bbce1b8 (patch) | |
tree | b8b14f9f4d803b90c2d8a96faef082f1b6e257be /fs/nfs | |
parent | 2efef837fb84f78cee7439804cb3722bffc64e75 (diff) |
NFSv4: Fix Oops in nfs4_create_referral_server
The filehandle that is passed into nfs4_create_referral_server is
not initialised. The expectation is that nfs4_create_referral_server will
initialise it, and return it to the caller.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/nfs')
-rw-r--r-- | fs/nfs/client.c | 9 | ||||
-rw-r--r-- | fs/nfs/super.c | 2 |
2 files changed, 8 insertions, 3 deletions
diff --git a/fs/nfs/client.c b/fs/nfs/client.c index 23ab145daa2d..a3191f023490 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c | |||
@@ -1030,7 +1030,7 @@ error: | |||
1030 | * Create an NFS4 referral server record | 1030 | * Create an NFS4 referral server record |
1031 | */ | 1031 | */ |
1032 | struct nfs_server *nfs4_create_referral_server(struct nfs_clone_mount *data, | 1032 | struct nfs_server *nfs4_create_referral_server(struct nfs_clone_mount *data, |
1033 | struct nfs_fh *fh) | 1033 | struct nfs_fh *mntfh) |
1034 | { | 1034 | { |
1035 | struct nfs_client *parent_client; | 1035 | struct nfs_client *parent_client; |
1036 | struct nfs_server *server, *parent_server; | 1036 | struct nfs_server *server, *parent_server; |
@@ -1069,8 +1069,13 @@ struct nfs_server *nfs4_create_referral_server(struct nfs_clone_mount *data, | |||
1069 | BUG_ON(!server->nfs_client->rpc_ops); | 1069 | BUG_ON(!server->nfs_client->rpc_ops); |
1070 | BUG_ON(!server->nfs_client->rpc_ops->file_inode_ops); | 1070 | BUG_ON(!server->nfs_client->rpc_ops->file_inode_ops); |
1071 | 1071 | ||
1072 | /* Probe the root fh to retrieve its FSID and filehandle */ | ||
1073 | error = nfs4_path_walk(server, mntfh, data->mnt_path); | ||
1074 | if (error < 0) | ||
1075 | goto error; | ||
1076 | |||
1072 | /* probe the filesystem info for this server filesystem */ | 1077 | /* probe the filesystem info for this server filesystem */ |
1073 | error = nfs_probe_fsinfo(server, fh, &fattr); | 1078 | error = nfs_probe_fsinfo(server, mntfh, &fattr); |
1074 | if (error < 0) | 1079 | if (error < 0) |
1075 | goto error; | 1080 | goto error; |
1076 | 1081 | ||
diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 28108c82b887..89da0a38c12c 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c | |||
@@ -1044,7 +1044,7 @@ static int nfs4_referral_get_sb(struct file_system_type *fs_type, int flags, | |||
1044 | nfs4_fill_super(s); | 1044 | nfs4_fill_super(s); |
1045 | } | 1045 | } |
1046 | 1046 | ||
1047 | mntroot = nfs4_get_root(s, data->fh); | 1047 | mntroot = nfs4_get_root(s, &mntfh); |
1048 | if (IS_ERR(mntroot)) { | 1048 | if (IS_ERR(mntroot)) { |
1049 | error = PTR_ERR(mntroot); | 1049 | error = PTR_ERR(mntroot); |
1050 | goto error_splat_super; | 1050 | goto error_splat_super; |