diff options
author | Benny Halevy <benny@tonian.com> | 2011-06-15 11:39:57 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2011-06-15 11:52:15 -0400 |
commit | 1ed3a8539af7b36aa5c977f304e80f7fc8d27bfc (patch) | |
tree | 2e4f96dccc79f57a9afb0cd0bc89add38d311d94 /fs/nfs/pnfs.c | |
parent | c7fd06228b994190d8369a2a0acf5224e4e13d1a (diff) |
NFSv4.1: need to put_layout_hdr on _pnfs_return_layout error path
We always get a reference on the layout header and we rely on
nfs4_layoutreturn_release to put it. If we hit an allocation error
before starting the rpc proc we bail out early without dereferncing
the layout header properly.
Signed-off-by: Benny Halevy <benny@tonian.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/nfs/pnfs.c')
-rw-r--r-- | fs/nfs/pnfs.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c index d066aad608ad..8f9582281252 100644 --- a/fs/nfs/pnfs.c +++ b/fs/nfs/pnfs.c | |||
@@ -652,6 +652,7 @@ _pnfs_return_layout(struct inode *ino) | |||
652 | lrp = kzalloc(sizeof(*lrp), GFP_KERNEL); | 652 | lrp = kzalloc(sizeof(*lrp), GFP_KERNEL); |
653 | if (unlikely(lrp == NULL)) { | 653 | if (unlikely(lrp == NULL)) { |
654 | status = -ENOMEM; | 654 | status = -ENOMEM; |
655 | put_layout_hdr(lo); | ||
655 | goto out; | 656 | goto out; |
656 | } | 657 | } |
657 | 658 | ||