NFS: Switch from intr mount option to TASK_KILLABLE

By using the TASK_KILLABLE infrastructure, we can get rid of the 'intr'
mount option.  We have to use _killable everywhere instead of _interruptible
as we get rid of rpc_clnt_sigmask/sigunmask.

Signed-off-by: Liam R. Howlett <howlett@gmail.com>
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>

1 files changed, 5 insertions, 13 deletions

diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index 345bb9b4765b..2dff469f04fe 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -67,7 +67,7 @@ nfs_create_request(struct nfs_open_context *ctx, struct inode *inode,
                 if (req != NULL)
                         break;
 
-                if (signalled() && (server->flags & NFS_MOUNT_INTR))
+                if (fatal_signal_pending(current))
                         return ERR_PTR(-ERESTARTSYS);
                 yield();
         }
@@ -175,11 +175,11 @@ void nfs_release_request(struct nfs_page *req)
         kref_put(&req->wb_kref, nfs_free_request);
 }
 
-static int nfs_wait_bit_interruptible(void *word)
+static int nfs_wait_bit_killable(void *word)
 {
         int ret = 0;
 
-        if (signal_pending(current))
+        if (fatal_signal_pending(current))
                 ret = -ERESTARTSYS;
         else
                 schedule();
@@ -190,26 +190,18 @@ static int nfs_wait_bit_interruptible(void *word)
  * nfs_wait_on_request - Wait for a request to complete.
  * @req: request to wait upon.
  *
- * Interruptible by signals only if mounted with intr flag.
+ * Interruptible by fatal signals only.
  * The user is responsible for holding a count on the request.
  */
 int
 nfs_wait_on_request(struct nfs_page *req)
 {
-        struct rpc_clnt *clnt = NFS_CLIENT(req->wb_context->path.dentry->d_inode);
-        sigset_t oldmask;
         int ret = 0;
 
         if (!test_bit(PG_BUSY, &req->wb_flags))
                 goto out;
-        /*
-         * Note: the call to rpc_clnt_sigmask() suffices to ensure that we
-         *       are not interrupted if intr flag is not set
-         */
-        rpc_clnt_sigmask(clnt, &oldmask);
         ret = out_of_line_wait_on_bit(&req->wb_flags, PG_BUSY,
-                        nfs_wait_bit_interruptible, TASK_INTERRUPTIBLE);
-        rpc_clnt_sigunmask(clnt, &oldmask);
+                        nfs_wait_bit_killable, TASK_KILLABLE);
 out:
         return ret;
 }