NFSv4: Fix a bug in __nfs4_find_state_byowner

The test for state->state == 0 does not tell you that the stateid is in the
process of being freed. It really tells you that the stateid is not yet
initialised...

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

1 files changed, 2 insertions, 5 deletions

diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index ab0b5ab60e60..ac816b303f3a 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -333,13 +333,10 @@ __nfs4_find_state_byowner(struct inode *inode, struct nfs4_state_owner *owner)
         struct nfs4_state *state;
 
         list_for_each_entry(state, &nfsi->open_states, inode_states) {
-                /* Is this in the process of being freed? */
-                if (state->state == 0)
+                if (state->owner != owner)
                         continue;
-                if (state->owner == owner) {
-                        atomic_inc(&state->count);
+                if (atomic_inc_not_zero(&state->count))
                         return state;
-                }
         }
         return NULL;
 }