aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfs/nfs4proc.c
diff options
context:
space:
mode:
authorTrond Myklebust <Trond.Myklebust@netapp.com>2008-02-19 20:04:23 -0500
committerTrond Myklebust <Trond.Myklebust@netapp.com>2008-02-26 00:40:37 -0500
commit101070ca2fe67186f5f5517b66cb4757b17f4e29 (patch)
treeb131c97e3033fc4c848e8cb3d76f675735b95085 /fs/nfs/nfs4proc.c
parent5746006f1d17d9d5a3015051ea54de4341cb31f9 (diff)
NFS: Ensure that the asynchronous RPC calls complete on nfsiod.
We want to ensure that rpc_call_ops that involve mntput() are run on nfsiod rather than on rpciod, so that they don't deadlock when the resulting umount calls rpc_shutdown_client(). Hence we specify that read, write and commit calls must complete on nfsiod. Ditto for NFSv4 open, lock, locku and close asynchronous calls. Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/nfs/nfs4proc.c')
-rw-r--r--fs/nfs/nfs4proc.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 7ce07862c2fb..b6db833f33e6 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -51,6 +51,7 @@
51 51
52#include "nfs4_fs.h" 52#include "nfs4_fs.h"
53#include "delegation.h" 53#include "delegation.h"
54#include "internal.h"
54#include "iostat.h" 55#include "iostat.h"
55 56
56#define NFSDBG_FACILITY NFSDBG_PROC 57#define NFSDBG_FACILITY NFSDBG_PROC
@@ -773,6 +774,7 @@ static int _nfs4_proc_open_confirm(struct nfs4_opendata *data)
773 .rpc_message = &msg, 774 .rpc_message = &msg,
774 .callback_ops = &nfs4_open_confirm_ops, 775 .callback_ops = &nfs4_open_confirm_ops,
775 .callback_data = data, 776 .callback_data = data,
777 .workqueue = nfsiod_workqueue,
776 .flags = RPC_TASK_ASYNC, 778 .flags = RPC_TASK_ASYNC,
777 }; 779 };
778 int status; 780 int status;
@@ -910,6 +912,7 @@ static int _nfs4_proc_open(struct nfs4_opendata *data)
910 .rpc_message = &msg, 912 .rpc_message = &msg,
911 .callback_ops = &nfs4_open_ops, 913 .callback_ops = &nfs4_open_ops,
912 .callback_data = data, 914 .callback_data = data,
915 .workqueue = nfsiod_workqueue,
913 .flags = RPC_TASK_ASYNC, 916 .flags = RPC_TASK_ASYNC,
914 }; 917 };
915 int status; 918 int status;
@@ -1315,6 +1318,7 @@ int nfs4_do_close(struct path *path, struct nfs4_state *state, int wait)
1315 .rpc_client = server->client, 1318 .rpc_client = server->client,
1316 .rpc_message = &msg, 1319 .rpc_message = &msg,
1317 .callback_ops = &nfs4_close_ops, 1320 .callback_ops = &nfs4_close_ops,
1321 .workqueue = nfsiod_workqueue,
1318 .flags = RPC_TASK_ASYNC, 1322 .flags = RPC_TASK_ASYNC,
1319 }; 1323 };
1320 int status = -ENOMEM; 1324 int status = -ENOMEM;
@@ -3235,6 +3239,7 @@ static struct rpc_task *nfs4_do_unlck(struct file_lock *fl,
3235 .rpc_client = NFS_CLIENT(lsp->ls_state->inode), 3239 .rpc_client = NFS_CLIENT(lsp->ls_state->inode),
3236 .rpc_message = &msg, 3240 .rpc_message = &msg,
3237 .callback_ops = &nfs4_locku_ops, 3241 .callback_ops = &nfs4_locku_ops,
3242 .workqueue = nfsiod_workqueue,
3238 .flags = RPC_TASK_ASYNC, 3243 .flags = RPC_TASK_ASYNC,
3239 }; 3244 };
3240 3245
@@ -3419,6 +3424,7 @@ static int _nfs4_do_setlk(struct nfs4_state *state, int cmd, struct file_lock *f
3419 .rpc_client = NFS_CLIENT(state->inode), 3424 .rpc_client = NFS_CLIENT(state->inode),
3420 .rpc_message = &msg, 3425 .rpc_message = &msg,
3421 .callback_ops = &nfs4_lock_ops, 3426 .callback_ops = &nfs4_lock_ops,
3427 .workqueue = nfsiod_workqueue,
3422 .flags = RPC_TASK_ASYNC, 3428 .flags = RPC_TASK_ASYNC,
3423 }; 3429 };
3424 int ret; 3430 int ret;