NFSv4.1: Fix session initialisation races

Session initialisation is not complete until the lease manager
has run. We need to ensure that both nfs4_init_session and
nfs4_init_ds_session do so, and that they check for any resulting
errors in clp->cl_cons_state.

Only after this is done, can nfs4_ds_connect check the contents
of clp->cl_exchange_flags.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Andy Adamson <andros@netapp.com>

1 files changed, 1 insertions, 22 deletions

diff --git a/fs/nfs/nfs4filelayoutdev.c b/fs/nfs/nfs4filelayoutdev.c
index c610f84ff030..a1fab8da7f03 100644
--- a/fs/nfs/nfs4filelayoutdev.c
+++ b/fs/nfs/nfs4filelayoutdev.c
@@ -203,28 +203,7 @@ nfs4_ds_connect(struct nfs_server *mds_srv, struct nfs4_pnfs_ds *ds)
                 goto out;
         }
 
-        if ((clp->cl_exchange_flags & EXCHGID4_FLAG_MASK_PNFS) != 0) {
-                if (!is_ds_client(clp)) {
-                        status = -ENODEV;
-                        goto out_put;
-                }
-                ds->ds_clp = clp;
-                dprintk("%s [existing] server=%s\n", __func__,
-                        ds->ds_remotestr);
-                goto out;
-        }
-
-        /*
-         * Do not set NFS_CS_CHECK_LEASE_TIME instead set the DS lease to
-         * be equal to the MDS lease. Renewal is scheduled in create_session.
-         */
-        spin_lock(&mds_srv->nfs_client->cl_lock);
-        clp->cl_lease_time = mds_srv->nfs_client->cl_lease_time;
-        spin_unlock(&mds_srv->nfs_client->cl_lock);
-        clp->cl_last_renewal = jiffies;
-
-        /* New nfs_client */
-        status = nfs4_init_ds_session(clp);
+        status = nfs4_init_ds_session(clp, mds_srv->nfs_client->cl_lease_time);
         if (status)
                 goto out_put;