diff options
author | Niels de Vos <ndevos@redhat.com> | 2013-12-17 12:20:16 -0500 |
---|---|---|
committer | Trond Myklebust <trond.myklebust@primarydata.com> | 2014-01-05 15:51:23 -0500 |
commit | 1e8968c5b0582392d5f132422f581e3ebc24e627 (patch) | |
tree | 1fbb842ca0b18d421f1e74b046324e38dbcb58c3 /fs/nfs/nfs4filelayout.c | |
parent | a8c2275493b866961f4429a741251c630c4fc6d7 (diff) |
NFS: dprintk() should not print negative fileids and inode numbers
A fileid in NFS is a uint64. There are some occurrences where dprintk()
outputs a signed fileid. This leads to confusion and more difficult to
read debugging (negative fileids matching positive inode numbers).
Signed-off-by: Niels de Vos <ndevos@redhat.com>
CC: Santosh Pradhan <spradhan@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs/nfs4filelayout.c')
-rw-r--r-- | fs/nfs/nfs4filelayout.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c index b86464ba25e1..0a93e798df3a 100644 --- a/fs/nfs/nfs4filelayout.c +++ b/fs/nfs/nfs4filelayout.c | |||
@@ -91,10 +91,10 @@ static void filelayout_reset_write(struct nfs_write_data *data) | |||
91 | 91 | ||
92 | if (!test_and_set_bit(NFS_IOHDR_REDO, &hdr->flags)) { | 92 | if (!test_and_set_bit(NFS_IOHDR_REDO, &hdr->flags)) { |
93 | dprintk("%s Reset task %5u for i/o through MDS " | 93 | dprintk("%s Reset task %5u for i/o through MDS " |
94 | "(req %s/%lld, %u bytes @ offset %llu)\n", __func__, | 94 | "(req %s/%llu, %u bytes @ offset %llu)\n", __func__, |
95 | data->task.tk_pid, | 95 | data->task.tk_pid, |
96 | hdr->inode->i_sb->s_id, | 96 | hdr->inode->i_sb->s_id, |
97 | (long long)NFS_FILEID(hdr->inode), | 97 | (unsigned long long)NFS_FILEID(hdr->inode), |
98 | data->args.count, | 98 | data->args.count, |
99 | (unsigned long long)data->args.offset); | 99 | (unsigned long long)data->args.offset); |
100 | 100 | ||
@@ -112,10 +112,10 @@ static void filelayout_reset_read(struct nfs_read_data *data) | |||
112 | 112 | ||
113 | if (!test_and_set_bit(NFS_IOHDR_REDO, &hdr->flags)) { | 113 | if (!test_and_set_bit(NFS_IOHDR_REDO, &hdr->flags)) { |
114 | dprintk("%s Reset task %5u for i/o through MDS " | 114 | dprintk("%s Reset task %5u for i/o through MDS " |
115 | "(req %s/%lld, %u bytes @ offset %llu)\n", __func__, | 115 | "(req %s/%llu, %u bytes @ offset %llu)\n", __func__, |
116 | data->task.tk_pid, | 116 | data->task.tk_pid, |
117 | hdr->inode->i_sb->s_id, | 117 | hdr->inode->i_sb->s_id, |
118 | (long long)NFS_FILEID(hdr->inode), | 118 | (unsigned long long)NFS_FILEID(hdr->inode), |
119 | data->args.count, | 119 | data->args.count, |
120 | (unsigned long long)data->args.offset); | 120 | (unsigned long long)data->args.offset); |
121 | 121 | ||