diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2010-01-26 14:04:04 -0500 |
---|---|---|
committer | J. Bruce Fields <bfields@citi.umich.edu> | 2010-01-26 17:56:43 -0500 |
commit | d6783b2b6c4050df0ba0a84c6842cf5bc2212ef9 (patch) | |
tree | d5c5d2ca1be2a53bb6e948da76c2ecd0f74ee27c /fs/nfs/callback.c | |
parent | 205ba42308729f4f41f21d314a4435e7de5c9a2e (diff) |
SUNRPC: Bury "#ifdef IPV6" in svc_create_xprt()
Clean up: Bruce observed we have more or less common logic in each of
svc_create_xprt()'s callers: the check to create an IPv6 RPC listener
socket only if CONFIG_IPV6 is set. I'm about to add another case
that does just the same.
If we move the ifdefs into __svc_xpo_create(), then svc_create_xprt()
call sites can get rid of the "#ifdef" ugliness, and can use the same
logic with or without IPv6 support available in the kernel.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'fs/nfs/callback.c')
-rw-r--r-- | fs/nfs/callback.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c index 73ab220354df..36dfdae95123 100644 --- a/fs/nfs/callback.c +++ b/fs/nfs/callback.c | |||
@@ -118,7 +118,6 @@ nfs4_callback_up(struct svc_serv *serv) | |||
118 | dprintk("NFS: Callback listener port = %u (af %u)\n", | 118 | dprintk("NFS: Callback listener port = %u (af %u)\n", |
119 | nfs_callback_tcpport, PF_INET); | 119 | nfs_callback_tcpport, PF_INET); |
120 | 120 | ||
121 | #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) | ||
122 | ret = svc_create_xprt(serv, "tcp", PF_INET6, | 121 | ret = svc_create_xprt(serv, "tcp", PF_INET6, |
123 | nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS); | 122 | nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS); |
124 | if (ret > 0) { | 123 | if (ret > 0) { |
@@ -129,7 +128,6 @@ nfs4_callback_up(struct svc_serv *serv) | |||
129 | ret = 0; | 128 | ret = 0; |
130 | else | 129 | else |
131 | goto out_err; | 130 | goto out_err; |
132 | #endif /* defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) */ | ||
133 | 131 | ||
134 | return svc_prepare_thread(serv, &serv->sv_pools[0]); | 132 | return svc_prepare_thread(serv, &serv->sv_pools[0]); |
135 | 133 | ||