aboutsummaryrefslogtreecommitdiffstats
path: root/fs/namei.c
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2014-02-17 16:52:33 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2014-08-07 14:40:10 -0400
commitd03b29a271eb1d6de5af0f46cf0e7487e9e9284b (patch)
treec16cc69c2be7b697cc10772979cf3996c4f3a9e4 /fs/namei.c
parentb8faf035ea9d0011b04856a8198e2e212d93346a (diff)
namei: trivial fix to vfs_rename_dir comment
Looks like the directory loop check is actually done in renameat? Whatever, leave this out rather than trying to keep it up to date with the code. Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/namei.c')
-rw-r--r--fs/namei.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/namei.c b/fs/namei.c
index 8a217c48f6db..a996bb48dfab 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -4024,7 +4024,7 @@ SYSCALL_DEFINE2(link, const char __user *, oldname, const char __user *, newname
4024 * The worst of all namespace operations - renaming directory. "Perverted" 4024 * The worst of all namespace operations - renaming directory. "Perverted"
4025 * doesn't even start to describe it. Somebody in UCB had a heck of a trip... 4025 * doesn't even start to describe it. Somebody in UCB had a heck of a trip...
4026 * Problems: 4026 * Problems:
4027 * a) we can get into loop creation. Check is done in is_subdir(). 4027 * a) we can get into loop creation.
4028 * b) race potential - two innocent renames can create a loop together. 4028 * b) race potential - two innocent renames can create a loop together.
4029 * That's where 4.4 screws up. Current fix: serialization on 4029 * That's where 4.4 screws up. Current fix: serialization on
4030 * sb->s_vfs_rename_mutex. We might be more accurate, but that's another 4030 * sb->s_vfs_rename_mutex. We might be more accurate, but that's another