LOCKD: Convert to use new rpc_create() API

Replace xprt_create_proto/rpc_create_client with new rpc_create()
interface in the Network Lock Manager.

Note that the semantics of NLM transports is now "hard" instead of "soft"
to provide a better guarantee that lock requests will get to the server.

Test plan:
Repeated runs of Connectathon locking suite.  Check network trace to ensure
NLM requests are working correctly.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

1 files changed, 17 insertions, 24 deletions

diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
index 3fc683f46b3e..5954dcb497e4 100644
--- a/fs/lockd/mon.c
+++ b/fs/lockd/mon.c
@@ -109,30 +109,23 @@ nsm_unmonitor(struct nlm_host *host)
 static struct rpc_clnt *
 nsm_create(void)
 {
-        struct rpc_xprt         *xprt;
-        struct rpc_clnt         *clnt;
-        struct sockaddr_in      sin;
-
-        sin.sin_family = AF_INET;
-        sin.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
-        sin.sin_port = 0;
-
-        xprt = xprt_create_proto(IPPROTO_UDP, &sin, NULL);
-        if (IS_ERR(xprt))
-                return (struct rpc_clnt *)xprt;
-        xprt->resvport = 1;     /* NSM requires a reserved port */
-
-        clnt = rpc_create_client(xprt, "localhost",
-                                &nsm_program, SM_VERSION,
-                                RPC_AUTH_NULL);
-        if (IS_ERR(clnt))
-                goto out_err;
-        clnt->cl_softrtry = 1;
-        clnt->cl_oneshot  = 1;
-        return clnt;
-
-out_err:
-        return clnt;
+        struct sockaddr_in      sin = {
+                .sin_family     = AF_INET,
+                .sin_addr.s_addr = htonl(INADDR_LOOPBACK),
+                .sin_port       = 0,
+        };
+        struct rpc_create_args args = {
+                .protocol       = IPPROTO_UDP,
+                .address        = (struct sockaddr *)&sin,
+                .addrsize       = sizeof(sin),
+                .servername     = "localhost",
+                .program        = &nsm_program,
+                .version        = SM_VERSION,
+                .authflavor     = RPC_AUTH_NULL,
+                .flags          = (RPC_CLNT_CREATE_ONESHOT),
+        };
+
+        return rpc_create(&args);
 }
 
 /*