aboutsummaryrefslogtreecommitdiffstats
path: root/fs/libfs.c
diff options
context:
space:
mode:
authorBoaz Harrosh <bharrosh@panasas.com>2010-01-12 09:18:08 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2010-03-03 13:00:17 -0500
commit193cf4b99113a4550598ba9e8343e591fc062e23 (patch)
treef71904516c51033fc8c61309ff811f0280a6ac03 /fs/libfs.c
parentad2a722f196d2b014f49e6c37e072df71eb3695f (diff)
libfs: Unexport and kill simple_prepare_write
Remove the EXPORT_UNUSED_SYMBOL of simple_prepare_write Collapse simple_prepare_write into it's only caller, though making it simpler and clearer to understand. Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/libfs.c')
-rw-r--r--fs/libfs.c22
1 files changed, 6 insertions, 16 deletions
diff --git a/fs/libfs.c b/fs/libfs.c
index cd88abdcb436..9e50bcf55857 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -338,28 +338,14 @@ int simple_readpage(struct file *file, struct page *page)
338 return 0; 338 return 0;
339} 339}
340 340
341int simple_prepare_write(struct file *file, struct page *page,
342 unsigned from, unsigned to)
343{
344 if (!PageUptodate(page)) {
345 if (to - from != PAGE_CACHE_SIZE)
346 zero_user_segments(page,
347 0, from,
348 to, PAGE_CACHE_SIZE);
349 }
350 return 0;
351}
352
353int simple_write_begin(struct file *file, struct address_space *mapping, 341int simple_write_begin(struct file *file, struct address_space *mapping,
354 loff_t pos, unsigned len, unsigned flags, 342 loff_t pos, unsigned len, unsigned flags,
355 struct page **pagep, void **fsdata) 343 struct page **pagep, void **fsdata)
356{ 344{
357 struct page *page; 345 struct page *page;
358 pgoff_t index; 346 pgoff_t index;
359 unsigned from;
360 347
361 index = pos >> PAGE_CACHE_SHIFT; 348 index = pos >> PAGE_CACHE_SHIFT;
362 from = pos & (PAGE_CACHE_SIZE - 1);
363 349
364 page = grab_cache_page_write_begin(mapping, index, flags); 350 page = grab_cache_page_write_begin(mapping, index, flags);
365 if (!page) 351 if (!page)
@@ -367,7 +353,12 @@ int simple_write_begin(struct file *file, struct address_space *mapping,
367 353
368 *pagep = page; 354 *pagep = page;
369 355
370 return simple_prepare_write(file, page, from, from+len); 356 if (!PageUptodate(page) && (len != PAGE_CACHE_SIZE)) {
357 unsigned from = pos & (PAGE_CACHE_SIZE - 1);
358
359 zero_user_segments(page, 0, from, from + len, PAGE_CACHE_SIZE);
360 }
361 return 0;
371} 362}
372 363
373/** 364/**
@@ -864,7 +855,6 @@ EXPORT_SYMBOL(simple_getattr);
864EXPORT_SYMBOL(simple_link); 855EXPORT_SYMBOL(simple_link);
865EXPORT_SYMBOL(simple_lookup); 856EXPORT_SYMBOL(simple_lookup);
866EXPORT_SYMBOL(simple_pin_fs); 857EXPORT_SYMBOL(simple_pin_fs);
867EXPORT_UNUSED_SYMBOL(simple_prepare_write);
868EXPORT_SYMBOL(simple_readpage); 858EXPORT_SYMBOL(simple_readpage);
869EXPORT_SYMBOL(simple_release_fs); 859EXPORT_SYMBOL(simple_release_fs);
870EXPORT_SYMBOL(simple_rename); 860EXPORT_SYMBOL(simple_rename);