diff options
author | Christoph Hellwig <hch@lst.de> | 2010-06-04 05:29:53 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2010-08-09 16:47:29 -0400 |
commit | eafdc7d190a944c755a9fe68573c193e6e0217e7 (patch) | |
tree | 915c3cc8004706fabf88eae1ab123a3fa0147516 /fs/jfs | |
parent | 256249584bda1a9357e2d29987a37f5b2df035f6 (diff) |
sort out blockdev_direct_IO variants
Move the call to vmtruncate to get rid of accessive blocks to the callers
in prepearation of the new truncate calling sequence. This was only done
for DIO_LOCKING filesystems, so the __blockdev_direct_IO_newtrunc variant
was not needed anyway. Get rid of blockdev_direct_IO_no_locking and
its _newtrunc variant while at it as just opencoding the two additional
paramters is shorted than the name suffix.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/jfs')
-rw-r--r-- | fs/jfs/inode.c | 17 |
1 files changed, 16 insertions, 1 deletions
diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index ed9ba6fe04f5..79e6cda28181 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c | |||
@@ -317,9 +317,24 @@ static ssize_t jfs_direct_IO(int rw, struct kiocb *iocb, | |||
317 | { | 317 | { |
318 | struct file *file = iocb->ki_filp; | 318 | struct file *file = iocb->ki_filp; |
319 | struct inode *inode = file->f_mapping->host; | 319 | struct inode *inode = file->f_mapping->host; |
320 | ssize_t ret; | ||
320 | 321 | ||
321 | return blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, | 322 | ret = blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, |
322 | offset, nr_segs, jfs_get_block, NULL); | 323 | offset, nr_segs, jfs_get_block, NULL); |
324 | |||
325 | /* | ||
326 | * In case of error extending write may have instantiated a few | ||
327 | * blocks outside i_size. Trim these off again. | ||
328 | */ | ||
329 | if (unlikely((rw & WRITE) && ret < 0)) { | ||
330 | loff_t isize = i_size_read(inode); | ||
331 | loff_t end = offset + iov_length(iov, nr_segs); | ||
332 | |||
333 | if (end > isize) | ||
334 | vmtruncate(inode, isize); | ||
335 | } | ||
336 | |||
337 | return ret; | ||
323 | } | 338 | } |
324 | 339 | ||
325 | const struct address_space_operations jfs_aops = { | 340 | const struct address_space_operations jfs_aops = { |