diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-05 09:40:36 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/jfs | |
parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/jfs')
-rw-r--r-- | fs/jfs/super.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/jfs/super.c b/fs/jfs/super.c index d9b0e92b3602..3eb13adf3862 100644 --- a/fs/jfs/super.c +++ b/fs/jfs/super.c | |||
@@ -183,6 +183,9 @@ static void jfs_put_super(struct super_block *sb) | |||
183 | int rc; | 183 | int rc; |
184 | 184 | ||
185 | jfs_info("In jfs_put_super"); | 185 | jfs_info("In jfs_put_super"); |
186 | |||
187 | lock_kernel(); | ||
188 | |||
186 | rc = jfs_umount(sb); | 189 | rc = jfs_umount(sb); |
187 | if (rc) | 190 | if (rc) |
188 | jfs_err("jfs_umount failed with return code %d", rc); | 191 | jfs_err("jfs_umount failed with return code %d", rc); |
@@ -195,6 +198,8 @@ static void jfs_put_super(struct super_block *sb) | |||
195 | sbi->direct_inode = NULL; | 198 | sbi->direct_inode = NULL; |
196 | 199 | ||
197 | kfree(sbi); | 200 | kfree(sbi); |
201 | |||
202 | unlock_kernel(); | ||
198 | } | 203 | } |
199 | 204 | ||
200 | enum { | 205 | enum { |