diff options
author | NeilBrown <neilb@suse.de> | 2006-03-26 04:37:18 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-26 11:56:55 -0500 |
commit | 2ff28e22bdb8727fbc7d7889807bc5a73aae56c5 (patch) | |
tree | f7418aa963d729bf9fe8bd44d6c9b6e424a6c6bf /fs/jfs/jfs_metapage.c | |
parent | 3978d7179d3849848df8a37dd0a5acc20bcb8750 (diff) |
[PATCH] Make address_space_operations->invalidatepage return void
The return value of this function is never used, so let's be honest and
declare it as void.
Some places where invalidatepage returned 0, I have inserted comments
suggesting a BUG_ON.
[akpm@osdl.org: JBD BUG fix]
[akpm@osdl.org: rework for git-nfs]
[akpm@osdl.org: don't go BUG in block_invalidate_page()]
Signed-off-by: Neil Brown <neilb@suse.de>
Acked-by: Dave Kleikamp <shaggy@austin.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/jfs/jfs_metapage.c')
-rw-r--r-- | fs/jfs/jfs_metapage.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 5fbaeaadccd3..8508043849f3 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c | |||
@@ -578,14 +578,13 @@ static int metapage_releasepage(struct page *page, gfp_t gfp_mask) | |||
578 | return 0; | 578 | return 0; |
579 | } | 579 | } |
580 | 580 | ||
581 | static int metapage_invalidatepage(struct page *page, unsigned long offset) | 581 | static void metapage_invalidatepage(struct page *page, unsigned long offset) |
582 | { | 582 | { |
583 | BUG_ON(offset); | 583 | BUG_ON(offset); |
584 | 584 | ||
585 | if (PageWriteback(page)) | 585 | BUG_ON(PageWriteback(page)); |
586 | return 0; | ||
587 | 586 | ||
588 | return metapage_releasepage(page, 0); | 587 | metapage_releasepage(page, 0); |
589 | } | 588 | } |
590 | 589 | ||
591 | struct address_space_operations jfs_metapage_aops = { | 590 | struct address_space_operations jfs_metapage_aops = { |