diff options
author | Arjan van de Ven <arjan@linux.intel.com> | 2007-02-12 03:55:39 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-12 12:48:46 -0500 |
commit | 92e1d5be91a0e3ffa5c4697eeb09b2aa22792122 (patch) | |
tree | 4eb22a9f6c38e9f4cc2a5100cd6659b0af08b7ae /fs/jffs2 | |
parent | 754661f143e70d66eae6c48532ca245aa05dec0e (diff) |
[PATCH] mark struct inode_operations const 2
Many struct inode_operations in the kernel can be "const". Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data. In addition it'll catch accidental writes at compile time to
these shared resources.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/jffs2')
-rw-r--r-- | fs/jffs2/dir.c | 2 | ||||
-rw-r--r-- | fs/jffs2/file.c | 2 | ||||
-rw-r--r-- | fs/jffs2/os-linux.h | 6 | ||||
-rw-r--r-- | fs/jffs2/symlink.c | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c index da6034d50718..cdbe2fe14e2d 100644 --- a/fs/jffs2/dir.c +++ b/fs/jffs2/dir.c | |||
@@ -46,7 +46,7 @@ const struct file_operations jffs2_dir_operations = | |||
46 | }; | 46 | }; |
47 | 47 | ||
48 | 48 | ||
49 | struct inode_operations jffs2_dir_inode_operations = | 49 | const struct inode_operations jffs2_dir_inode_operations = |
50 | { | 50 | { |
51 | .create = jffs2_create, | 51 | .create = jffs2_create, |
52 | .lookup = jffs2_lookup, | 52 | .lookup = jffs2_lookup, |
diff --git a/fs/jffs2/file.c b/fs/jffs2/file.c index 242875f77cb3..e82eeaf7590d 100644 --- a/fs/jffs2/file.c +++ b/fs/jffs2/file.c | |||
@@ -54,7 +54,7 @@ const struct file_operations jffs2_file_operations = | |||
54 | 54 | ||
55 | /* jffs2_file_inode_operations */ | 55 | /* jffs2_file_inode_operations */ |
56 | 56 | ||
57 | struct inode_operations jffs2_file_inode_operations = | 57 | const struct inode_operations jffs2_file_inode_operations = |
58 | { | 58 | { |
59 | .permission = jffs2_permission, | 59 | .permission = jffs2_permission, |
60 | .setattr = jffs2_setattr, | 60 | .setattr = jffs2_setattr, |
diff --git a/fs/jffs2/os-linux.h b/fs/jffs2/os-linux.h index 9f41fc01a371..e07a0edcdb4f 100644 --- a/fs/jffs2/os-linux.h +++ b/fs/jffs2/os-linux.h | |||
@@ -153,11 +153,11 @@ void jffs2_garbage_collect_trigger(struct jffs2_sb_info *c); | |||
153 | 153 | ||
154 | /* dir.c */ | 154 | /* dir.c */ |
155 | extern const struct file_operations jffs2_dir_operations; | 155 | extern const struct file_operations jffs2_dir_operations; |
156 | extern struct inode_operations jffs2_dir_inode_operations; | 156 | extern const struct inode_operations jffs2_dir_inode_operations; |
157 | 157 | ||
158 | /* file.c */ | 158 | /* file.c */ |
159 | extern const struct file_operations jffs2_file_operations; | 159 | extern const struct file_operations jffs2_file_operations; |
160 | extern struct inode_operations jffs2_file_inode_operations; | 160 | extern const struct inode_operations jffs2_file_inode_operations; |
161 | extern const struct address_space_operations jffs2_file_address_operations; | 161 | extern const struct address_space_operations jffs2_file_address_operations; |
162 | int jffs2_fsync(struct file *, struct dentry *, int); | 162 | int jffs2_fsync(struct file *, struct dentry *, int); |
163 | int jffs2_do_readpage_unlock (struct inode *inode, struct page *pg); | 163 | int jffs2_do_readpage_unlock (struct inode *inode, struct page *pg); |
@@ -166,7 +166,7 @@ int jffs2_do_readpage_unlock (struct inode *inode, struct page *pg); | |||
166 | int jffs2_ioctl(struct inode *, struct file *, unsigned int, unsigned long); | 166 | int jffs2_ioctl(struct inode *, struct file *, unsigned int, unsigned long); |
167 | 167 | ||
168 | /* symlink.c */ | 168 | /* symlink.c */ |
169 | extern struct inode_operations jffs2_symlink_inode_operations; | 169 | extern const struct inode_operations jffs2_symlink_inode_operations; |
170 | 170 | ||
171 | /* fs.c */ | 171 | /* fs.c */ |
172 | int jffs2_setattr (struct dentry *, struct iattr *); | 172 | int jffs2_setattr (struct dentry *, struct iattr *); |
diff --git a/fs/jffs2/symlink.c b/fs/jffs2/symlink.c index b90d5aa3d969..7e4882c8a7ed 100644 --- a/fs/jffs2/symlink.c +++ b/fs/jffs2/symlink.c | |||
@@ -20,7 +20,7 @@ | |||
20 | 20 | ||
21 | static void *jffs2_follow_link(struct dentry *dentry, struct nameidata *nd); | 21 | static void *jffs2_follow_link(struct dentry *dentry, struct nameidata *nd); |
22 | 22 | ||
23 | struct inode_operations jffs2_symlink_inode_operations = | 23 | const struct inode_operations jffs2_symlink_inode_operations = |
24 | { | 24 | { |
25 | .readlink = generic_readlink, | 25 | .readlink = generic_readlink, |
26 | .follow_link = jffs2_follow_link, | 26 | .follow_link = jffs2_follow_link, |