jffs2: Convert most D1/D2 macros to jffs2_dbg

D1 and D2 macros are mostly uses to emit debugging messages.

Convert the logging uses of D1 & D2 to jffs2_dbg(level, fmt, ...)
to be a bit more consistent style with the rest of the kernel.

All jffs2_dbg output is now at KERN_DEBUG where some of
the previous uses were emitted at various KERN_<LEVEL>s.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

1 files changed, 41 insertions, 33 deletions

diff --git a/fs/jffs2/write.c b/fs/jffs2/write.c
index 30d175b6d290..e137839a157d 100644
--- a/fs/jffs2/write.c
+++ b/fs/jffs2/write.c
@@ -36,7 +36,7 @@ int jffs2_do_new_inode(struct jffs2_sb_info *c, struct jffs2_inode_info *f,
         f->inocache->state = INO_STATE_PRESENT;
 
         jffs2_add_ino_cache(c, f->inocache);
-        D1(printk(KERN_DEBUG "jffs2_do_new_inode(): Assigned ino# %d\n", f->inocache->ino));
+        jffs2_dbg(1, "%s(): Assigned ino# %d\n", __func__, f->inocache->ino);
         ri->ino = cpu_to_je32(f->inocache->ino);
 
         ri->magic = cpu_to_je16(JFFS2_MAGIC_BITMASK);
@@ -95,9 +95,9 @@ struct jffs2_full_dnode *jffs2_write_dnode(struct jffs2_sb_info *c, struct jffs2
 
         if ((alloc_mode!=ALLOC_GC) && (je32_to_cpu(ri->version) < f->highest_version)) {
                 BUG_ON(!retried);
-                D1(printk(KERN_DEBUG "jffs2_write_dnode : dnode_version %d, "
-                                "highest version %d -> updating dnode\n",
-                                je32_to_cpu(ri->version), f->highest_version));
+                jffs2_dbg(1, "%s(): dnode_version %d, highest version %d -> updating dnode\n",
+                          __func__,
+                          je32_to_cpu(ri->version), f->highest_version);
                 ri->version = cpu_to_je32(++f->highest_version);
                 ri->node_crc = cpu_to_je32(crc32(0, ri, sizeof(*ri)-8));
         }
@@ -127,7 +127,7 @@ struct jffs2_full_dnode *jffs2_write_dnode(struct jffs2_sb_info *c, struct jffs2
 
                         retried = 1;
 
-                        D1(printk(KERN_DEBUG "Retrying failed write.\n"));
+                        jffs2_dbg(1, "Retrying failed write.\n");
 
                         jffs2_dbg_acct_sanity_check(c,jeb);
                         jffs2_dbg_acct_paranoia_check(c, jeb);
@@ -147,14 +147,16 @@ struct jffs2_full_dnode *jffs2_write_dnode(struct jffs2_sb_info *c, struct jffs2
 
                         if (!ret) {
                                 flash_ofs = write_ofs(c);
-                                D1(printk(KERN_DEBUG "Allocated space at 0x%08x to retry failed write.\n", flash_ofs));
+                                jffs2_dbg(1, "Allocated space at 0x%08x to retry failed write.\n",
+                                          flash_ofs);
 
                                 jffs2_dbg_acct_sanity_check(c,jeb);
                                 jffs2_dbg_acct_paranoia_check(c, jeb);
 
                                 goto retry;
                         }
-                        D1(printk(KERN_DEBUG "Failed to allocate space to retry failed write: %d!\n", ret));
+                        jffs2_dbg(1, "Failed to allocate space to retry failed write: %d!\n",
+                                  ret);
                 }
                 /* Release the full_dnode which is now useless, and return */
                 jffs2_free_full_dnode(fn);
@@ -183,10 +185,10 @@ struct jffs2_full_dnode *jffs2_write_dnode(struct jffs2_sb_info *c, struct jffs2
         fn->size = je32_to_cpu(ri->dsize);
         fn->frags = 0;
 
-        D1(printk(KERN_DEBUG "jffs2_write_dnode wrote node at 0x%08x(%d) with dsize 0x%x, csize 0x%x, node_crc 0x%08x, data_crc 0x%08x, totlen 0x%08x\n",
+        jffs2_dbg(1, "jffs2_write_dnode wrote node at 0x%08x(%d) with dsize 0x%x, csize 0x%x, node_crc 0x%08x, data_crc 0x%08x, totlen 0x%08x\n",
                   flash_ofs & ~3, flash_ofs & 3, je32_to_cpu(ri->dsize),
                   je32_to_cpu(ri->csize), je32_to_cpu(ri->node_crc),
-                  je32_to_cpu(ri->data_crc), je32_to_cpu(ri->totlen)));
+                  je32_to_cpu(ri->data_crc), je32_to_cpu(ri->totlen));
 
         if (retried) {
                 jffs2_dbg_acct_sanity_check(c,NULL);
@@ -206,9 +208,10 @@ struct jffs2_full_dirent *jffs2_write_dirent(struct jffs2_sb_info *c, struct jff
         int retried = 0;
         int ret;
 
-        D1(printk(KERN_DEBUG "jffs2_write_dirent(ino #%u, name at *0x%p \"%s\"->ino #%u, name_crc 0x%08x)\n",
+        jffs2_dbg(1, "%s(ino #%u, name at *0x%p \"%s\"->ino #%u, name_crc 0x%08x)\n",
+                  __func__,
                   je32_to_cpu(rd->pino), name, name, je32_to_cpu(rd->ino),
-                  je32_to_cpu(rd->name_crc)));
+                  je32_to_cpu(rd->name_crc));
 
         D1(if(je32_to_cpu(rd->hdr_crc) != crc32(0, rd, sizeof(struct jffs2_unknown_node)-4)) {
                 printk(KERN_CRIT "Eep. CRC not correct in jffs2_write_dirent()\n");
@@ -249,9 +252,9 @@ struct jffs2_full_dirent *jffs2_write_dirent(struct jffs2_sb_info *c, struct jff
 
         if ((alloc_mode!=ALLOC_GC) && (je32_to_cpu(rd->version) < f->highest_version)) {
                 BUG_ON(!retried);
-                D1(printk(KERN_DEBUG "jffs2_write_dirent : dirent_version %d, "
-                                     "highest version %d -> updating dirent\n",
-                                     je32_to_cpu(rd->version), f->highest_version));
+                jffs2_dbg(1, "%s(): dirent_version %d, highest version %d -> updating dirent\n",
+                          __func__,
+                          je32_to_cpu(rd->version), f->highest_version);
                 rd->version = cpu_to_je32(++f->highest_version);
                 fd->version = je32_to_cpu(rd->version);
                 rd->node_crc = cpu_to_je32(crc32(0, rd, sizeof(*rd)-8));
@@ -275,7 +278,7 @@ struct jffs2_full_dirent *jffs2_write_dirent(struct jffs2_sb_info *c, struct jff
 
                         retried = 1;
 
-                        D1(printk(KERN_DEBUG "Retrying failed write.\n"));
+                        jffs2_dbg(1, "Retrying failed write.\n");
 
                         jffs2_dbg_acct_sanity_check(c,jeb);
                         jffs2_dbg_acct_paranoia_check(c, jeb);
@@ -295,12 +298,14 @@ struct jffs2_full_dirent *jffs2_write_dirent(struct jffs2_sb_info *c, struct jff
 
                         if (!ret) {
                                 flash_ofs = write_ofs(c);
-                                D1(printk(KERN_DEBUG "Allocated space at 0x%08x to retry failed write.\n", flash_ofs));
+                                jffs2_dbg(1, "Allocated space at 0x%08x to retry failed write\n",
+                                          flash_ofs);
                                 jffs2_dbg_acct_sanity_check(c,jeb);
                                 jffs2_dbg_acct_paranoia_check(c, jeb);
                                 goto retry;
                         }
-                        D1(printk(KERN_DEBUG "Failed to allocate space to retry failed write: %d!\n", ret));
+                        jffs2_dbg(1, "Failed to allocate space to retry failed write: %d!\n",
+                                  ret);
                 }
                 /* Release the full_dnode which is now useless, and return */
                 jffs2_free_full_dirent(fd);
@@ -333,8 +338,8 @@ int jffs2_write_inode_range(struct jffs2_sb_info *c, struct jffs2_inode_info *f,
         int ret = 0;
         uint32_t writtenlen = 0;
 
-        D1(printk(KERN_DEBUG "jffs2_write_inode_range(): Ino #%u, ofs 0x%x, len 0x%x\n",
-                  f->inocache->ino, offset, writelen));
+        jffs2_dbg(1, "%s(): Ino #%u, ofs 0x%x, len 0x%x\n",
+                  __func__, f->inocache->ino, offset, writelen);
 
         while(writelen) {
                 struct jffs2_full_dnode *fn;
@@ -345,12 +350,13 @@ int jffs2_write_inode_range(struct jffs2_sb_info *c, struct jffs2_inode_info *f,
                 int retried = 0;
 
         retry:
-                D2(printk(KERN_DEBUG "jffs2_commit_write() loop: 0x%x to write to 0x%x\n", writelen, offset));
+                jffs2_dbg(2, "jffs2_commit_write() loop: 0x%x to write to 0x%x\n",
+                          writelen, offset);
 
                 ret = jffs2_reserve_space(c, sizeof(*ri) + JFFS2_MIN_DATA_LEN,
                                         &alloclen, ALLOC_NORMAL, JFFS2_SUMMARY_INODE_SIZE);
                 if (ret) {
-                        D1(printk(KERN_DEBUG "jffs2_reserve_space returned %d\n", ret));
+                        jffs2_dbg(1, "jffs2_reserve_space returned %d\n", ret);
                         break;
                 }
                 mutex_lock(&f->sem);
@@ -386,7 +392,7 @@ int jffs2_write_inode_range(struct jffs2_sb_info *c, struct jffs2_inode_info *f,
                         if (!retried) {
                                 /* Write error to be retried */
                                 retried = 1;
-                                D1(printk(KERN_DEBUG "Retrying node write in jffs2_write_inode_range()\n"));
+                                jffs2_dbg(1, "Retrying node write in jffs2_write_inode_range()\n");
                                 goto retry;
                         }
                         break;
@@ -399,7 +405,8 @@ int jffs2_write_inode_range(struct jffs2_sb_info *c, struct jffs2_inode_info *f,
                 }
                 if (ret) {
                         /* Eep */
-                        D1(printk(KERN_DEBUG "Eep. add_full_dnode_to_inode() failed in commit_write, returned %d\n", ret));
+                        jffs2_dbg(1, "Eep. add_full_dnode_to_inode() failed in commit_write, returned %d\n",
+                                  ret);
                         jffs2_mark_node_obsolete(c, fn->raw);
                         jffs2_free_full_dnode(fn);
 
@@ -414,7 +421,7 @@ int jffs2_write_inode_range(struct jffs2_sb_info *c, struct jffs2_inode_info *f,
                         ret = -EIO;
                         break;
                 }
-                D1(printk(KERN_DEBUG "increasing writtenlen by %d\n", datalen));
+                jffs2_dbg(1, "increasing writtenlen by %d\n", datalen);
                 writtenlen += datalen;
                 offset += datalen;
                 writelen -= datalen;
@@ -439,7 +446,7 @@ int jffs2_do_create(struct jffs2_sb_info *c, struct jffs2_inode_info *dir_f,
          */
         ret = jffs2_reserve_space(c, sizeof(*ri), &alloclen, ALLOC_NORMAL,
                                 JFFS2_SUMMARY_INODE_SIZE);
-        D1(printk(KERN_DEBUG "jffs2_do_create(): reserved 0x%x bytes\n", alloclen));
+        jffs2_dbg(1, "%s(): reserved 0x%x bytes\n", __func__, alloclen);
         if (ret)
                 return ret;
 
@@ -450,11 +457,11 @@ int jffs2_do_create(struct jffs2_sb_info *c, struct jffs2_inode_info *dir_f,
 
         fn = jffs2_write_dnode(c, f, ri, NULL, 0, ALLOC_NORMAL);
 
-        D1(printk(KERN_DEBUG "jffs2_do_create created file with mode 0x%x\n",
-                  jemode_to_cpu(ri->mode)));
+        jffs2_dbg(1, "jffs2_do_create created file with mode 0x%x\n",
+                  jemode_to_cpu(ri->mode));
 
         if (IS_ERR(fn)) {
-                D1(printk(KERN_DEBUG "jffs2_write_dnode() failed\n"));
+                jffs2_dbg(1, "jffs2_write_dnode() failed\n");
                 /* Eeek. Wave bye bye */
                 mutex_unlock(&f->sem);
                 jffs2_complete_reservation(c);
@@ -480,7 +487,7 @@ int jffs2_do_create(struct jffs2_sb_info *c, struct jffs2_inode_info *dir_f,
 
         if (ret) {
                 /* Eep. */
-                D1(printk(KERN_DEBUG "jffs2_reserve_space() for dirent failed\n"));
+                jffs2_dbg(1, "jffs2_reserve_space() for dirent failed\n");
                 return ret;
         }
 
@@ -597,8 +604,8 @@ int jffs2_do_unlink(struct jffs2_sb_info *c, struct jffs2_inode_info *dir_f,
                             !memcmp(fd->name, name, namelen) &&
                             !fd->name[namelen]) {
 
-                                D1(printk(KERN_DEBUG "Marking old dirent node (ino #%u) @%08x obsolete\n",
-                                          fd->ino, ref_offset(fd->raw)));
+                                jffs2_dbg(1, "Marking old dirent node (ino #%u) @%08x obsolete\n",
+                                          fd->ino, ref_offset(fd->raw));
                                 jffs2_mark_node_obsolete(c, fd->raw);
                                 /* We don't want to remove it from the list immediately,
                                    because that screws up getdents()/seek() semantics even
@@ -630,8 +637,9 @@ int jffs2_do_unlink(struct jffs2_sb_info *c, struct jffs2_inode_info *dir_f,
                                         printk(KERN_WARNING "Deleting inode #%u with active dentry \"%s\"->ino #%u\n",
                                                dead_f->inocache->ino, fd->name, fd->ino);
                                 } else {
-                                        D1(printk(KERN_DEBUG "Removing deletion dirent for \"%s\" from dir ino #%u\n",
-                                                fd->name, dead_f->inocache->ino));
+                                        jffs2_dbg(1, "Removing deletion dirent for \"%s\" from dir ino #%u\n",
+                                                  fd->name,
+                                                  dead_f->inocache->ino);
                                 }
                                 if (fd->raw)
                                         jffs2_mark_node_obsolete(c, fd->raw);