aboutsummaryrefslogtreecommitdiffstats
path: root/fs/jffs2/super.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2009-05-05 09:40:36 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2009-06-11 21:36:07 -0400
commit6cfd0148425e528b859b26e436b01f23f6926224 (patch)
tree60e3257053554ff198fe5825e6f12a00c3b4422a /fs/jffs2/super.c
parenta9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff)
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of filesystems had trivial enough ->put_super (only kfree and NULLing of s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs, hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most of them probably don't need it, but I'd rather sort that out individually. Preferably after all the other BKL pushdowns in that area. [AV: original used to move lock_super() down as well; these changes are removed since we don't do lock_super() at all in generic_shutdown_super() now] [AV: fuse, btrfs and xfs are known to need no damn BKL, exempt] Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/jffs2/super.c')
-rw-r--r--fs/jffs2/super.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index 5059e9633edb..37b12125c127 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -174,6 +174,8 @@ static void jffs2_put_super (struct super_block *sb)
174 174
175 D2(printk(KERN_DEBUG "jffs2: jffs2_put_super()\n")); 175 D2(printk(KERN_DEBUG "jffs2: jffs2_put_super()\n"));
176 176
177 lock_kernel();
178
177 if (sb->s_dirt) 179 if (sb->s_dirt)
178 jffs2_write_super(sb); 180 jffs2_write_super(sb);
179 181
@@ -195,6 +197,8 @@ static void jffs2_put_super (struct super_block *sb)
195 if (c->mtd->sync) 197 if (c->mtd->sync)
196 c->mtd->sync(c->mtd); 198 c->mtd->sync(c->mtd);
197 199
200 unlock_kernel();
201
198 D1(printk(KERN_DEBUG "jffs2_put_super returning\n")); 202 D1(printk(KERN_DEBUG "jffs2_put_super returning\n"));
199} 203}
200 204